selsta: looks like 6488 does work on Windows. I had a DOS code page selected instead of a Windows one. Not sure what the default is.

iDunk: hmm ty for testing, I might test myself in a VM to see what default is

OTOH, that might be with the SO fix. I'll recompile...

It was with the SO fix. This is what works for my with the Windows code page for my locale paste.debian.net/hidden/f71ae9d3

The mlog.cpp stuff I commented out is not necessary any more since moneromooo fixed colors display on Windws. That alone does not fix 6488 on Windows.

okay so the u8 is necessary?

interesting

I wasn’t sure if it makes a difference

I'm building without it now.

Looks like it works without it. On to a different test...

The other test looks promising as well, although I don't see chinese characters in the terminal, just squares paste.debian.net/hidden/38cb9635

iDunk: so which diff would you recommend now?

just adding `SetConsoleOutputCP(CP_UTF8);` into main?

Yes

ok nice, seems simple

With the caveat that a Windows code page needs to be selected initially, not a DOS one.

updated the PR

I would say let’s only merge this to master for now

not include this with the next release

and get some feedback

selsta: current 6488 on Windows paste.debian.net/hidden/4370bf9d

looks good

Did somebody check whether file names and passwords with non-ASCII characters still work correctly after using that code page setting call? Sometimes things are pretty fragile there on Windows

And to be absolute sure one would have to set a password with "special" characters with an unmodified build and then check with the modified one whether that password still works ...

6488 fails with "Error: failed to generate new wallet: boost::filesystem::path codecvt to wstring: error", v0.15.0.5 generates the wallet.

okay :/ will undo the change for now