14:26:46 <iDunk> selsta: looks like 6488 does work on Windows. I had a DOS code page selected instead of a Windows one. Not sure what the default is.
14:28:31 <selsta> iDunk: hmm ty for testing, I might test myself in a VM to see what default is
14:30:16 <iDunk> OTOH, that might be with the SO fix. I'll recompile...
15:02:45 <iDunk> It was with the SO fix. This is what works for my with the Windows code page for my locale  https://paste.debian.net/hidden/f71ae9d3/
15:03:39 <iDunk> The mlog.cpp stuff I commented out is not necessary any more since moneromooo fixed colors display on Windws. That alone does not fix 6488 on Windows.
15:05:29 <selsta> okay so the u8 is necessary?
15:05:32 <selsta> interesting
15:05:40 <selsta> I wasn’t sure if it makes a difference
15:05:43 <iDunk> I'm building without it now.
15:07:28 <iDunk> Looks like it works without it. On to a different test...
15:10:46 <iDunk> The other test looks promising as well, although I don't see chinese characters in the terminal, just squares  https://paste.debian.net/hidden/38cb9635/
17:17:04 <selsta> iDunk: so which diff would you recommend now?
17:17:16 <selsta> just adding `SetConsoleOutputCP(CP_UTF8);` into main?
17:18:05 <iDunk> Yes
17:19:05 <selsta> ok nice, seems simple
17:19:26 <iDunk> With the caveat that a Windows code page needs to be selected initially, not a DOS one.
17:21:15 <selsta> updated the PR
17:22:39 <selsta> I would say let’s only merge this to master for now
17:22:51 <selsta> not include this with the next release
17:22:53 <selsta> and get some feedback
17:40:33 <iDunk> selsta: current 6488 on Windows  https://paste.debian.net/hidden/4370bf9d/
17:41:51 <selsta> looks good
17:50:27 <rbrunner> Did somebody check whether file names and passwords with non-ASCII characters still work correctly after using that code page setting call? Sometimes things are pretty fragile there on Windows
17:53:47 <rbrunner> And to be absolute sure one would have to set a password with "special" characters with an unmodified build and then check with the modified one whether that password still works ...
18:03:18 <iDunk> 6488 fails with "Error: failed to generate new wallet: boost::filesystem::path codecvt to wstring: error", v0.15.0.5 generates the wallet.
18:03:46 <selsta> okay :/ will undo the change for now