-
azy
is there a simple way of distinguishing the amount of integrated address use vs subaddress use?
-
azy
i'd like to display the % use of each on my monero stats website
-
moneromooo
If extra has an extra pubkeys field, it means at least one recipient used a subaddress. For integrated address vs standard, you can't really tell since a dummy one's added now.
-
azy
how do i decode the extra? "extra - Usually called the "payment ID" but can be used to include any random 32 bytes."
-
azy
-
moneromooo
parse_tx_extra (cryptonote_format_utils.h)
-
azy
ty
-
moneromooo
There's probably an english explanation somewhere on monero.stackexchange.com.
-
azy
there is, neat
-
azy
"it means at least one recipient used a subaddress" - and that means that the transaction definitely paid a subaddress?
-
azy
if i were to count all tx with no "TX_EXTRA_TAG_ADDITIONAL_PUBKEYS" byte as "not a subaddress transaction", that would be correct?
-
azy
-
azy
-
azy
-
moneromooo
No, someone could add this tag without paying a subaddress.
-
selsta
can anyone think of a prettier solution than ifdef?
monero-project/monero #6488#issuecomment-622505062
-
selsta
a print function / lambda that uses the correct cout?
-
moneromooo
A function that does it, so at least you have just one of them.
-
selsta
ok
-
moneromooo
It's odd it wouldn't work though, since printing messages works on Windows (or we'd have heard about it).
-
moneromooo
So why does it not work with those particular calls ?
-
moneromooo
And maybe the chars should be sent encoded as UTF-8, rather than code points.
-
» moneromooo guessing
-
selsta
will try utf8 first
-
selsta
but AFAIK windows console + utf8 is always a bit tricky
-
moneromooo
"ga" in vim shows encoding for any char.
-
selsta
ga looks quite useful
-
rbrunner
"ga" like in (g)aracter (a)ncoding, I guess?
-
selsta
moneromooo: you mean like this?
paste.debian.net/hidden/f6b3de8b
-
moneromooo
I was thinking the hex codes, but I guess if it works like that, even better :)
-
selsta
seems to also work on mac, iDunk could you test on top of latest version of my PR?
-
selsta
-
azy
why would somebody add the tag without paying a subaddress?
-
azy
is there even a good way of seeing how often subaddresses are used vs not subaddresses?
-
moneromooo
To confuse your system.
-
azy
so it's unlikely? then it seems like a nice way of seeing the adoption rate/use of subaddresses?
-
moneromooo
Yes, unlikely. But your question was "and that means that the transaction definitely paid a subaddress?"
-
azy
i appreciate it
-
UkoeHB_
azy counting pub keys is not nearly enough to know how many tx have a sub address recipient, since most or all 2-output tx with a subaddress recipient will have 1 tx pub key, and even some >2 output tx
-
selsta
are there any must have PRs still open that have to get into v0.15.1.0?
-
moneromooo
6409 6418 (I've not reviewed the 0mq specific stuff though) 6431 6441 6451 6467 6468 6471 6472 6477 6478 6480 6481 6484 6485 6486
-
selsta
that.. was quick
-
selsta
:P
-
moneromooo
Sorry. I just failed the Turing test didn't I.
-
moneromooo
I had just sent dEBRUYNE that list :P
-
moneromooo
(phew, nice save)
-
selsta
:D
-
moneromooo
Any opinions on 6426 6427 ? It feels iffy (especially the latter), but no strong dislike.
-
moneromooo
Also if someone who uses docker can check 6428 6434 that would be nice.
-
selsta
6428 is a duplicate
-
selsta
I thought we closed it already..
-
moneromooo
6421: not sure about that one, it might make DoS easier. Any opinion ?
-
selsta
I commented on 6434
-
moneromooo
sarang: I assume 6329 is still WIP as it's still marked as such ?
-
selsta
moneromooo: can you close 6428 as a duplicate of 6420? I can’t do it
-
moneromooo
done.
-
sarang
6329 needs a unit test with a V1 proof
-
iDunk
selsta: it doesn't work, but nothing's changed, really.
-
selsta
iDunk: okay, one more question, does the endl also have to be printed out with wcout?
-
iDunk
It doesn't even print a single line, so inconclusive.
-
selsta
I meant with your patch
-
selsta
that you posted on Github
-
iDunk
Yes, otherwise everything gets printed on a single line, IIRC.
-
iDunk
With that SO patch, I lose colors if I set vbuff to 1000, colors still there with vbuff 0. And that's with and without u8.
-
iDunk
Btw, that SO article seems to be for VS, not mingw.