ErCiccione ErCiccione[m]: I'm happy to review -site MRs, but are you looking for content reviews, build tests, etc.?

I don't presently have the tools or experience in build testing for -site

sarang: thank you. Some PR need to be tested, for other a simple content review would be ok. for example repo.getmonero.org/monero-project/monero-site/merge_requests/1191 simply adds a note and the "untranslated" snippet were it was forgotten

but a review of the note would be more than enough

The PR adding merchants don't need to be tested as well: repo.getmonero.org/monero-project/monero-site/merge_requests/1214

How should I know which are content-review and which are build-review?

I'm always hesitant to thumbs-up an MR that could break a build

Yeah i understand. I think it's necessary to see case by case. In general, if there are only string changes or new merchants it's not strictly necessary to test them locally

btw i test all my PR, so none of them should break the build, but i understand your point

sarang: what about that clsag paper btw? still waiting for a review from surae or only needs to be rebased?

I am still waiting on surae

alright

and that's just for the title/abstract confirmation

Any document changes will appear on IACR (I don't like keeping two versions around)

no need for an MR for those; they're instantaneous

I'll probably just do a new MR... rebasing would probably take just as long :/

makes sense

OK, so I have a few minutes to spare

lemme check those MR links you had

Thanks :)

OK, so !1191 and !1214 ?

Yep

1214 done

with an appropriate caveat :)

only checked that the URLs are correct and the sites list something about Monero

actually 1211 it's quick stuff too. Just removes old ffs variables that don't exist anymore (since we moved to the ccS)

the sites list something about Monero -> that we already check after the issue is opened. There is a "needs investigation" label that i remove after somebody checked they actually list monero. A double check doesn't hurt tho

to be clear the process is usually like this: merchant open issue using the template -> i add 'merchant' and 'needs investigation' label -> somebody check they actually list monero -> i remove the 'needs investigation' label

OK, that's what I checked: "do they list Monero"

and "does the URL go to a site with that name"

Perfect

btw i will add more clearly in the merchant page that we don't deeply investigate the merchants listed and that we don't endorse any of those merchants. There is an open issue about it: repo.getmonero.org/monero-project/monero-site/issues/1042

.merge+ #1214

Added