19:13:29 <sarang> ErCiccione ErCiccione[m]: I'm happy to review -site MRs, but are you looking for content reviews, build  tests, etc.?
19:13:41 <sarang> I don't presently have the tools or experience in build testing for -site
19:16:54 <ErCiccione> sarang: thank you. Some PR need to be tested, for other a simple content review would be ok. for example https://repo.getmonero.org/monero-project/monero-site/merge_requests/1191 simply adds a note and the "untranslated" snippet were it was forgotten
19:17:07 <ErCiccione> but a review of the note would be more than enough
19:18:46 <ErCiccione> The PR adding merchants don't need to be tested as well: https://repo.getmonero.org/monero-project/monero-site/merge_requests/1214
19:18:48 <sarang> How should I know which are content-review and which are build-review?
19:19:02 <sarang> I'm always hesitant to thumbs-up an MR that could break a build
19:20:32 <ErCiccione> Yeah i understand. I think it's necessary to see case by case. In general, if there are only string changes or new merchants it's not strictly necessary to test them locally
19:20:54 <ErCiccione> btw i test all my PR, so none of them should break the build, but i understand your point
19:24:04 <ErCiccione> sarang: what about that clsag paper btw? still waiting for a review from surae or only needs to be rebased?
19:24:24 <sarang> I am still waiting on surae
19:25:37 <ErCiccione> alright
19:26:15 <sarang> and that's just for the title/abstract confirmation
19:26:30 <sarang> Any document changes will appear on IACR (I don't like keeping two versions around)
19:26:40 <sarang> no need for an MR for those; they're instantaneous
19:27:14 <sarang> I'll probably just do a new MR... rebasing would probably take just as long :/
19:27:18 <ErCiccione> makes sense
19:27:33 <sarang> OK, so I have a few minutes to spare
19:27:39 <sarang> lemme check those MR links you had
19:28:09 <ErCiccione[m]> Thanks :)
19:28:50 <sarang> OK, so !1191 and !1214 ?
19:30:11 <ErCiccione[m]> Yep
19:32:39 <sarang> 1214 done
19:32:58 <sarang> with an appropriate caveat :)
19:33:11 <sarang> only checked that the URLs are correct and the sites list something about Monero
19:33:13 <ErCiccione[m]> actually 1211 it's quick stuff too. Just removes old ffs variables that don't exist anymore (since we moved to the ccS)
19:34:38 <ErCiccione[m]>  the sites list something about Monero -> that we already check after the issue is opened. There is a "needs investigation" label that i remove after somebody checked they actually list monero. A double check doesn't hurt tho
19:35:41 <ErCiccione[m]> to be clear the process is usually like this: merchant open issue using the template -> i add 'merchant' and 'needs investigation' label -> somebody check they actually list monero -> i remove the 'needs investigation' label
19:35:44 <sarang> OK, that's what I checked: "do they list Monero"
19:35:58 <sarang> and "does the URL go to a site with that name"
19:36:18 <ErCiccione[m]> Perfect
19:38:35 <ErCiccione[m]> btw i will add more clearly in the merchant page that we don't deeply investigate the merchants listed and that we don't endorse any of those merchants. There is an open issue about it: https://repo.getmonero.org/monero-project/monero-site/issues/1042
19:38:43 <ErCiccione[m]> .merge+ #1214
19:38:43 <xmr-pr> Added