Monero BADCACA nodes are proudly sponsored by Ryo Currency dev fund.

sech1: do you have time to do one last look into 7054

for the p2p PoW, will a peer have to periodically redo the handshake and associated work? i can imagine a malicious node could perform the PoW to get connected and otherwise look legit, and then initiate malicious behaviors

being challenged every n blocks (probably random n blocks) might address this ... ?

selsta I've reviewed it. One minor issue spotted but overall approved.

thanks

.merges

.merge+ 7054 7055

Added

No. Only on connect. There'd be no point in asking periodically.

Hello everyone, moneromooo or selsta (both have been watching the issue), I was able to get the correct timestamp for the wallet and the rpcpayserver. I'll leave the issue here if anyone else wants to check it out (monero-project/monero #7041). Thanks :)

Thanks. The log isn't very helpful unfortunately, I'll have to work with that.

Still useful for some things. Like it's not calling rpc_access_info though it should.

Does it recover if you let it run ?

If my theory of what's going wrong is correct, it should.

No, doesn't seem to, the timestamps in the log last for too long.

No, it keeps on getting the message error. I thought it would. At some point it stopped showing the message, but after a few minutes the error message ketp showing. I left the wallet opened 6 minutes, not sure if that's not enough.

It is enough.

okay, if you need anything else from this side let me know

Can you run with a log patch if I send one ? ie, do you know how to apply a patch and build ?

I don't know how to apply it but I can find the way.

lh1008: paste.debian.net/hidden/ae24ed22

patch -p1 < FILENAME

(and save the patch as FILENAME first)

Run with the same log level as you did, send matching logs.

Okay, I'll first learn how to add the patch, build, and then run it. Thank you moneromooo.

"patch -p1 < FILENAME" adds the patch.

this should be done in the monero folder?

Yes.

okay, patching file src/rpc/rpc_payment.cpp patching file src/wallet/node_rpc_proxy.cpp patching file src/wallet/wallet_rpc_payments.cpp

to build should I use the make command?

Same as you normally do.

or just run it?

-__-

You'd run your old binary if you don't build what you patched.

hey guys

I'm a bit confused as to how I am to use the JSON RPC or regular RPC methods in PHP

would I use shell_exec with the curl commands?

or is there some other more elegant way to do it

Example: curl -k -X POST 127.0.0.1:18081/json_rpc -d '{"jsonrpc":"2.0","id":"0","method":"get_fee_estimate","params":{"grace_blocks":10}}' -H 'Content-Type: application/json'

locustlord, github.com/monero-integrations/monerophp

thanks azy

I assume that once it is in production I would take it off of the test net?

put it onto the real darn deal and all that good stuff?

FenderQ: monero-project/monero #6996

I built using master 7ca4ef0d749848dd4c4368d00dcb7a4c31dfed9c

December 4

Then I guess it's still not thread safe. Please file a new bug.

ok thanks

okay, I build the new code with the patch. How can I run it? In the /bin folder I have the latest Oxygen Orion v0.17.1.5 version but that ain't what I just built. How to run what I just built?

Same as before.

The new one will have replaced the old one.

locustlord, you can set it to stagenet while youre coding. testnet is not for testing code. you can get free stagenet coins from xmr.to

Well, same as before except adapt the binaries to specify the paths (build/etc/etc/bin/...)

okay, there's a lot I have to learn. I don't know how to adapt the binaries to specify the paths and I have to go. Thank you moneromooo for your assistance.

You replace, eg, monerod (or /usr/local/bin/monerod, or whatever) with build/wherever/it/is/bin/monerod.

Same with monero-wallet-cli.

The actual path wlil depend on your OS and branch.

So don't actually use wherever/it/is.

Also, it will still say v0.17.1.5-release as version, if that's what you built before patching, if you built your binaries and not used the ones you downloaded.

luigi1111: CLI would be ready for merges + tag

K I'm afk right now. Can probably get to it tonight

luigi1111: please also tag GUI later, I will write you instructions how to do version bump

luigi1111: for GUI version bump instructions irccloud.com/pastebin/1aOoEQBy

will most likely be asleep later