08:38:43 <qzesvgacztxw> Monero BADCACA nodes are proudly sponsored by Ryo Currency dev fund. 14:19:07 <selsta> sech1: do you have time to do one last look into 7054 14:45:56 <gingeropolous> for the p2p PoW, will a peer have to periodically redo the handshake and associated work? i can imagine a malicious node could perform the PoW to get connected and otherwise look legit, and then initiate malicious behaviors 14:47:36 <gingeropolous> being challenged every n blocks (probably random n blocks) might address this ... ? 15:25:31 <sech1> selsta I've reviewed it. One minor issue spotted but overall approved. 15:26:16 <selsta> thanks 15:28:56 <selsta> .merges 15:28:56 -xmr-pr- 7063 7065 7070 7071 7072 7073 7076 15:30:06 <selsta> .merge+ 7054 7055 15:30:06 <xmr-pr> Added 15:59:00 <moneromooo> No. Only on connect. There'd be no point in asking periodically. 17:47:31 <lh1008> Hello everyone, moneromooo or selsta (both have been watching the issue), I was able to get the correct timestamp for the wallet and the rpcpayserver. I'll leave the issue here if anyone else wants to check it out (https://github.com/monero-project/monero/issues/7041). Thanks :) 17:56:17 <moneromooo> Thanks. The log isn't very helpful unfortunately, I'll have to work with that. 17:57:46 <moneromooo> Still useful for some things. Like it's not calling rpc_access_info though it should. 17:59:09 <moneromooo> Does it recover if you let it run ? 17:59:28 <moneromooo> If my theory of what's going wrong is correct, it should. 18:00:27 <moneromooo> No, doesn't seem to, the timestamps in the log last for too long. 18:01:18 <lh1008> No, it keeps on getting the message error. I thought it would. At some point it stopped showing the message, but after a few minutes the error message ketp showing. I left the wallet opened 6 minutes, not sure if that's not enough. 18:01:52 <moneromooo> It is enough. 18:02:45 <lh1008> okay, if you need anything else from this side let me know 18:04:08 <moneromooo> Can you run with a log patch if I send one ? ie, do you know how to apply a patch and build ? 18:05:05 <lh1008> I don't know how to apply it but I can find the way. 18:26:33 <moneromooo> lh1008: https://paste.debian.net/hidden/ae24ed22/ 18:26:39 <moneromooo> patch -p1 < FILENAME 18:26:46 <moneromooo> (and save the patch as FILENAME first) 18:27:08 <moneromooo> Run with the same log level as you did, send matching logs. 18:29:31 <lh1008> Okay, I'll first learn how to add the patch, build, and then run it. Thank you moneromooo. 18:30:23 <moneromooo> "patch -p1 < FILENAME" adds the patch. 18:31:51 <lh1008> this should be done in the monero folder? 18:32:10 <moneromooo> Yes. 18:34:49 <lh1008> okay, patching file src/rpc/rpc_payment.cpp patching file src/wallet/node_rpc_proxy.cpp patching file src/wallet/wallet_rpc_payments.cpp 18:36:06 <lh1008> to build should I use the make command? 18:36:15 <moneromooo> Same as you normally do. 18:36:33 <lh1008> or just run it? 18:36:54 <iDunk> -__- 18:37:54 <iDunk> You'd run your old binary if you don't build what you patched. 18:59:13 <locustlord> hey guys 18:59:29 <locustlord> I'm a bit confused as to how I am to use the JSON RPC or regular RPC methods in PHP 19:00:14 <locustlord> would I use shell_exec with the curl commands? 19:00:21 <locustlord> or is there some other more elegant way to do it 19:05:54 <moneromooo> Example: curl -k -X POST http://127.0.0.1:18081/json_rpc -d '{"jsonrpc":"2.0","id":"0","method":"get_fee_estimate","params":{"grace_blocks":10}}' -H 'Content-Type: application/json' 19:06:31 <azy> locustlord, https://github.com/monero-integrations/monerophp 19:06:54 <azy> https://github.com/monero-integrations/monerophp/blob/master/example.php 19:07:19 <locustlord> thanks azy 19:08:02 <locustlord> I assume that once it is in production I would take it off of the test net? 19:10:07 <locustlord> put it onto the real darn deal and all that good stuff? 19:11:11 <moneromooo> FenderQ: https://github.com/monero-project/monero/pull/6996 19:13:23 <FenderQ> I built using master 7ca4ef0d749848dd4c4368d00dcb7a4c31dfed9c 19:13:29 <FenderQ> December 4 19:16:00 <moneromooo> Then I guess it's still not thread safe. Please file a new bug. 19:16:09 <FenderQ> ok thanks 19:16:50 * FenderQ is also testing using https://man.openbsd.org/malloc options S 19:28:14 <lh1008> okay, I build the new code with the patch. How can I run it? In the /bin folder I have the latest Oxygen Orion v0.17.1.5 version but that ain't what I just built. How to run what I just built? 19:28:34 <moneromooo> Same as before. 19:28:49 <moneromooo> The new one will have replaced the old one. 19:28:57 <azy> locustlord, you can set it to stagenet while youre coding. testnet is not for testing code. you can get free stagenet coins from xmr.to 19:29:25 * iDunk doubts there ever was an old one 19:30:12 <moneromooo> Well, same as before except adapt the binaries to specify the paths (build/etc/etc/bin/...) 20:50:56 <lh1008> okay, there's a lot I have to learn. I don't know how to adapt the binaries to specify the paths and I have to go. Thank you moneromooo for your assistance. 20:52:51 <moneromooo> You replace, eg, monerod (or /usr/local/bin/monerod, or whatever) with build/wherever/it/is/bin/monerod. 20:52:57 <moneromooo> Same with monero-wallet-cli. 20:53:19 <moneromooo> The actual path wlil depend on your OS and branch. 20:53:29 <moneromooo> So don't actually use wherever/it/is. 20:55:42 <iDunk> Also, it will still say v0.17.1.5-release as version, if that's what you built before patching, if you built your binaries and not used the ones you downloaded. 23:21:52 <selsta> luigi1111: CLI would be ready for merges + tag 23:37:07 <luigi1111> K I'm afk right now. Can probably get to it tonight 23:48:23 <selsta> luigi1111: please also tag GUI later, I will write you instructions how to do version bump 23:51:31 <selsta> luigi1111: for GUI version bump instructions https://www.irccloud.com/pastebin/1aOoEQBy/ 23:51:50 <selsta> will most likely be asleep later