-
hyc
you could use asm to declare it as a weak extern
-
hyc
what do you want to do with wrap?
-
hyc
hmm
-
hyc
/home/software/bitmonero/src/wallet/wallet2.cpp:3332:8: warning: variable ‘refreshed’ set but not used [-Wunused-but-set-variable]
-
sarang
I've seen that warning for a looooong time
-
hyc
yeah, we should probably get rid of it at some point :P
-
sarang
yes plz
-
hyc
wondering if it ought to be referenced at :3513
-
hyc
m_first_refresh_done = true;
-
hyc
it's set at 2 places inside a while loop
-
sarang
how wasteful
-
hyc
but nothing reads it...
-
hyc
it was used in its original commit 0c57df9770
-
sarang
Does that use case still apply?
-
hyc
it got turned into a constant in 27457a2268
-
hyc
so I guess it's now just cruft
-
sarang
go go go
-
sarang
I think that's what we call "low-hanging fruit"
-
hyc
yeah
-
» sarang was clearly too lazy to change it
-
sarang
I figured that it had some other use that I was missing
-
sarang
i.e. why risk removing it, eh?
-
hyc
yeah, never touch without tracking the history
-
hyc
I'll PR after my current build finishes
-
hyc
huh, the ACM President's name is Cherri Pancake ? srsly?
-
moneromooo
Someone made a patch to remove it a while back, but it needs checking if it's still needed first.
-
hyc
moneromooo: your commit 27457a2268 removed the only usage of that var
-
moneromooo
And when I added that at the time, I remember there was a corner case where it was needed, just can't recall the details.
-
moneromooo
I suppose we might as well remove and fix it later if/when it subtly and rarely breaks.
-
moneromooo
Since it'll also do that now.
-
hyc
ah I found the PR, #6310
-
moneromooo
But in that case there's a PR for it already.
-
hyc
well, if there's a corner case, people should be hitting it already, no?
-
moneromooo
Maybe they are.
-
moneromooo
I want to say it's a race when a tx can be thought flushed but will be mined but I'm not 100% sure.
-
hyc
hm. that last commit is from Nov 4 2019, so it would have been in the previous release?
-
moneromooo
If it is that, then some code calling monero-wallet-rpc could think a payment wasn't made.
-
hyc
meh. ok I'll leave it alone ;)
-
moneromooo
Feel free to check whether it can happen since it appears I've not done it yet in all that time :S
-
sarang
Is there a good way to adjust how that's structured to avoid something that appears unused?
-
hyc
PR#6310 will shut up the warning, but I suppose it's better to leave it there to remind someone that eventually it ought to be really investigated
-
tobtoht
With Dandelion++; if a node hasn't received a transaction back within a certain amount of time (i.e. black-hole attack), it will initiate a fluff phase for that transaction, correct?
-
tobtoht
When it initiates the fluff phase will it add the transaction to its public transaction pool?
-
woodser
with unconfirmed transactions, `get_reserve_proof` returns a valid proof when called with an account index and an amount greater than the account's balance. checking the proof gives a total amount greater than the requested proof amount and a non-zero `spent` amount. is this expected behavior? I figured the proof would only succeed with an amount less than or equal to the account balance.
-
moneromooo
Presumably not.
-
woodser
since updating to 0.16.0.0, I get this response from daemon rpc `relay_tx`: {error={code=0, message=}, id=0, jsonrpc=2.0}
-
woodser
it works when the daemon is switched back to 0.15.0.5
-
moneromooo
File two bugs.
-
sarang
Research meeting in #monero-research-lab begins at 17:00 UTC (about half an hour from now)
-
sarang
Anything still blocking Windows CI?
-
selsta
yes, luigi has to merge :D
-
sarang
boo
-
sarang
I'm holding off on some rebases for that
-
sarang
I don't want to merge something that doesn't pass all builds
-
selsta
luigi1111w: ^^^^ :)
-
luigi1111w
which pr
-
selsta
#6531 #6535 #6582
-
sarang
selsta: you mentioned a boost-related PR as well
-
sarang
but jtgrassie noted another issue with that
-
sarang
gotta get that green checkmark
-
selsta
IMO supporting newer boost is more important than old boost
-
sarang
Sounds like newer boost breaks Ubuntu builds?
-
selsta
not really
-
selsta
16.04 maybe
-
sarang
ok
-
sarang
Isn't that what CI uses?
-
selsta
CI uses 18.04
-
sarang
Ah, maybe I'm thinking of the repro builds
-
sarang
?
-
selsta
no, should not break anything we use, only old distros like Ubuntu 16.04
-
selsta
but vtnerd said he will fix it so that it works for newer and older boost versions
-
sarang
got it
-
selsta
for now I would prefer to merge it so that Windows CI works again
-
sarang
seems like a good idea
-
hyc
repro builds are also ubuntu 18.04
-
sarang
godspeed
-
sarang
I look forward to rebasing branches :D
-
luigi1111w
6582 needs a stamp
-
selsta
sarang: can you approve it? it changes the msys2 actions to a maintained one
-
selsta
-
sarang
I'm unable to test it of course, but can confirm the repo change
-
sarang
noted
-
sarang
^ selsta luigi1111w
-
» sarang is on pins and needles