00:01:38 <hyc> you could use asm to declare it as a weak extern
00:01:49 <hyc> what do you want to do with wrap?
00:42:46 <hyc> hmm
00:43:07 <hyc>  /home/software/bitmonero/src/wallet/wallet2.cpp:3332:8: warning: variable ‘refreshed’ set but not used [-Wunused-but-set-variable]
00:44:19 <sarang> I've seen that warning for a looooong time
00:45:08 <hyc> yeah, we should probably get rid of it at some point :P
00:45:31 <sarang> yes plz
00:45:38 <hyc> wondering if it ought to be referenced at :3513
00:45:50 <hyc> m_first_refresh_done = true;
00:46:12 <hyc> it's set at 2 places inside a while loop
00:46:25 <sarang> how wasteful
00:46:31 <hyc> but nothing reads it...
00:48:08 <hyc> it was used in its original commit 0c57df9770
00:49:36 <sarang> Does that use case still apply?
00:49:55 <hyc> it got turned into a constant in 27457a2268
00:50:15 <hyc> so I guess it's now just cruft
00:50:51 <sarang> go go go
00:51:09 <sarang> I think that's what we call "low-hanging fruit"
00:51:15 <hyc> yeah
00:51:29 * sarang was clearly too lazy to change it
00:51:43 <sarang> I figured that it had some other use that I was missing
00:51:50 <sarang> i.e. why risk removing it, eh?
00:52:31 <hyc> yeah, never touch without tracking the history
00:53:04 <hyc> I'll PR after my current build finishes
00:54:42 <hyc> huh, the ACM President's name is Cherri Pancake ? srsly?
00:54:54 <moneromooo> Someone made a patch to remove it a while back, but it needs checking if it's still needed first.
00:55:33 <hyc> moneromooo: your commit 27457a2268 removed the only usage of that var
00:55:38 <moneromooo> And when I added that at the time, I remember there was a corner case where it was needed, just can't recall the details.
00:57:28 <moneromooo> I suppose we might as well remove and fix it later if/when it subtly and rarely breaks.
00:57:32 <moneromooo> Since it'll also do that now.
00:57:54 <hyc> ah I found the PR, #6310
00:57:56 <moneromooo> But in that case there's a PR for it already.
00:59:34 <hyc> well, if there's a corner case, people should be hitting it already, no?
00:59:53 <moneromooo> Maybe they are.
01:00:32 <moneromooo> I want to say it's a race when a tx can be thought flushed but will be mined but I'm not 100% sure.
01:00:50 <hyc> hm. that last commit is from Nov 4 2019, so it would have been in the previous release?
01:00:55 <moneromooo> If it is that, then some code calling monero-wallet-rpc could think a payment wasn't made.
01:01:54 <hyc> meh. ok I'll leave it alone ;)
01:02:26 <moneromooo> Feel free to check whether it can happen since it appears I've not done it yet in all that time :S
01:02:43 <sarang> Is there a good way to adjust how that's structured to avoid something that appears unused?
01:11:32 <hyc> PR#6310 will shut up the warning, but I suppose it's better to leave it there to remind someone that eventually it ought to be really investigated
06:52:06 <tobtoht> With Dandelion++; if a node hasn't received a transaction back within a certain amount of time (i.e. black-hole attack), it will initiate a fluff phase for that transaction, correct?
06:52:11 <tobtoht> When it initiates the fluff phase will it add the transaction to its public transaction pool?
15:46:06 <woodser> with unconfirmed transactions, `get_reserve_proof` returns a valid proof when called with an account index and an amount greater than the account's balance.  checking the proof gives a total amount greater than the requested proof amount and a non-zero `spent` amount.  is this expected behavior?  I figured the proof would only succeed with an amount less than or equal to the account balance.
15:51:55 <moneromooo> Presumably not.
15:58:25 <woodser> since updating to 0.16.0.0, I get this response from daemon rpc `relay_tx`: {error={code=0, message=}, id=0, jsonrpc=2.0}
15:59:38 <woodser> it works when the daemon is switched back to 0.15.0.5
16:01:01 <moneromooo> File two bugs.
16:27:20 <sarang> Research meeting in #monero-research-lab begins at 17:00 UTC (about half an hour from now)
23:14:12 <sarang> Anything still blocking Windows CI?
23:15:05 <selsta> yes, luigi has to merge :D
23:15:54 <sarang> boo
23:15:59 <sarang> I'm holding off on some rebases for that
23:16:20 <sarang> I don't want to merge something that doesn't pass all builds
23:16:24 <selsta> luigi1111w: ^^^^ :)
23:16:41 <luigi1111w> which pr
23:16:52 <selsta> #6531 #6535 #6582
23:16:54 <sarang> selsta: you mentioned a boost-related PR as well
23:17:02 <sarang> but jtgrassie noted another issue with that
23:17:22 <sarang> gotta get that green checkmark
23:17:22 <selsta> IMO supporting newer boost is more important than old boost
23:17:38 <sarang> Sounds like newer boost breaks Ubuntu builds?
23:17:47 <selsta> not really
23:17:52 <selsta> 16.04 maybe
23:17:53 <sarang> ok
23:18:00 <sarang> Isn't that what CI uses?
23:18:20 <selsta> CI uses 18.04
23:18:28 <sarang> Ah, maybe I'm thinking of the repro builds
23:18:30 <sarang> ?
23:20:15 <selsta> no, should not break anything we use, only old distros like Ubuntu 16.04
23:20:33 <selsta> but vtnerd said he will fix it so that it works for newer and older boost versions
23:21:05 <sarang> got it
23:21:10 <selsta> for now I would prefer to merge it so that Windows CI works again
23:21:22 <sarang> seems like a good idea
23:21:32 <hyc> repro builds are also ubuntu 18.04
23:23:03 <sarang> godspeed
23:23:25 <sarang> I look forward to rebasing branches :D
23:27:32 <luigi1111w> 6582 needs a stamp
23:30:02 <selsta> sarang: can you approve it? it changes the msys2 actions to a maintained one
23:30:41 <selsta> basically the same as https://github.com/monero-project/monero-gui/pull/2921
23:30:43 <sarang> I'm unable to test it of course, but can confirm the repo change
23:33:37 <sarang> noted
23:33:48 <sarang> ^ selsta luigi1111w
23:44:47 * sarang is on pins and needles