-
sarang
Still RIP Windows CI :(
-
selsta
-
selsta
-
sarang
merge merge merge
-
hyc
UkoeHB_: as moneromooo pointed out, there's no explicit undo code needed because aborting the DB transaction automatically discards everything
-
hyc
that is the point of DB transactions, they either completely commit or they completely rollback
-
UkoeHB_
ok interesting
-
UkoeHB_
My initial though was `BlockchainLMDB::add_spent_key` is adding key images to the database for each input in each transaction in a given block, so if two transactions in a block have the same key image then the second one will trigger the `KEY_IMAGE_EXISTS` exception. Would it be more accurate to say the key images are 'tentatively' added to the database, and then later on committed/rolled back depending on if any
-
UkoeHB_
exceptions are thrown?
-
UkoeHB_
Or maybe duplicates-within-a-block are caught somewhere else.. this stuff is difficult to track down.
-
fluffypony
re-re-re-tag?
-
fluffypony
:-P
-
TheCharlatan
your trolling is gaslighting me fluffypony, are we about to re-tag? :P
-
fluffypony
I think 6582 / 6531 are needed for the windows build
-
TheCharlatan
does msys need boost 1.73, or why is that a blocker?
-
fluffypony
TheCharlatan: I'm picking up stompies based on what sarang and selsta said
-
dEBRUYNE
fluffypony: The 6531 branch equivalent is already merged
-
dEBRUYNE
6582 only affects the 'Github builds' as far as I can see :-P
-
fluffypony
got it
-
iDunk
Windows bins build fine in MSYS2.
-
TheCharlatan
so nothing in the way of release then?
-
iDunk
MSYS2 has boost 1.73 now, so master build will probably fail until 6531 is merged. release-v0.16 and v0.16.0.0 should build fine.
-
dEBRUYNE
TheCharlatan: Afaik, yes
-
dEBRUYNE
selsta should be able to confirm :-P
-
binaryFate
Mmm I was about to move with signing and publish binaries. Should I hold on for now?
-
dEBRUYNE
binaryFate: I think you can continue safely
-
binaryFate
TheCharlatan, do you want to merge the PRs?
github.com/monero-project/gitian.sigs/pulls
-
dEBRUYNE
binaryFate: Can you ping me btw once you are finished?
-
binaryFate
will do
-
TheCharlatan
sigs are merged now btw.
-
binaryFate
thanks
-
ErCiccione[m]
Do we have the release notes? I think would be better to post about the binaries when we have the changelog + contributors ready
-
ErCiccione[m]
actually, best thing would be to push the blog post and the new binaries at the same time
-
dEBRUYNE
I think a reddit post would be fine as soon as the binaries are online
-
dEBRUYNE
We can add both later via edit
-
binaryFate
binaries should be online in 1h or so
-
binaryFate
Please sanity check the hashes in this PR to website:
monero-project/monero-site #997
-
fluffypony
looks good to me binaryFate
-
fluffypony
gpg: Good signature from "binaryFate <binaryfate⊙go>" [full]
-
fluffypony
✔
-
TheCharlatan
lgtm too
-
binaryFate
thanks, can you add a comment on the PR for the posterity?
-
fluffypony
yes
-
selsta
ErCiccione[m]: I have release notes
-
selsta
will send later
-
ErCiccione[m]
Ok. Thanks
-
binaryFate
CLI binaries for Nitrogen Nebula are online :) Seems good to me already, but fluffypony will flush cache to make sure
-
binaryFate
dEBRUYNE ^
-
binaryFate
special thanks to everyone who posted their build results
-
dEBRUYNE
binaryFate: Thanks
-
hyc
UkoeHB_: yes. In a transactional DB, everything is tentative until the DB txn commits.
-
selsta
-
selsta
please check for typos and if I forgot something
-
selsta
ErCiccione[m]: ^
-
sarang
holy linebreaks batman
-
TheCharlatan
can you add the timelock verification to the ledger improvements selsta?
-
sarang
Has anyone manually tested all the links on the release notes to confirm they're correct?
-
selsta
TheCharlatan: done
-
sarang
I think the wording about checking hashes and signatures should be more direct. "You should check both that the listed hashes match the files you download, and that the signed list of hashes verifies using GPG or an equivalent tool."
-
selsta
we have used the same wording for all releases
-
sarang
But then the download server was compromised
-
selsta
I’m ok with changing it if you propose something better :P
-
sarang
"To ensure that the files you download are those originally posted by the maintainers, you should both check that the hashes of your files match those on the signed list, and that the signature on the list is valid."
-
ErCiccione[m]
thanks selsta. I'm gonna make the blog post
-
sarang
After all, some responses after the download server compromise happened were along the lines of "well, everyone should be checking hashes/signatures anyway"
-
selsta
-
sarang
Hooray!
-
sarang
Other thoughts on that language?
-
sarang
I think it's important to keep that as a strong recommendation, especially given the earlier compromise
-
ErCiccione[m]
-
ErCiccione[m]
please revie
-
ErCiccione[m]
selsta i slightly edited it. You missed a ` at the end of your code block containing the hashes
-
selsta
ErCiccione[m]: it should be in the second version I sent
-
selsta
hmm or maybe nit
-
selsta
not*
-
hyc
lgtm
-
ErCiccione[m]
No, just checked
-
ErCiccione[m]
in the blog post i added links to the list of commits, to the verification guides and the source code
-
dEBRUYNE
ErCiccione[m]: I will make a separate Reddit post OK?
-
dEBRUYNE
Then we can do another post that links directly to the blog once it is merged
-
ErCiccione[m]
Sure :)
-
dEBRUYNE
Oki, posted the thread on Reddit btw
-
binaryFate
yay
-
ErCiccione[m]
If somebody reviews the blog post we can have it up as well, if luigi and binaryfate can merge and update:
monero-project/monero-site #1000
-
dEBRUYNE
I can review in a bit
-
binaryFate
it looks good to me, and I can merge/update when you want
-
iDunk
L11 s/bulletproof/bulletproofs/, L86 s/te/the/
-
sarang
Have we been capitalizing Bulletproofs elsewhere?
-
dEBRUYNE
I normally capitalize it :-P
-
sarang
It was originally capitalized in its preprint and subsequent papers
-
sarang
but I don't know what's been done in other public-facing material
-
sarang
I'm probably super inconsistent when referring to it on IRC...
-
ErCiccione[m]
thanks iDunk fixed. I also capitalized Bulletproofs
-
ErCiccione[m]
If it's ok please approve on github
-
UkoeHB_
thanks hyc, it sounds like a robust approach (not that I know anything about these things)