01:11:32 <sarang> Still RIP Windows CI :(
01:13:15 <selsta> https://github.com/monero-project/monero/pull/6582 fixes it
01:13:34 <selsta> in combination with https://github.com/monero-project/monero/pull/6531
01:25:42 <sarang> merge merge merge
03:05:46 <hyc> UkoeHB_: as moneromooo pointed out, there's no explicit undo code needed because aborting the DB transaction automatically discards everything
03:06:12 <hyc> that is the point of DB transactions, they either completely commit or they completely rollback
03:18:26 <UkoeHB_> ok interesting
03:25:20 <UkoeHB_> My initial though was `BlockchainLMDB::add_spent_key` is adding key images to the database for each input in each transaction in a given block, so if two transactions in a block have the same key image then the second one will trigger the `KEY_IMAGE_EXISTS` exception. Would it be more accurate to say the key images are 'tentatively' added to the database, and then later on committed/rolled back depending on if any
03:25:20 <UkoeHB_> exceptions are thrown?
03:33:47 <UkoeHB_> Or maybe duplicates-within-a-block are caught somewhere else.. this stuff is difficult to track down.
09:30:37 <fluffypony> re-re-re-tag?
09:30:38 <fluffypony> :-P
10:29:14 <TheCharlatan> your trolling is gaslighting me fluffypony, are we about to re-tag? :P
10:29:48 <fluffypony> I think 6582 / 6531 are needed for the windows build
10:31:20 <TheCharlatan> does msys need boost 1.73, or why is that a blocker?
11:00:06 <fluffypony> TheCharlatan: I'm picking up stompies based on what sarang and selsta said
11:16:11 <dEBRUYNE> fluffypony: The 6531 branch equivalent is already merged
11:16:24 <dEBRUYNE> 6582 only affects the 'Github builds' as far as I can see :-P
11:17:58 <fluffypony> got it
11:20:54 <iDunk> Windows bins build fine in MSYS2.
11:22:02 <TheCharlatan> so nothing in the way of release then?
11:32:07 <iDunk> MSYS2 has boost 1.73 now, so master build will probably fail until 6531 is merged. release-v0.16 and v0.16.0.0 should build fine.
11:44:14 <dEBRUYNE> TheCharlatan: Afaik, yes
11:44:18 <dEBRUYNE> selsta should be able to confirm :-P
11:46:33 <binaryFate> Mmm I was about to move with signing and publish binaries. Should I hold on for now?
11:56:41 <dEBRUYNE> binaryFate: I think you can continue safely
11:58:24 <binaryFate> TheCharlatan, do you want to merge the PRs? https://github.com/monero-project/gitian.sigs/pulls
12:17:11 <dEBRUYNE> binaryFate: Can you ping me btw once you are finished?
12:17:20 <binaryFate> will do
12:52:11 <TheCharlatan> sigs are merged now btw.
13:08:50 <binaryFate> thanks
13:23:05 <ErCiccione[m]> Do we have the release notes? I think would be better to post about the binaries when we have the changelog + contributors ready
13:24:01 <ErCiccione[m]> actually, best thing would be to push the blog post and the new binaries at the same time
13:39:13 <dEBRUYNE> I think a reddit post would be fine as soon as the binaries are online
13:39:17 <dEBRUYNE> We can add both later via edit
13:41:50 <binaryFate> binaries should be online in 1h or so
13:47:12 <binaryFate> Please sanity check the hashes in this PR to website: https://github.com/monero-project/monero-site/pull/997
14:02:51 <fluffypony> looks good to me binaryFate
14:04:59 <fluffypony> gpg: Good signature from "binaryFate <binaryfate⊙go>" [full]
14:05:45 <fluffypony> ✔
14:06:22 <TheCharlatan> lgtm too
14:06:51 <binaryFate> thanks, can you add a comment on the PR for the posterity?
14:09:16 <fluffypony> yes
14:42:39 <selsta> ErCiccione[m]: I have release notes
14:42:46 <selsta> will send later
14:43:26 <ErCiccione[m]> Ok. Thanks
14:47:54 <binaryFate> CLI binaries for Nitrogen Nebula are online :) Seems good to me already, but fluffypony will flush cache to make sure
14:48:12 <binaryFate> dEBRUYNE ^
14:54:38 <binaryFate> special thanks to everyone who posted their build results
14:55:16 <dEBRUYNE> binaryFate: Thanks
14:57:47 <hyc> UkoeHB_: yes. In a transactional DB, everything is tentative until the DB txn commits.
14:58:58 <selsta> release notes: https://paste.debian.net/hidden/d5bd6b70/
14:59:07 <selsta> please check for typos and if I forgot something
14:59:23 <selsta> ErCiccione[m]: ^
14:59:31 <sarang> holy linebreaks batman
15:00:21 <TheCharlatan> can you add the timelock verification to the ledger improvements selsta?
15:00:48 <sarang> Has anyone manually tested all the links on the release notes to confirm they're correct?
15:01:25 <selsta> TheCharlatan: done
15:01:44 <sarang> I think the wording about checking hashes and signatures should be more direct. "You should check both that the listed hashes match the files you download, and that the signed list of hashes verifies using GPG or an equivalent tool."
15:02:19 <selsta> we have used the same wording for all releases
15:02:27 <sarang> But then the download server was compromised
15:02:30 <selsta> I’m ok with changing it if you propose something better :P
15:03:30 <sarang> "To ensure that the files you download are those originally posted by the maintainers, you should both check that the hashes of your files match those on the signed list, and that the signature on the list is valid."
15:03:43 <ErCiccione[m]> thanks selsta. I'm gonna make the blog post
15:03:57 <sarang> After all, some responses after the download server compromise happened were along the lines of "well, everyone should be checking hashes/signatures anyway"
15:06:41 <selsta> like this? https://paste.debian.net/plainh/4d73b52e
15:07:57 <sarang> Hooray!
15:08:29 <sarang> Other thoughts on that language?
15:08:42 <sarang> I think it's important to keep that as a strong recommendation, especially given the earlier compromise
16:35:27 <ErCiccione[m]> blog post done: https://github.com/monero-project/monero-site/pull/1000
16:35:30 <ErCiccione[m]> please revie
16:36:37 <ErCiccione[m]> selsta i slightly edited it. You missed a ` at the end of your code block containing the hashes
16:37:08 <selsta> ErCiccione[m]: it should be in the second version I sent
16:37:21 <selsta> hmm or maybe nit
16:37:23 <selsta> not*
16:38:04 <hyc> lgtm
16:38:09 <ErCiccione[m]> No, just checked
16:40:02 <ErCiccione[m]> in the blog post i added links to the list of commits, to the verification guides and the source code
16:48:13 <dEBRUYNE> ErCiccione[m]: I will make a separate Reddit post OK?
16:48:22 <dEBRUYNE> Then we can do another post that links directly to the blog once it is merged
16:48:58 <ErCiccione[m]> Sure :)
17:09:22 <dEBRUYNE> Oki, posted the thread on Reddit btw
17:19:32 <binaryFate> yay
17:20:46 <ErCiccione[m]> If somebody reviews the blog post we can have it up as well, if luigi and binaryfate can merge and update: https://github.com/monero-project/monero-site/pull/1000
17:20:58 <dEBRUYNE> I can review in a bit
17:21:16 <binaryFate> it looks good to me, and I can merge/update when you want
17:22:11 <iDunk> L11 s/bulletproof/bulletproofs/, L86 s/te/the/
17:22:39 <sarang> Have we been capitalizing Bulletproofs elsewhere?
17:22:50 <dEBRUYNE> I normally capitalize it :-P
17:23:00 <sarang> It was originally capitalized in its preprint and subsequent papers
17:23:11 <sarang> but I don't know what's been done in other public-facing material
17:23:22 <sarang> I'm probably super inconsistent when referring to it on IRC...
17:27:08 <ErCiccione[m]> thanks iDunk fixed. I also capitalized Bulletproofs
17:30:31 <ErCiccione[m]> If it's ok please approve on github
18:16:57 <UkoeHB_> thanks hyc, it sounds like a robust approach (not that I know anything about these things)