-
Guest99408
.merge+ 1132
-
xmr-pr
Added
-
ErCiccione[m]
.merge- 1132
-
xmr-pr
Removed
-
binaryFate
ErCiccione[m] selsta or anyone: please review
monero-project/monero-site #1133
-
selsta
looks good
-
binaryFate
thx
-
ErCiccione[m]
Oh too late. Did you check the hashes to make sure they are ok?
-
ErCiccione[m]
no wait there should be a github work for that now no?
-
binaryFate
nothing triggered
-
selsta
I did check the hashes
-
selsta
only 4 for GUI so it didn’t take long :P
-
asymptotically
ErCiccione[m]: it fails to import bF's key from the key server for some reason. need to PR it to just import from the repo instead
-
ErCiccione[m]
Oh yeah, true :P
-
ErCiccione[m]
asymptotically: alright. Thanks
-
sarang
Which key server(s) were being used?
-
sarang
Seems some of them can be very unreliable
-
sarang
Importing from repo seems safer anyway
-
ErCiccione[m]
binaryfate did you already upload the binaries on getmonero?
-
binaryFate
yes
-
binaryFate
updating as we speak
-
asymptotically
binaryFate: i missed your message a few days ago about the hashes and the redirects. are the binaries available at
downloads.getmonero.org/gui/monero-gui-win-x64-v0.16.0.3.zip at the time of the PR? before you update the redirects
-
ErCiccione[m]
-
binaryFate
asymptotically I can make sure that they are if we make it the normal sequence
-
ErCiccione[m]
it's the blog post announcing the GUI now that the binaries are being uploaded
-
dsc_
.merges
-
xmr-pr
993 1061 1070 1105 1108 1115 1119 1121 1122 1125 1126 1127 1129 1131
-
asymptotically
binaryFate: great, i'll alter the script to not follow the redirects
-
binaryFate
ok, we can try next time :)
-
selsta
ErCiccione[m]: we changed mac .tar.bz2 to .dmg, is there is place in website that has to change?
-
selsta
should be ok?
-
ErCiccione[m]
Yeah we don't mention that anywhere iirc. i'll double check
-
binaryFate
fluffypony can you flush CF?
-
fluffypony
yes
-
ErCiccione[m]
maybe better wait until the post is merged and online?
-
fluffypony
CDN as well?
-
binaryFate
I can do CDN
-
fluffypony
ok CF purged
-
selsta
I think merging hashes and blog post at the same time would be good to avoid double work
-
binaryFate
I can merge blog post given consensus on it
-
luigi1111w
no one has confirmed the hashes
-
binaryFate
yes selsta did
-
luigi1111w
selsta created the request
-
luigi1111w
if you've checked them, feel free to approve and I'll merge straight away
-
luigi1111w
otherwise I'll check in a bit
-
binaryFate
I'm confused. You mean no one has confirmed the hashes where?
-
selsta
in the blog post PR
-
luigi1111w
I'll check 'em
-
luigi1111w
done
-
binaryFate
oh yes oc
-
binaryFate
should I deploy site again then?
-
binaryFate
I have to go afk very soon
-
selsta
yes please
-
selsta
blog post should not require cf flush anyway?
-
binaryFate
no if it's a new entry I don't think so
-
selsta
fluffypony: first release with notarized dmg :D
-
binaryFate
should be good
-
ErCiccione[m]
Oh yes sorry. I reviewed selsta's pr but the hashes weren't up at the time. Forgot about it when i asked to merge.
-
fluffypony
selsta: awesome!@