-
fluffypony
I think it's mostly standard cache times
-
fluffypony
in other words, we aren't using cache hints to have it not be cached (not that cache hints are always adhered to either)
-
fluffypony
downloads stuff is gong up via LFS now, all seems to be working well
-
fluffypony
should keep the actual repo size pretty small (if you're not pulling down LFS files)
-
fluffypony
we should consider switching to LFS for the big files in the site repo (eg. movies)
-
fluffypony
-
fluffypony
all done
-
selsta
nice
-
sarang
Whitepaper reviews added to `monero-site`:
monero-project/monero-site #1111
-
sarang
CI still in progress
-
ErCiccione
sarang: i already opened #1109
-
sarang
So you did :)
-
ErCiccione
yeah did it yesterday. I think i posted it here too :P
-
sarang
I'd recommend adding to the `pubs` directory for consistency with other PDFs
-
sarang
(1111 does this)
-
sarang
ErCiccione: can't expect me to read _everything_ now!
-
ErCiccione
Lol, you are right
-
ErCiccione
sure, i didn't put them there beecause they are not "official" pubblication, but if it's fine for you it's fine for me
-
sarang
Hooray, sarang wins!
-
sarang
What would be official?
-
sarang
The "unpublished" `ge_fromfe_frombytes_vartime` document lives there already anyway
-
sarang
(not sure what "unpublished" is supposed to mean there...)
-
ErCiccione
I meant "published" pubblications. Those PDFs are just comments of pubblications. Don't know if i explained myself properly here
-
ErCiccione
nevermind. I understood your point :P
-
sarang
oh ok
-
ErCiccione
I'm probably rumbling nonsense right now
-
sarang
I see your point
-
ErCiccione
There are 38 degrees (celsius) here, i'll blame that
-
sarang
jinkies
-
sarang
I don't personally care where the PDFs live, directory-wise
-
sarang
Merge whichever makes the most sense!
-
sarang
And maybe I'll check for existing PRs before writing new ones =p
-
ErCiccione
I'm super fast
-
ErCiccione
-
ErCiccione
a review would be appreciated
-
sarang
wilco
-
sarang
Will it generate a new preview from the force-push?
-
sarang
I'll check the code, but being able to directly test links in preview would be nice
-
sarang
Silly question: any reason the `baseurl` is used for the `href` tags for the other papers, but not these?
-
ErCiccione
yep
-
ErCiccione
every force push triggers a new netlify preview
-
sarang
k
-
sarang
But yeah, the link format is different on the whitepapers apparently
-
ErCiccione
That's the absolute url i used a relative url. No difference
-
sarang
OK, no performance diffs?
-
ErCiccione
We could keep everything the same for consistency
-
sarang
Yeah, might as well use one format
-
sarang
Oh, the netlify bot just updates its original comment; neat
-
sarang
didn't see that :D
-
sarang
I'll wait until you update and then test
-
sarang
Or just use 1111 instead :D
-
ErCiccione
pushed
-
sarang
approved
-
ErCiccione
what's 1111 i missed that reference?
-
sarang
PR 1111
-
sarang
did the same thing as PR 1109
-
sarang
I just closed 1111
-
ErCiccione
O yeah. Sorry man, today i am a bit off
-
sarang
No worries!
-
sarang
Looks like 1109 does the trick
-
sarang
and preview links work fine
-
ErCiccione
Perfect
-
ErCiccione
.merge + #1109
-
sarang
.merges
-
xmr-pr
#1027 #1042 #1051 #1072 #1078 #1084 #1087 #1091 #1093 #1094 #1104 #1106 #1110 #937 #982 #993
-
ErCiccione
-.-
-
ErCiccione
alright, i'm gonna go get a drink or something
-
ErCiccione
.merge+ #1109
-
xmr-pr
Added
-
sarang
.merges
-
xmr-pr
#1027 #1042 #1051 #1072 #1078 #1084 #1087 #1091 #1093 #1094 #1104 #1106 #1109 #1110 #937 #982 #993
-
sarang
winner
-
ErCiccione
yaaay
-
sarang
Too bad the bot doesn't list in numerical order
-
sarang
Looks like it's lexicographic order
-
sarang
Who runs the bot?
-
moneromooo
dsc
-
sarang
dsc_: possible to update the bot to list merges numerically?
-
sarang
ErCiccione: are you waiting on review for other PRs right now that need to get in the queue?
-
sarang
^ thanks moneromooo
-
sarang
:D
-
moneromooo
And add PRs without using a # sign, it requires it for some reason. Or would it otherwise cause false positives ?
-
moneromooo
Failing that, I'll stop forgetting with time.
-
ErCiccione
Usually it did list them in numerical order
-
ErCiccione
sarang: checking
-
sarang
ErCiccione: was that when < 1000 ?
-
moneromooo
lol, looks like you're right, it's alpha.
-
sarang
The transition from 9xx to 1yyyy would ruin things
-
sarang
s/1yyyy/1yyy
-
ErCiccione
I think so. the bot already freaked out in past but now seems to be that.
-
sarang
I wonder if its code is public
-
ErCiccione
sarang: #1046 #1076 #1083 #1087 #1105 #1108 need a review or a final review
-
ErCiccione
I wonder if its code is public -> it's not AFAIK
-
sarang
k
-
sarang
Reviewed 1046
-
sarang
ErCiccione: is there a way to force a new preview build?
-
sarang
1076's preview has expired
-
ErCiccione
Those are the old previews made with the free accounts that now got deleted. I can force push to trigger the new barolo-time previews
-
dsc_
sarang: numerically? hmm.. Going to have to devise an algorithm... it will be hard, but I think I can do it
-
ErCiccione
Done, it's building
-
sarang
dsc_: really?
-
sarang
How is it done now?
-
sarang
Thanks ErCiccione
-
sarang
Too bad the bot doesn't update its comments after previews expire
-
dsc_
oof sarang, it's complicated. But I will persevere
-
» sarang can't tell if serious :/
-
ErCiccione
That's because they are linked to different accounts. Previews don't expire afaik
-
dsc_
hehe sorry it's /s next update will have:
-
dsc_
- numerical listing
-
dsc_
- add without #
-
moneromooo
Thanks :)
-
dsc_
.merges
-
xmr-pr
937 982 993 1027 1042 1051 1072 1078 1084 1087 1091 1093 1094 1104 1106 1109 1110
-
dsc_
.merge- 937
-
xmr-pr
Removed
-
dsc_
.merge+ 937
-
xmr-pr
Added
-
sarang
Oh, because the octothorpes look like channel links?
-
sarang
dsc_: that was fast =p
-
dsc_
Another satisfied customer!
-
ErCiccione
dsc_: will it work anyway if i use #? i will 100% forget about the change
-
dsc_
.merge+ #938
-
xmr-pr
Added
-
moneromooo
Sorry. I meant for it to be optional only :)
-
dsc_
.merge- #938
-
xmr-pr
Removed
-
moneromooo
Nice.
-
dsc_
ErCiccione: seems # still works :)
-
sarang
tested 1076
-
ErCiccione
nice. Thanks
-
dsc_
in fact;
-
ErCiccione
.merge+ #1046
-
xmr-pr
Added
-
dsc_
.merge+ blablabla111blablabla
-
xmr-pr
Added
-
dsc_
.merge- blablabla111blablabla
-
xmr-pr
Removed
-
dsc_
`re.findall(r'[\d]+', trigger.group(2))`
-
dsc_
:P
-
moneromooo
.merge+ not123
-
xmr-pr
Added
-
moneromooo
.merge
-
moneromooo
.merge?
-
moneromooo
.merges
-
xmr-pr
123 937 982 993 1027 1042 1046 1051 1072 1078 1084 1087 1091 1093 1094 1104 1106 1109 1110
-
moneromooo
.merge- not123
-
xmr-pr
Removed
-
moneromooo
.merge+ 1e3
-
xmr-pr
...
-
sarang
heh
-
dsc_
.merge+ 1e12
-
dsc_
.merges
-
xmr-pr
1 3 12 937 982 993 1027 1042 1046 1051 1072 1078 1084 1087 1091 1093 1094 1104 1106 1109 1110
-
dsc_
ha :)
-
dsc_
.merge- 1 3 12
-
xmr-pr
Removed
-
dsc_
bad mooo stop breaking my bot
-
moneromooo
One last time, sir ?
-
dsc_
okiii
-
moneromooo
.merge+ 1 3
-
xmr-pr
Added
-
moneromooo
.merge?
-
moneromooo
.merges
-
xmr-pr
1 3 937 982 993 1027 1042 1046 1051 1072 1078 1084 1087 1091 1093 1094 1104 1106 1109 1110
-
moneromooo
.merge- 1 3
-
xmr-pr
Removed
-
ErCiccione
.merge+ 1076
-
xmr-pr
Added
-
sarang
-
sarang
Please review ASAP
-
ErCiccione
on it
-
sarang
:D
-
sarang
Waiting for CI preview now
-
sarang
ErCiccione: making those changes now
-
ErCiccione
Ok. i'm reviewing the rest
-
sarang
sgp wants me to use the svg instead
-
sarang
OK to just use that in the `img` tag? I don't know about browser support
-
ErCiccione
Are you referring to the svg sgp_ is talking about or the liquid tag?
-
ErCiccione
Let me test it with that svg, but shouldn't be an issue to use that instead
-
sarang
the one he's talking about
-
sarang
I'm adding it presently
-
sarang
and the change you requested
-
sarang
will push momentarily
-
ErCiccione
browser support shouln't be a problem.
-
selsta
+1 for svg, the old image was blurry on my phone
-
sgp_
SVG is a nice to have
-
sarang
almost done with new push
-
sarang
one sec
-
ErCiccione
the svg looks good
-
sarang
also only 9 kB
-
sarang
compared to something like 100
-
sarang
force-pushed just now
-
sarang
Let me know about the logo sizing
-
sarang
waiting on CI preview
-
ErCiccione
The logo is good
-
sarang
Did the preview update with the force push?
-
sarang
there it goes
-
sarang
Looks good on my browser too
-
sarang
Lemme check mobile
-
sarang
looks good on mobile too
-
sarang
fast loading too :D
-
sgp_
so fast
-
sarang
Can someone give a thumbs-up to the updated commit?
-
ErCiccione
Forcing the width wasn't necessary, but doesn't hurt either
-
sarang
I didn't know how it would be handled otherwise with SVG scaling
-
sarang
Expanding to fill that page element seems like it'd be awkward
-
ErCiccione
The width in the svg is 412px
-
ErCiccione
it's good tho, no worries
-
sarang
ah ok
-
sarang
updated anyway =p
-
ErCiccione
:)
-
sarang
I know it'd bother me otherwise...
-
sarang
What'd be the ETA on build/deploy?
-
sarang
OSTIF's post is up
-
sarang
I happen to like my post better, but I'm obviously biased :D
-
sgp_
I like yours better too :p
-
ErCiccione
Just one minor thing sarang: could make bold "tests indicate that users will see a 20% improvement in signature verification, and at least a 10% overall improvement for typical transactions!"?
-
sarang
can do
-
ErCiccione
would be good to have some @ links to the moneropedia for words like "transactions", but that's not really important
-
sarang
I'll do the bold right now
-
sarang
Other links could be done later?
-
ErCiccione
Sure, no big deal.
-
sarang
done
-
ErCiccione
just left my approval
-
ErCiccione
sarang: About the ETA: If luigi1111 is around we can merge and fluffypony, binaryfate or pigeons could deploy
-
luigi1111w
why are there so many merges
-
luigi1111w
.merges
-
xmr-pr
937 982 993 1027 1042 1046 1051 1072 1076 1078 1084 1087 1091 1093 1094 1104 1106 1109 1110
-
luigi1111w
can you all calm down
-
ErCiccione
.merge+ #1112
-
xmr-pr
Added
-
ErCiccione
get one more!
-
fluffypony
LOL
-
fluffypony
.merge+ all the things
-
moneromooo
.merge+ all the th1ngs
-
xmr-pr
Added
-
moneromooo
Oops
-
fluffypony
LOL
-
moneromooo
.merge- 1
-
xmr-pr
Removed
-
dsc_
wut?
-
dsc_
.merge+ all the things
-
dsc_
ah ok
-
sarang
The blog post is the biggest thing, since OSTIF have already posted theirs
-
ErCiccione
yeah luigi1111 please merge 1112, the rest can wait
-
luigi1111w
done
-
sarang
Thanks! Let's get that deployed!
-
ErCiccione
fluffypony ^
-
sgp_
Who needs sports when you can watch this
-
sarang
Fluffy has pinged others for the build
-
sarang
Looks like no response yet :/
-
sarang
binaryFate pigeons
-
fluffypony
spoke to pigeons - we don't want to break binaryFate's stuff, we'll find a uniform way of doing this going forward so this doesn't happen
-
sarang
I see
-
sarang
Like a checklist :)
-
sarang
Anyone know if binaryFate will be online today?
-
ErCiccione
Probably better to PM him. Haven't seen hin online much lately.