-
xmr-pr
Daniel-Leedan opened issue #1099: Mobile design issue on 'Downloads' page
-
xmr-pr
-
xmr-pr
knaccc opened pull request #1100: Added documentation for `get_outs` input parameter `get_txid`
-
xmr-pr
-
xmr-pr
knaccc opened pull request #1101: Added documentation for `get_outs` input parameter `get_txid`
-
xmr-pr
-
Guest49387
.merge+ #1101
-
xmr-pr
Added
-
Guest49387
Could somebody review
monero-project/monero-site #1098? We should have that merged with #1097
-
Guest49387
beside being a very big improvement, will avoid creating two different sitemaps
-
Guest49387
(if merged along with #1097)
-
selsta
Guest49387: should we set web.getmonero.org as base url?
-
selsta
AFAIK this is only the CDN version
-
selsta
maybe fluffypony can clarify what to set as base url
-
fluffypony
the CDN version is getmonero.org
-
fluffypony
when there's a cache miss it forwards you to web.getmonero.org
-
selsta
ok
-
fluffypony
so getmonero.org is always canonical
-
selsta
I always get cache misses :P
-
selsta
I wonder if this is setup correctly
-
fluffypony
in some limited testing people in mainland China have issues going to dlsrc.getmonero.org but no problem with downloads.getmonero.org
-
fluffypony
selsta: site cache is relatively short-lived
-
fluffypony
so that's normal
-
selsta
ok yea I have no idea about all this
-
selsta
12:49 <@fluffypony> so getmonero.org is always canonical <-- so should we keep getmonero.org as base url?
-
fluffypony
yes
-
selsta
ok Guest49387
-
selsta
^^
-
Guest49387
Oh ok, that's a bummer. That redirect takes a huge amount of time and makes loading any page much slower. Maybe there is another way to optimize that.
-
Guest49387
Will edit my PR later today
-
fluffypony
I'll fiddle with the CDN to try and get it to redirect less often
-
selsta
it used to work fine in the past
-
selsta
but at some point I got redirected 100% of the time which is why I thought something is setup wrong
-
Guest49387
Yes, that's why i thought of using web.getmonero as baseurl. Now every internal link goes to getmonero.org and then 301's to web.getmonero.org. wasting between 600 - 1200ms for each request.
-
Guest49387
I didn't know the cdn was getmonero.org i thougth we were using it for convenience.
-
selsta
how did you measure the 600-1200ms?
-
selsta
the whole website loads in ~1 second for me (including redirect)
-
fluffypony
huh selsta nice spot
-
fluffypony
there's an issue
-
fluffypony
I'm busy fixing
-
fluffypony
the CDN moved to a new backend platform a few months back
-
fluffypony
and in converting the config over they messed up redirects
-
fluffypony
ok looks like it's a little more complex
-
fluffypony
CloudFlare's cname flattening is borking things, too
-
fluffypony
we're going to have to have www.getmonero.org as the base domain
-
fluffypony
but let me first test this and then we can see
-
selsta
ok tell me if you manage to fix it then I can test it
-
Guest49387
selsta: how did you measure the 600-1200ms? -> yeah that's for me on a shitty connection. The redirect takes about 1/3 of the loading time
-
Guest49387
just adapted #1098
-
Guest49387
fluffypony: please let me know if we are going to change the base domain, so i can make a PR right away. We should get it merged along with #1097
-
Guest49387
as intended for my initial PR (#1098)
-
fluffypony
will do
-
Guest49387
thanks
-
fluffypony
ok I've deployed iy
-
fluffypony
*it
-
fluffypony
lmk if you can access www.getmonero.org ok
-
moneromooo
I can (js off).
-
Guest49387
Yes. So i can just use www.getmonero.org in my PR as baseurl? (replacing the, now removed, web.getmonero.org) fluffypomny?
-
fluffypony
Guest49387: yes
-
Guest49387
Got it. Doing it now
-
fluffypony
and that should fix the constant redirects to origin
-
Guest49387
-
Guest49387
fluffypony: the redirect was happening anyway because the baseurl was set to getmonero.org in the config file. So there was always a redirect getmonero.org -> web.getmonero.org
-
Guest49387
that was the reason of my initial pr
-
Guest49387
unless i misunderstood something here and the change in the CDN should fix that problem too, but i'm testing it right now and that doesn't seem to be the case
-
Guest49387
well, not that problem "too", that was the problem :P
-
fluffypony
hmmmm
-
fluffypony
Jekyll can't redirect anything
-
fluffypony
unless it adds a meta tag into the HTML <head>
-
fluffypony
but then it would redirect all the time
-
moneromooo
There is a jekyll-redirect-from plugin.
-
moneromooo
(which can also redirect to).
-
fluffypony
yeah but we don't use that, afaik
-
Guest49387
I didn't mean that jekyll is redirecting
-
Guest49387
i mean that the baseurl for jekyll is getmonero.org. So every internal link was pointing to getmonero.org/whatever. Which caused every internal link to point to getmonero.org/whatever
-
Guest49387
thing is that the cdn is redirecting eveyr link getmonero.org -> web.getmonero.org. Which is a waste of time
-
Guest49387
Now we are changing the baseurl to www.getmonero.org (instead of web.getmonero.org) as in my original pr. So that redirect is not necessary anymore
-
Guest49387
-
Guest49387
^ that's an example using the "accepting" page
-
Guest49387
now we are changing the baseurl to www.getmonero.org so that redirect will be gone
-
fluffypony
ok cool got it
-
fluffypony
yeah then it should link directly to the page
-
Guest49387
Yep
-
xmr-pr
erciccione opened pull request #1102: Fix tooltip messing up the width of a page on mobile in some edge case...
-
xmr-pr
-
selsta
Guest49387: btw, are the large photos on the downloads page also shrunken down?
-
Guest49387
No. IIRC the savings were minimal and the images are fairly small
-
Guest49387
GUI is ~90KB and CLI is 49KB.
-
Guest49387
let me see how much we could save
-
selsta
ok, didn’t check their size
-
Guest49387
We could save 60% on gui.png and 20% on cli.PNG
-
Guest49387
I think it would worth it only for gui.png but at this point i can add both
-
Guest49387
selsta: please re-review i added the new pictures for the downloads page
-
selsta
done
-
Guest49387
Thanks!
-
Guest49387
.merge+ #1098
-
xmr-pr
Added