02:30:38 -xmr-pr- Daniel-Leedan opened issue #1099: Mobile design issue on 'Downloads' page
02:30:38 -xmr-pr- > https://github.com/monero-project/monero-site/issues/1099
03:45:38 -xmr-pr- knaccc opened pull request #1100: Added documentation for `get_outs` input parameter `get_txid`
03:45:38 -xmr-pr- > https://github.com/monero-project/monero-site/pull/1100
07:45:38 -xmr-pr- knaccc opened pull request #1101: Added documentation for `get_outs` input parameter `get_txid`
07:45:38 -xmr-pr- > https://github.com/monero-project/monero-site/pull/1101
07:59:40 <Guest49387> .merge+ #1101
07:59:40 <xmr-pr> Added
08:01:07 <Guest49387> Could somebody review https://github.com/monero-project/monero-site/pull/1098? We should have that merged with #1097
08:02:07 <Guest49387> beside being a very big improvement, will avoid creating two different sitemaps
08:02:19 <Guest49387> (if merged along with #1097)
10:46:55 <selsta> Guest49387: should we set web.getmonero.org as base url?
10:47:01 <selsta> AFAIK this is only the CDN version
10:48:27 <selsta> maybe fluffypony can clarify what to set as base url
10:48:42 <fluffypony> the CDN version is getmonero.org
10:48:51 <fluffypony> when there's a cache miss it forwards you to web.getmonero.org
10:48:52 <selsta> ok
10:49:02 <fluffypony> so getmonero.org is always canonical
10:49:26 <selsta> I always get cache misses :P
10:49:35 <selsta> I wonder if this is setup correctly
10:49:41 <fluffypony> in some limited testing people in mainland China have issues going to dlsrc.getmonero.org but no problem with downloads.getmonero.org
10:49:51 <fluffypony> selsta: site cache is relatively short-lived
10:49:57 <fluffypony> so that's normal
10:50:31 <selsta> ok yea I have no idea about all this
10:53:09 <selsta> 12:49 <@fluffypony> so getmonero.org is always canonical <-- so should we keep getmonero.org as base url?
10:54:20 <fluffypony> yes
10:54:59 <selsta> ok Guest49387
10:55:00 <selsta> ^^
11:31:02 <Guest49387> Oh ok, that's a bummer. That redirect takes a huge amount of time and makes loading any page much slower. Maybe there is another way to optimize that.
11:31:16 <Guest49387> Will edit my PR later today
11:41:19 <fluffypony> I'll fiddle with the CDN to try and get it to redirect less often
11:55:43 <selsta> it used to work fine in the past
11:55:59 <selsta> but at some point I got redirected 100% of the time which is why I thought something is setup wrong
12:00:34 <Guest49387> Yes, that's why i thought of using web.getmonero as baseurl. Now every internal link goes to getmonero.org and then 301's to web.getmonero.org. wasting between 600 - 1200ms for each request.
12:01:12 <Guest49387> I didn't know the cdn was getmonero.org i thougth we were using it for convenience.
12:10:57 <selsta> how did you measure the 600-1200ms?
12:11:14 <selsta> the whole website loads in ~1 second for me (including redirect)
12:25:20 <fluffypony> huh selsta nice spot
12:25:23 <fluffypony> there's an issue
12:25:26 <fluffypony> I'm busy fixing
12:28:19 <fluffypony> the CDN moved to a new backend platform a few months back
12:28:31 <fluffypony> and in converting the config over they messed up redirects
13:01:42 <fluffypony> ok looks like it's a little more complex
13:01:52 <fluffypony> CloudFlare's cname flattening is borking things, too
13:02:07 <fluffypony> we're going to have to have www.getmonero.org as the base domain
13:02:13 <fluffypony> but let me first test this and then we can see
13:28:25 <selsta> ok tell me if you manage to fix it then I can test it
13:39:07 <Guest49387> selsta: how did you measure the 600-1200ms? -> yeah that's for me on a shitty connection. The redirect takes about 1/3 of the loading time
13:42:16 <Guest49387> just adapted #1098
13:43:42 <Guest49387> fluffypony: please let me know if we are going to change the base domain, so i can make a PR right away. We should get it merged along with #1097
13:43:59 <Guest49387> as intended for my initial PR (#1098)
13:44:31 <fluffypony> will do
13:44:51 <Guest49387> thanks
13:51:04 <fluffypony> ok I've deployed iy
13:51:06 <fluffypony> *it
13:51:17 <fluffypony> lmk if you can access www.getmonero.org ok
13:52:43 <moneromooo> I can (js off).
13:53:34 <Guest49387> Yes. So i can just use www.getmonero.org in my PR as baseurl? (replacing the, now removed, web.getmonero.org) fluffypomny?
13:53:40 <fluffypony> Guest49387: yes
13:53:47 <Guest49387> Got it. Doing it now
13:53:57 <fluffypony> and that should fix the constant redirects to origin
13:59:29 <Guest49387> https://github.com/monero-project/monero-site/pull/1098
14:00:27 <Guest49387> fluffypony: the redirect was happening anyway because the baseurl was set to getmonero.org in the config file. So there was always a redirect getmonero.org -> web.getmonero.org
14:00:34 <Guest49387> that was the reason of my initial pr
14:02:15 <Guest49387> unless i misunderstood something here and the change in the CDN should fix that problem too, but i'm testing it right now and that doesn't seem to be the case
14:04:08 <Guest49387> well, not that problem "too", that was the problem :P
14:05:39 <fluffypony> hmmmm
14:05:45 <fluffypony> Jekyll can't redirect anything
14:06:00 <fluffypony> unless it adds a meta tag into the HTML <head>
14:06:06 <fluffypony> but then it would redirect all the time
14:06:15 <moneromooo> There is a jekyll-redirect-from plugin.
14:06:22 <moneromooo> (which can also redirect to).
14:06:32 <fluffypony> yeah but we don't use that, afaik
14:08:48 <Guest49387> I didn't mean that jekyll is redirecting
14:09:32 <Guest49387> i mean that the baseurl for jekyll is getmonero.org. So every internal link was pointing to getmonero.org/whatever. Which caused every internal link to point to getmonero.org/whatever
14:09:57 <Guest49387> thing is that the cdn is redirecting eveyr link getmonero.org -> web.getmonero.org. Which is a waste of time
14:10:27 <Guest49387> Now we are changing the baseurl to www.getmonero.org (instead of web.getmonero.org) as in my original pr. So that redirect is not necessary anymore
14:12:41 <Guest49387> https://imgur.com/a/IAAa3FN
14:12:53 <Guest49387> ^ that's an example using the "accepting" page
14:14:29 <Guest49387> now we are changing the baseurl to www.getmonero.org so that redirect will be gone
14:25:49 <fluffypony> ok cool got it
14:25:56 <fluffypony> yeah then it should link directly to the page
14:34:54 <Guest49387> Yep
15:45:38 -xmr-pr- erciccione opened pull request #1102: Fix tooltip messing up the width of a page on mobile in some edge case...
15:45:38 -xmr-pr- > https://github.com/monero-project/monero-site/pull/1102
15:58:41 <selsta> Guest49387: btw, are the large photos on the downloads page also shrunken down?
16:03:51 <Guest49387> No. IIRC the savings were minimal and the images are fairly small
16:04:44 <Guest49387> GUI is ~90KB and CLI is 49KB.
16:04:48 <Guest49387> let me see how much we could save
16:06:47 <selsta> ok, didn’t check their size
16:12:24 <Guest49387> We could save 60% on gui.png and 20% on cli.PNG
16:12:48 <Guest49387> I think it would worth it only for gui.png but at this point i can add both
16:19:21 <Guest49387> selsta: please re-review i added the new pictures for the downloads page
16:19:46 <selsta> done
16:20:01 <Guest49387> Thanks!
16:20:08 <Guest49387> .merge+ #1098
16:20:09 <xmr-pr> Added