02:30:38 -xmr-pr- Daniel-Leedan opened issue #1099: Mobile design issue on 'Downloads' page 02:30:38 -xmr-pr- > https://github.com/monero-project/monero-site/issues/1099 03:45:38 -xmr-pr- knaccc opened pull request #1100: Added documentation for `get_outs` input parameter `get_txid` 03:45:38 -xmr-pr- > https://github.com/monero-project/monero-site/pull/1100 07:45:38 -xmr-pr- knaccc opened pull request #1101: Added documentation for `get_outs` input parameter `get_txid` 07:45:38 -xmr-pr- > https://github.com/monero-project/monero-site/pull/1101 07:59:40 .merge+ #1101 07:59:40 Added 08:01:07 Could somebody review https://github.com/monero-project/monero-site/pull/1098? We should have that merged with #1097 08:02:07 beside being a very big improvement, will avoid creating two different sitemaps 08:02:19 (if merged along with #1097) 10:46:55 Guest49387: should we set web.getmonero.org as base url? 10:47:01 AFAIK this is only the CDN version 10:48:27 maybe fluffypony can clarify what to set as base url 10:48:42 the CDN version is getmonero.org 10:48:51 when there's a cache miss it forwards you to web.getmonero.org 10:48:52 ok 10:49:02 so getmonero.org is always canonical 10:49:26 I always get cache misses :P 10:49:35 I wonder if this is setup correctly 10:49:41 in some limited testing people in mainland China have issues going to dlsrc.getmonero.org but no problem with downloads.getmonero.org 10:49:51 selsta: site cache is relatively short-lived 10:49:57 so that's normal 10:50:31 ok yea I have no idea about all this 10:53:09 12:49 <@fluffypony> so getmonero.org is always canonical <-- so should we keep getmonero.org as base url? 10:54:20 yes 10:54:59 ok Guest49387 10:55:00 ^^ 11:31:02 Oh ok, that's a bummer. That redirect takes a huge amount of time and makes loading any page much slower. Maybe there is another way to optimize that. 11:31:16 Will edit my PR later today 11:41:19 I'll fiddle with the CDN to try and get it to redirect less often 11:55:43 it used to work fine in the past 11:55:59 but at some point I got redirected 100% of the time which is why I thought something is setup wrong 12:00:34 Yes, that's why i thought of using web.getmonero as baseurl. Now every internal link goes to getmonero.org and then 301's to web.getmonero.org. wasting between 600 - 1200ms for each request. 12:01:12 I didn't know the cdn was getmonero.org i thougth we were using it for convenience. 12:10:57 how did you measure the 600-1200ms? 12:11:14 the whole website loads in ~1 second for me (including redirect) 12:25:20 huh selsta nice spot 12:25:23 there's an issue 12:25:26 I'm busy fixing 12:28:19 the CDN moved to a new backend platform a few months back 12:28:31 and in converting the config over they messed up redirects 13:01:42 ok looks like it's a little more complex 13:01:52 CloudFlare's cname flattening is borking things, too 13:02:07 we're going to have to have www.getmonero.org as the base domain 13:02:13 but let me first test this and then we can see 13:28:25 ok tell me if you manage to fix it then I can test it 13:39:07 selsta: how did you measure the 600-1200ms? -> yeah that's for me on a shitty connection. The redirect takes about 1/3 of the loading time 13:42:16 just adapted #1098 13:43:42 fluffypony: please let me know if we are going to change the base domain, so i can make a PR right away. We should get it merged along with #1097 13:43:59 as intended for my initial PR (#1098) 13:44:31 will do 13:44:51 thanks 13:51:04 ok I've deployed iy 13:51:06 *it 13:51:17 lmk if you can access www.getmonero.org ok 13:52:43 I can (js off). 13:53:34 Yes. So i can just use www.getmonero.org in my PR as baseurl? (replacing the, now removed, web.getmonero.org) fluffypomny? 13:53:40 Guest49387: yes 13:53:47 Got it. Doing it now 13:53:57 and that should fix the constant redirects to origin 13:59:29 https://github.com/monero-project/monero-site/pull/1098 14:00:27 fluffypony: the redirect was happening anyway because the baseurl was set to getmonero.org in the config file. So there was always a redirect getmonero.org -> web.getmonero.org 14:00:34 that was the reason of my initial pr 14:02:15 unless i misunderstood something here and the change in the CDN should fix that problem too, but i'm testing it right now and that doesn't seem to be the case 14:04:08 well, not that problem "too", that was the problem :P 14:05:39 hmmmm 14:05:45 Jekyll can't redirect anything 14:06:00 unless it adds a meta tag into the HTML 14:06:06 but then it would redirect all the time 14:06:15 There is a jekyll-redirect-from plugin. 14:06:22 (which can also redirect to). 14:06:32 yeah but we don't use that, afaik 14:08:48 I didn't mean that jekyll is redirecting 14:09:32 i mean that the baseurl for jekyll is getmonero.org. So every internal link was pointing to getmonero.org/whatever. Which caused every internal link to point to getmonero.org/whatever 14:09:57 thing is that the cdn is redirecting eveyr link getmonero.org -> web.getmonero.org. Which is a waste of time 14:10:27 Now we are changing the baseurl to www.getmonero.org (instead of web.getmonero.org) as in my original pr. So that redirect is not necessary anymore 14:12:41 https://imgur.com/a/IAAa3FN 14:12:53 ^ that's an example using the "accepting" page 14:14:29 now we are changing the baseurl to www.getmonero.org so that redirect will be gone 14:25:49 ok cool got it 14:25:56 yeah then it should link directly to the page 14:34:54 Yep 15:45:38 -xmr-pr- erciccione opened pull request #1102: Fix tooltip messing up the width of a page on mobile in some edge case... 15:45:38 -xmr-pr- > https://github.com/monero-project/monero-site/pull/1102 15:58:41 Guest49387: btw, are the large photos on the downloads page also shrunken down? 16:03:51 No. IIRC the savings were minimal and the images are fairly small 16:04:44 GUI is ~90KB and CLI is 49KB. 16:04:48 let me see how much we could save 16:06:47 ok, didn’t check their size 16:12:24 We could save 60% on gui.png and 20% on cli.PNG 16:12:48 I think it would worth it only for gui.png but at this point i can add both 16:19:21 selsta: please re-review i added the new pictures for the downloads page 16:19:46 done 16:20:01 Thanks! 16:20:08 .merge+ #1098 16:20:09 Added