-
xmr-pr
selsta opened pull request #1266: user-guides: update fingerprint
-
xmr-pr
-
Guest22839
selsta: don't we have to move from gitlab -> github anyway? Dunno
-
Guest22839
netrik182: that's my fear too. I think that if we aim to have many questions, maby would be better to have a TOC and then all the questions already open (without needing to click on them)
-
Guest22839
.merge+ #1266
-
xmr-pr
Added
-
-
ErCiccione[m]
I'm going for this structure instead ^
-
ErCiccione[m]
consider the 2 blocks on the top will be smaller and not everything is styled yet
-
netrik182[m]
Looks good. Then it'll be possible to have placeholders pointed to the answers
-
netrik182[m]
And use them outside getmonero as well
-
sarang
Is the site down?
-
moneromooo
Looks down to me.
-
selsta
I pinged fluffy
-
selsta
Datacenter has power outage
-
sarang
oof
-
ErCiccione[m]
Nice
-
ErCiccione[m]
netrik182: They are not in the screenshot but i already created anchors for that very reason
-
ErCiccione[m]
So we can point people to a specific question
-
selsta
-
sarang
This would handle what, site builds after pushing commits?
-
selsta
also when opening PRs
-
selsta
we could also deploy every PR/build to a testing area so that it easier to review things but I see problem with it getting abused
-
sarang
At least for me, getting build tests on pushes would be more useful, since I don't have a local site build setup
-
selsta
what do you consider a build test?
-
selsta
it tests if the website builds fine but you can’t open the website
-
sarang
Right, that's what I meant
-
sarang
But that's helpful for me, at least, for the few types of PRs that I make for things like updating the list of papers
-
selsta
right, this is possible but we have to make sure it doesn’t get abused
-
sarang
It'd be the same risks as the main project has, no?
-
selsta
what risks does the main project have?
-
sarang
I presume whatever limits GitHub places on CI actions
-
sarang
Isn't that what you meant?
-
sarang
Right now, every push I make for project branches have several CI actions for build and test
-
selsta
yes
-
selsta
I see risk in people linking to malware and then trying to link the website around
-
sarang
Is this a risk with just testing that the site builds?
-
selsta
no
-
sarang
Oh, you mean the risk only exists with some kind of test deployment
-
sarang
got it
-
selsta
yep
-
sarang
Yeah, that seems reasonable
-
sarang
and TBH for me at least, just knowing that I didn't screw up something obvious that breaks the build is good to know
-
selsta
it is better than nothing, yes
-
sarang
and it doesn't require that PRs have people test the build specifically
-
sarang
thereby removing some work
-
selsta
we could make a bot that deploys the site on a comment
-
selsta
so that people can check the changes first
-
selsta
just an idea
-
sarang
How would that work? Not sure I follow
-
selsta
a maintainer / trusted person writes !deploy and the bot would reply with a link were the website is deployed
-
selsta
so that it can get testsed
-
selsta
without having to build it manually
-
sarang
and then it dies on some timer?
-
selsta
but writing such a bot sounds like a lot of work with rather little benefit :)
-
selsta
yes the website would get deleted after 1 month or so
-
sarang
Isn't there some quote about how many programmers prefer writing tools than writing other projects? =p