.merge- 3220

Removed

.merge+ 3221

Added

Hey, stopping by to report that v0.17.1.3 does not start on Tails, likely related to old.reddit.com/r/Monero/comments/jqmi8t/_/gbo8p2e

ty, yea we will revert qt update change

Should I perhaps remove the Linux 64-bit version from the thread?

add a warning

it does work on some systems

I would prefer fixing Ubuntu 18.04 issue instead of reverting the changes

Will have to fix it fast though

Can't have a 'broken' release out for too long

xiphon: we can also fix it, I just wasn’t able to

1.12 and 1.13 segfault on 20.04

and 1.14 has a deadlock on 18.04

did not really find out the reason, diff between 1.13 and 1.14 also did not show anything interesting

Alright, might take some time to fix it

Let's revert it for now if we want to release ASAP

IMO best to revert for now and then test without having to hurry

then we can include it in next release again

Yep, let's revert and i will work on a fix

btw, there are two commits in the monero-project/monero-gui #3221 PR

yep looking into it

+1 selsta

xiphon: updated

.merges

luigi1111: Snipa: fluffypony: we need 2 merges and a new GUI tag, anyone online in the next hours?

yes

cool, will ping you soon^tm

ty luigi1111!

luigi1111: ok you could tag now whenever you have time

merges and then tag

do we not need to update get_libwallet

nope

gui only release to fix some linux issue

luigi1111w: v0.17.1.4

it's still on 1.1

I guess that's ok

hmm wait

you sure?

ah I know what you mean

you mean this?

luigi1111w: ok merge ^ please and then tag, 3x confirmed

should be the last release for a while now lol

no the build script is what I meant

we removed libwallet script

use submodules now

oh, I see the issue

ok

done

w0w

ty

it's me again, here to report another bizzare build system problem from the Nix world

this time the g++ invocation is failing because the include path is so big the command line is being truncated

rnhmjoj: which version?

i've bisected the monero-gui repo and the first bad commit is 153154f484ab1c3e6196dc02d62f2094fff40e97

it looks like this line `set(CMAKE_PREFIX_PATH $ENV{CMAKE_PREFIX_PATH})` is duplicating every entry in the path

just FYI this has been reverted in v0.17.1.4

but we will include it in the next release again

about that, is v0.17.1.3 a kind pre-release? usually, a few days before you mark a tag "latest release", these pop up in the repology feed as official updates but i don't think they are

it was a official release but there was a bug on linux so we had to do another release

we mark them on github after a couple of days

ah, ok. thank you

the problem is still on master. I can only build monero by removing that line i mentioned

we use Ubuntu 16.04 for builds

rnhmjoj: do you use and OS even older than Ubuntu 16.04?

s/and/an/

xiphon: no, why?

just wondering what OS fails to build the GUI given that Ubuntu 16.04 build works well

i don't think this has anything to do with a particular OS: is just that some recent change in the build system cause the entries of CMAKE_PREFIX_PATH to be duplicate

What entries?

There should be just one path typically

i'll show you the build log, just a sec

What OS do you use?

the OS is not relevant, the fact that i'm building it with Nix is

Your build system misconfigures CMAKE_PREFIX_PATH

WE don't set it in the build process

Is an external variable (cmake arg or env variable) that is set by a user

"the OS is not relevant, the fact that i'm building it with Nix is"

Just a broken env

Either it is an OS or build system, dunno

You have to investigate this

The line you are referring to `set(CMAKE_PREFIX_PATH $ENV{CMAKE_PREFIX_PATH})`

just gets the evnvironment variable value

and sets cmake variable value

what do you say it's broken? i think it's the only way for Nix to tell cmake where to look for packages

s/what/why

Cause it is duplicating every entry in the path

Like you said

Btw, i see another bug anyway. Though it is not related to the particaular line (`set(CMAKE_PREFIX_PATH $ENV{CMAKE_PREFIX_PATH})`)

rnhmjoj: Would be nice if you provide the steps to reproduce the problem and open Github issue

i'm collecting more information and see if i can create a minimal way to reproduce it that doesn't require having nix

working on it

there is an issue handling more than one entry in CMAKE_PREFIX_PATH

will have a patch in a few, would be nice if you test it

i figured a couple things out: the environment variable is necessary, without it cmake fill find no package at all. it contains duplicates from the start but that's not the real issue

the problem may be here: include_directories(${CMAKE_PREFIX_PATH}/include)

right, that's what i said

i think cmake already set the include directories by itself, based on the environment

btw, yes, just link me a patch i'll try it right away

rnhmjoj: xiphon/monero-gui d967ade

xiphon: works for me!

great, thanks for reporting

thank you, will this be in the next release?

yep

great, for the moment i'll link this patch to the package

sounds good