08:27:35 <selsta> .merge- 3220
08:27:35 <xmr-pr> Removed
08:46:08 -xmr-pr- selsta opened pull request #3221: Revert Qt 5.15 changes temporarily
08:46:08 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/3221
10:16:08 -xmr-pr- mb291 opened issue #3222: GUI v0.17.1.3 'Oxygen Orion' dosen' t show up on Debian Buster
10:16:08 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/3222
11:08:27 <selsta> .merge+ 3221
11:08:27 <xmr-pr> Added
13:39:16 <tobtoht> Hey, stopping by to report that v0.17.1.3 does not start on Tails, likely related to https://old.reddit.com/r/Monero/comments/jqmi8t/_/gbo8p2e/
13:41:41 <selsta> ty, yea we will revert qt update change
13:56:31 <dEBRUYNE> Should I perhaps remove the Linux 64-bit version from the thread?
14:02:29 <selsta> add a warning
14:02:35 <selsta> it does work on some systems
14:20:08 <xiphon> I would prefer fixing Ubuntu 18.04 issue instead of reverting the changes
14:22:24 <dEBRUYNE> Will have to fix it fast though
14:22:29 <dEBRUYNE> Can't have a 'broken' release out for too long
14:26:40 <selsta> xiphon: we can also fix it, I just wasn’t able to
14:26:54 <selsta> 1.12 and 1.13 segfault on 20.04
14:27:00 <selsta> and 1.14 has a deadlock on 18.04
14:27:24 <selsta> did not really find out the reason, diff between 1.13 and 1.14 also did not show anything interesting
14:31:32 <xiphon> Alright, might take some time to fix it
14:31:52 <xiphon> Let's revert it for now if we want to release ASAP
14:32:22 <selsta> IMO best to revert for now and then test without having to hurry
14:32:28 <selsta> then we can include it in next release again
14:32:55 <xiphon> Yep, let's revert and i will work on a fix
14:33:13 <xiphon> btw, there are two commits in the https://github.com/monero-project/monero-gui/pull/3221 PR
14:33:45 <selsta> yep looking into it
14:34:15 <dEBRUYNE> +1 selsta
14:38:03 <selsta> xiphon: updated
14:41:09 <selsta> .merges
14:41:10 -xmr-pr- 3217 3221
15:08:54 <selsta> luigi1111: Snipa: fluffypony: we need 2 merges and a new GUI tag, anyone online in the next hours?
16:12:43 <luigi1111> yes 
16:22:15 <selsta> cool, will ping you soon^tm
16:23:04 <dEBRUYNE> ty luigi1111!
16:49:11 <selsta> luigi1111: ok you could tag now whenever you have time
16:49:16 <selsta> merges and then tag
17:36:16 <luigi1111w> do we not need to update get_libwallet
17:36:24 <selsta> nope
17:36:47 <selsta> gui only release to fix some linux issue
17:38:58 <selsta> luigi1111w: v0.17.1.4
17:39:33 <luigi1111w> it's still on 1.1
17:39:36 <luigi1111w> I guess that's ok
17:40:07 <selsta> hmm wait
17:40:22 <selsta> you sure?
17:40:48 <selsta> ah I know what you mean
17:41:56 <selsta> https://github.com/monero-project/monero-gui/pull/3223
17:41:58 <selsta> you mean this?
17:46:08 -xmr-pr- selsta opened pull request #3223: build: prepare v0.17.1.4
17:46:08 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/3223
17:47:19 <selsta> luigi1111w: ok merge ^ please and then tag, 3x confirmed
17:47:34 <selsta> should be the last release for a while now lol
17:50:30 <luigi1111w> no the build script is what I meant
17:50:46 <luigi1111w> https://github.com/monero-project/monero-gui/blob/v0.17.1.1/get_libwallet_api.sh#L20
17:51:04 <selsta> we removed libwallet script
17:51:08 <selsta> use submodules now
17:51:53 <luigi1111w> oh, I see the issue
17:51:53 <luigi1111w> ok
17:53:22 <luigi1111w> done
17:53:39 <selsta> w0w
17:53:41 <selsta> ty
19:46:06 <rnhmjoj> it's me again, here to report another bizzare build system problem from the Nix world
19:46:13 <rnhmjoj> this time the g++ invocation is failing because the include path is so big the command line is being truncated
19:46:40 <selsta> rnhmjoj: which version?
19:46:46 <rnhmjoj> i've bisected the monero-gui repo and the first bad commit is 153154f484ab1c3e6196dc02d62f2094fff40e97
19:47:30 <rnhmjoj> it looks like this line `set(CMAKE_PREFIX_PATH $ENV{CMAKE_PREFIX_PATH})` is duplicating every entry in the path
19:48:05 <selsta> just FYI this has been reverted in v0.17.1.4
19:48:12 <selsta> but we will include it in the next release again
19:54:46 <rnhmjoj> about that, is v0.17.1.3 a kind pre-release? usually, a few days before you mark a tag "latest release", these pop up in the repology feed as official updates but i don't think they are
19:56:11 <selsta> it was a official release but there was a bug on linux so we had to do another release
19:56:22 <selsta> we mark them on github after a couple of days
20:00:16 <rnhmjoj> ah, ok. thank you
20:11:59 <rnhmjoj> the problem is still on master. I can only build monero by removing that line i mentioned
21:08:25 <xiphon> we use Ubuntu 16.04 for builds
21:09:16 <xiphon> rnhmjoj: do you use and OS even older than Ubuntu 16.04?
21:09:39 <xiphon> s/and/an/
21:10:20 <rnhmjoj> xiphon: no, why?
21:13:15 <xiphon> just wondering what OS fails to build the GUI given that Ubuntu 16.04 build works well
21:14:57 <rnhmjoj> i don't think this has anything to do with a particular OS: is just that some recent change in the build system cause the entries of CMAKE_PREFIX_PATH to be duplicate
21:15:32 <xiphon> What entries?
21:15:41 <xiphon> There should be just one path typically
21:16:05 <rnhmjoj> i'll show you the build log, just a sec
21:16:47 <xiphon> What OS do you use?
21:17:21 <rnhmjoj> https://hastebin.com/raw/gekobocesa
21:17:47 <rnhmjoj> the OS is not relevant, the fact that i'm building it with Nix is
21:18:12 <xiphon> Your build system misconfigures CMAKE_PREFIX_PATH
21:18:25 <xiphon> WE don't set it in the build process
21:18:40 <xiphon> Is an external variable (cmake arg or env variable) that is set by a user
21:19:22 <xiphon> "the OS is not relevant, the fact that i'm building it with Nix is"
21:19:44 <xiphon> Just a broken env
21:20:00 <xiphon> Either it is an OS or build system, dunno
21:20:00 <xiphon> You have to investigate this
21:20:49 <xiphon> The line you are referring to `set(CMAKE_PREFIX_PATH $ENV{CMAKE_PREFIX_PATH})`
21:21:00 <xiphon> just gets the evnvironment variable value
21:21:17 <xiphon> and sets cmake variable value
21:21:36 <rnhmjoj> what do you say it's broken? i think it's the only way for Nix to tell cmake where to look for packages
21:21:48 <rnhmjoj> s/what/why
21:22:59 <xiphon> Cause it is duplicating every entry in the path
21:23:14 <xiphon> Like you said
21:26:12 <xiphon> Btw, i see another bug anyway. Though it is not related to the particaular line (`set(CMAKE_PREFIX_PATH $ENV{CMAKE_PREFIX_PATH})`)
21:26:52 <xiphon> rnhmjoj: Would be nice if you provide the steps to reproduce the problem and open Github issue
21:30:26 <rnhmjoj> i'm collecting more information and see if i can create a minimal way to reproduce it that doesn't require having nix
21:37:51 <xiphon> working on it
21:38:03 <xiphon> there is an issue handling more than one entry in CMAKE_PREFIX_PATH
21:39:07 <xiphon> will have a patch in a few, would be nice if you test it
21:41:37 <rnhmjoj> i figured a couple things out: the environment variable is necessary, without it cmake fill find no package at all. it contains duplicates from the start but that's not the real issue
21:42:15 <rnhmjoj> the problem may be here: include_directories(${CMAKE_PREFIX_PATH}/include)
21:42:44 <xiphon> right, that's what i said
21:42:46 <rnhmjoj> i think cmake already set the include directories by itself, based on the environment
21:44:04 <rnhmjoj> btw, yes, just link me a patch i'll try it right away
22:28:04 <xiphon> rnhmjoj: https://github.com/xiphon/monero-gui/commit/d967ade37ddee98a5c62277f2039ce86df9e46c6
22:30:35 <rnhmjoj> xiphon: works for me!
22:30:44 <xiphon> great, thanks for reporting
22:33:03 <rnhmjoj> thank you, will this be in the next release?
22:34:10 <xiphon> yep
22:35:35 <rnhmjoj> great, for the moment i'll link this patch to the package
22:42:56 <xiphon> sounds good