luigi1111w: for release notes: paste.debian.net/hidden/6d336e0b

can you also do this detach sign thing here? github.com/monero-project/monero-si…lob/master/downloads/hashes.txt.sig

plz check

luigi1111w: "successfully verified"

whee

i'm trying to build monero-gui with the new build system but i'm getting an error one building one of the external deps.

do you have any clue? hastebin.com/raw/juxujuzaxo

never seen that, did you change anything?

or anything else special?

do you mean patching the source code? that should be unchanged

did you just do `make release` ?

try: rm -rf build monero

then git submodule update --init --force --recursive

and then make release

the submodule should be pointing to the corresponding monero release, right?

you don’t have to manually change the submodule

the tag has the correct submodule, just do submodule update --init --force --recursive

should be pointing to v0.17.0.1, yes

also which gcc version are you using?

this is part of the monero package in nixpkgs: the package is copying the source from monero instead of using git to avoid cloning twice the repository

i'll try using --recursive instead to see if that's the problem

gcc is 9.3.0

9.3.0 does not look super new so should be okay

now that i think about it, the error probably means DEF_MONERO_VERSION_SRELEASE is a macro that hasn't been defined, so the compiler is seeing: blabla = ;

I would try with --recursive

also note that the cmake build needs git, though I think qmake was the same

the build.sh script only used git to get the monero version, i used to write the version.js manually

nada, maybe git is needed to define that variable, let's try

rnhmjoj: it should be working without Git

for some reason it doesn't set VERSION_IS_RELEASE variable to hardcoded fallback value

could you paste /build/source/build/version.cpp contents?

yeah, i figured that too

just a sec

ah, well, i see the problem

it detects that Git is installed on the machine

based on that it assumes you are building monero from git repository

please apply the patch to monero/cmake/Version.cmake paste.debian.net/plain/1166108

i'm interested in the few last lines it will print

yeah, the #define is empty

ok, i'm trying it

^ with the patch the build terminate early

Do you see "Found Git: ..." string in the cmake output?

Or "WARNING: Git was not found" ?

uhm, the patch is not applying

but the warning (?) is git not found, i noticed it earlier

Can't find the problem following the code

Please provide steps to reproduce the issue

i edited the file manually, VERSION_IS_RELEASE is empty

so, here's what i found: VERSION_IS_RELEASE is not defined, cmake does not find git, sets VERSIONTAG=unknown, calls configure_file on version.cpp which fills in DEF_MONERO_VERSION_TAG but leaves DEF_MONERO_VERSION_IS_RELEASE undefined

IS_RELEASE seems to be defined in GenVersion.cmake, but this code is never executed when git is not found

nope

VERSION_IS_RELEASE is begin set to "false" if Git is not found

s/is begin/is being

Are you sure you ain't using some really outdated monero sources?

so selsta's advice would just work "the tag has the correct submodule, just do submodule update --init --force --recursive"

but that's in the monero source tree, the problem seems to be coming from monero-gui/cmake/version.cmake

i already tried using the git to fetch the submodule but it makes no difference

ah, that's why the patch didn't apply

i managed to build with this patch: hastebin.com/ayahogapor.lua