00:15:23 <selsta> luigi1111w: for release notes: https://paste.debian.net/hidden/6d336e0b/
00:17:10 <selsta> can you also do this detach sign thing here? https://github.com/monero-project/monero-site/blob/master/downloads/hashes.txt.sig
01:36:09 <luigi1111w> plz check
01:47:18 <selsta> luigi1111w: "successfully verified"
01:47:31 <luigi1111w> whee
10:06:10 <rnhmjoj> i'm trying to build monero-gui with the new build system but i'm getting an error one building one of the external deps.
10:06:16 <rnhmjoj> do you have any clue? https://hastebin.com/raw/juxujuzaxo
10:07:05 <selsta> never seen that, did you change anything?
10:07:09 <selsta> or anything else special?
10:08:02 <rnhmjoj> do you mean patching the source code? that should be unchanged
10:10:28 <selsta> did you just do `make release` ?
10:10:49 <selsta> try: rm -rf build monero
10:10:56 <selsta> then git submodule update --init --force --recursive
10:10:59 <selsta> and then make release
10:11:42 <rnhmjoj> the submodule should be pointing to the corresponding monero release, right?
10:12:27 <selsta> you don’t have to manually change the submodule
10:12:40 <selsta> the tag has the correct submodule, just do submodule update --init --force --recursive
10:12:57 <selsta> should be pointing to v0.17.0.1, yes
10:13:05 <selsta> also which gcc version are you using?
10:15:07 <rnhmjoj> this is part of the monero package in nixpkgs: the package is copying the source from monero instead of using git to avoid cloning twice the repository
10:15:29 <rnhmjoj> i'll try using --recursive instead to see if that's the problem
10:15:34 <rnhmjoj> gcc is 9.3.0
10:20:38 <selsta> 9.3.0 does not look super new so should be okay
10:25:21 <rnhmjoj> now that i think about it, the error probably means DEF_MONERO_VERSION_SRELEASE is a macro that hasn't been defined, so the compiler is seeing: blabla =  ;
10:34:45 <selsta> I would try with --recursive
10:37:56 <selsta> also note that the cmake build needs git, though I think qmake was the same
10:40:36 <rnhmjoj> the build.sh script only used git to get the monero version, i used to write the version.js manually
10:51:16 <rnhmjoj> nada, maybe git is needed to define that variable, let's try
13:23:37 <xiphon> rnhmjoj: it should be working without Git
13:24:32 <xiphon> for some reason it doesn't set VERSION_IS_RELEASE variable to hardcoded fallback value
13:25:05 <xiphon> could you paste /build/source/build/version.cpp contents?
13:25:35 <rnhmjoj> yeah, i figured that too
13:25:37 <rnhmjoj> just a sec
13:25:42 <xiphon> ah, well, i see the problem
13:25:55 <xiphon> it detects that Git is installed on the machine
13:26:18 <xiphon> based on that it assumes you are building monero from git repository
13:28:56 <xiphon> please apply the patch to monero/cmake/Version.cmake https://paste.debian.net/plain/1166108
13:30:13 <xiphon> i'm interested in the few last lines it will print
13:30:38 <rnhmjoj> yeah, the #define is empty
13:30:38 <rnhmjoj> https://hastebin.com/avawuxaxig.cpp
13:31:02 <rnhmjoj> ok, i'm trying it
13:31:15 <xiphon> ^ with the patch the build terminate early
13:32:11 <xiphon> Do you see "Found Git: ..." string in the cmake output?
13:32:30 <xiphon> Or "WARNING: Git was not found" ?
13:37:08 <rnhmjoj> uhm, the patch is not applying
13:37:42 <rnhmjoj> but the warning (?) is git not found, i noticed it earlier
13:44:03 <xiphon> Can't find the problem following the code
13:44:17 <xiphon> Please provide steps to reproduce the issue
13:50:54 <rnhmjoj> i edited the file manually, VERSION_IS_RELEASE is empty
14:42:23 <rnhmjoj> so, here's what i found: VERSION_IS_RELEASE is not defined, cmake does not find git, sets VERSIONTAG=unknown, calls configure_file on version.cpp which fills in DEF_MONERO_VERSION_TAG but leaves DEF_MONERO_VERSION_IS_RELEASE undefined
14:43:28 <rnhmjoj> IS_RELEASE seems to be defined in GenVersion.cmake, but this code is never executed when git is not found
15:08:03 <xiphon> nope
15:08:24 <xiphon> VERSION_IS_RELEASE is begin set to "false" if Git is not found
15:08:30 <xiphon> https://github.com/monero-project/monero/blob/master/cmake/Version.cmake#L46
15:09:22 <xiphon> s/is begin/is being
15:10:04 <xiphon> Are you sure you ain't using some really outdated monero sources?
15:10:36 <xiphon> so selsta's advice would just work "the tag has the correct submodule, just do submodule update --init --force --recursive"
15:15:17 <rnhmjoj> but that's in the monero source tree, the problem seems to be coming from monero-gui/cmake/version.cmake
15:16:58 <rnhmjoj> i already tried using the git to fetch the submodule but it makes no difference
15:19:07 <rnhmjoj> ah, that's why the patch didn't apply
17:31:08 -xmr-pr- xiphon opened pull request #3131: cmake: remove unused code
17:31:08 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/3131
18:36:46 <rnhmjoj> i managed to build with this patch: https://hastebin.com/ayahogapor.lua
21:16:08 -xmr-pr- viperperidot opened issue #3132: Bug report: Application icon does not display properly on Ubuntu
21:16:08 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/3132
23:01:08 -xmr-pr- rating89us opened pull request #3133: LeftPanel: add hide balance icon in card
23:01:08 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/3133
23:16:08 -xmr-pr- rating89us opened issue #3134: History: transaction history page is not refreshed during wallet sync
23:16:09 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/3134