In the past I remember mooo suggesting for GUI to adopt `src/wallet/api/*`

It's a shame we can't, due to possible software we don't know about that are using wallet/api

cake wallet uses it, monerujo, others too I think

Most likely, yes.

wooders libs

Suppose wooder goes straight into wallet2, but I have not checked.

Perhaps we should deprecate it.

over on Monero

but is it better if every project has their own version?

and clients responsible for integrating it

and make*

we need an alternative first before deprecating it

Or move it to a separate repo. Thing is, it can't be tested without the GUI (or other software that uses it).

> Modify CMakeLists.txt: option(BUILD_GUI_DEPS "Build GUI dependencies." ON)

Then again, my primary annoyance with it was that it added a lot of time to every build changing wallet2.h for stuff I did not care about :P

seems like libwalelt

Now that it doesn't build by default, it's kinda out of sight out of mind, so I don't mind now.

But it means it breaks from time to time.

My biggest annoyonce with wallet/api is that it's not a very good API.

it runs in CI for every build

so it did not break in a while

That's good.

receive_money(uint46_t amount_you_want)

Ill rephrase, since it might be offensive to the person that initially wrote it ... It's a good initial API that made it possible for Monero GUI, and other programs to be made. But now that we're doing some exotic stuff in my project, we've run into missing functionality, questionable architecture in some cases .. and some bugs.

We'll upstream stuff, but at the same time we can't break backward compat.

Hence I was thinking about deprecation.

(or a seperate repo)

selsta: The fact woodser uses `BUILD_GUI_DEPS` doesn't mean he's using wallet/api

I'd have to check, or ask woodser.

libwallet is basically "wallet2 + other monero core stuff in a lib"

possible

Here's a diagram we've made btw i.imgur.com/hGSlKAL.png

It's wallet2 -> api/wallet -> libwalletqt -> libwalletqt -> feather

this api/wallet step is awkward / limiting

can feather use wallet2 directly?

or can libwalletqt use wallet2 directly

Yes.

Honestly I don't know why that api/wallet step is in there.

It fixes stuff that ought to be fixed by clients

And it limits *what* you can use from wallet2, I suppose.

IIRC it was to offer some API that was not going to break.

You can work around that by changing wallet/api .. but then you have a patch, which you need to upstream .. and not break backward compat.

(I might be wrong, that's my dim recollection)

interesting mooo

Maybe we should code against wallet2 ....

Ill keep upstreaming patches, as per my promise to add functionality that the GUI can also make use of.

contact editing looks useful :D

did not look at the other yet

Coins (txo manipulation) will be next

w0w

It touches wallet2 too, introduced a mutex somewhere to prevent race condition / segfault with other part of the wallet2 code

Just have to look mooo with puppy eyes and it will surely go in ^^

Ship it.

See.

👀