.merges

.merge+ #2991

Added

.merge+ #2997 #2996 #2988 #2978 #2976 #2949

.merges

.merge+ #2935 #2915

Added

does `ratingus85` ever come here?

he seems to redesign everything, might be nice to discuss it beforehand first

¯\_(ツ)_/¯

89

Would that be close enough ?

Maybe it was that person's age when they registered in 2016 ^_^

Missed my window >:|

.merge+ #2994

Added

luigi1111w: can haz?

yes

what was the question

merge-wave when possible :)

but they've piled up and look big now

should have used the opportunity of you saying Yes to a future unspecified question by asking for core team membership ;x

Maybe do half?

.... a quarter? :D

luigi1111w: thank you sir

hey I did a quarter nice

o/

dsc_: Do you disagree with some of the redesigns?

dEBRUYNE: He's doing rather great work honestly

just some small tweaks and/or suggestions that could be discussed over IRC, especially before coding them could help

Previously i've discussed features/redesign with other people first before coding large PRs

dEBRUYNE: what do you think of this one: monero-project/monero-gui #2936 ?

fwiw the sending screen redesign is from knueffelbund designs

but yep 2936 can be discussied, it encourages using a fresh address everytime which is good for privacy but might be a bit more complicated to use

Haven't looked at that one in detail yet to be honest

<dsc_> dEBRUYNE: He's doing rather great work honestly <= Ok great!

slstsrv: I'm running that PR and it's pretty great, I ought to review it properly

The "always new address" works well, I'd even argue the UX proposed here is less complicated

It marks the address as "used" as soon as you copy it to the clipboard

just wondering if it automatically increments the lookahead

in addition, lookaheads are stored inside wallet cache, so a mnemonic seed restore on another pc would require you to also correctly specify that, else you might end up reusing old subaddys?

do you know the default lookahead?

Either 200/50 or 50/200.

200 or 500 from the top of my head

afaik it is less when using ledger / trezor which could be a problem

Ledger is somehting like 10 I believe.

right, using 10 addresses without receiving can quickly happen if it always generates a new one

So if the GUI is generous in giving out addresses, restoring might become a hurdle

(if we don't have the proper UX to signal that lookaheads are important)

Suppose the GUI could loop to find out which subaddresses have been used previously (incoming txs) till it finds a clean one

right but we don't want to do that else we might give out the same subaddress to multiple people

true...

I guess this is a showstopper for this PR then? Anyone got a good idea? :D

New seed format: include restore height and lookahead :)

lol

I don't hear any No's :)

Also another thing I'm wondering; if the GUI hands out addresses like there is no tomorow ... what is the wallet scanning performance like after years of usage?

Or is this a moot point because It's very easy to just replace your wallet for a new one when it gets slow?

questions .. questions

should be negligible

also it only generates a new subaddress if you copy the address on the receive screen which should not happen that often

but the lookahead on ledger / trezor is a valid concern

21:48 <selsta> should be negligible <-- subaddresses are designed in a way to not affect scanning performance, only initially creating the lookup table (using lookahead) is resource intensive

ah okay

.merge+ #2989

Added

.merge+ #2935

.merge+ #2998

Added

.merges

xiphon: do you have idea about my issue with #2991 when using non brew Qt or should we merge this for now?

an*

selsta: i need an environment to reproduce the issue and fix it

ok, will see how to do this

how do you install qt? Downloading .dmg and running some installation script?

using normal Qt installer

Could this be done from a terminal?

Qt online installer

will see

else we can purchase a Mac VM for a month

"should we merge this for now?" -> yes, the PR implements CMake reelase build on MacOS with qt installed through package manager

sounds good, the issue I have is not related to that PR anyway

though it failed to build now with some lrelease related issue

<selsta "else we can purchase a Mac VM fo"> there is a mac vm snap you can use called sosumi or something like that

"though it failed to build now with some lrelease related issue" -> due to merged CMake translations PR, wokring on it

kinghat[m]: thanks, though not sure if xiphon wants to bother installing this on his system, a VM would be easier

running a Mac VM on Linux / Windows is quite hacky

ya its all hacky.

a Mac VPS would be easier*

that looks like an easy way to go about it though

mac vps isnt free i dont think

unless ppl are handing them out to oss projects

yea I know but I’m sure we could get one funded for a month :P

fuck apple

pardon my english

they sure make it difficult for open source projects

they dont have a problem using oss

i heard that they didnt like the gpl3 of samba so they rolled their own or something

.merges