00:46:08 -xmr-pr- xiphon opened pull request #2991: cmake: implement MacOS 'release' build + CI support 00:46:09 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2991 10:52:47 .merges 10:52:48 -xmr-pr- #2940 #2948 #2949 #2974 #2976 #2977 #2978 10:52:55 .merge+ #2991 10:52:55 Added 11:16:09 -xmr-pr- rating89us opened issue #2993: History: amounts like 0.000000000001 don't display correctly 11:16:09 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/2993 11:16:09 -xmr-pr- rating89us opened pull request #2992: history: add receiving address label + fix search and amount display 11:16:09 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2992 12:16:09 -xmr-pr- glv2 opened pull request #2994: Mining: Indicate probability of finding a block in one day 12:16:09 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2994 13:01:09 -xmr-pr- rating89us opened pull request #2995: history: change sent transaction dot color from orange to red 13:01:09 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2995 13:16:09 -xmr-pr- rating89us opened pull request #2997: history: fix amount display + remove trailing zeros in amount 13:16:09 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2997 13:16:09 -xmr-pr- rating89us opened pull request #2996: history: fix search filter not working when there is a pending tx 13:16:09 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2996 16:19:14 .merge+ #2997 #2996 #2988 #2978 #2976 #2949 16:19:23 .merges 16:19:23 -xmr-pr- #2940 #2948 #2949 #2974 #2976 #2977 #2978 #2988 #2991 #2996 #2997 16:23:17 .merge+ #2935 #2915 16:23:17 Added 16:23:33 does `ratingus85` ever come here? 16:26:02 he seems to redesign everything, might be nice to discuss it beforehand first 16:26:38 ¯\_(ツ)_/¯ 17:22:52 89 17:23:54 Would that be close enough ? 17:24:16 Maybe it was that person's age when they registered in 2016 ^_^ 17:27:37 Missed my window >:| 18:01:20 .merge+ #2994 18:01:20 Added 18:04:04 luigi1111w: can haz? 18:06:03 yes 18:06:20 what was the question 18:08:54 merge-wave when possible :) 18:09:19 but they've piled up and look big now 18:09:53 should have used the opportunity of you saying Yes to a future unspecified question by asking for core team membership ;x 18:10:10 Maybe do half? 18:12:17 .... a quarter? :D 18:44:56 * dsc_ is working on another Monero GUI, where he can merge and admin the issue/PR tracker himself 18:44:59 * dsc_ can't wait 18:47:23 luigi1111w: thank you sir 18:48:32 hey I did a quarter nice 18:48:38 o/ 18:55:43 dsc_: Do you disagree with some of the redesigns? 19:01:05 dEBRUYNE: He's doing rather great work honestly 19:02:00 just some small tweaks and/or suggestions that could be discussed over IRC, especially before coding them could help 19:03:24 Previously i've discussed features/redesign with other people first before coding large PRs 19:08:55 dEBRUYNE: what do you think of this one: https://github.com/monero-project/monero-gui/pull/2936 ? 19:10:40 fwiw the sending screen redesign is from knueffelbund designs 19:11:32 but yep 2936 can be discussied, it encourages using a fresh address everytime which is good for privacy but might be a bit more complicated to use 19:14:43 Haven't looked at that one in detail yet to be honest 19:14:52 dEBRUYNE: He's doing rather great work honestly <= Ok great! 19:16:36 slstsrv: I'm running that PR and it's pretty great, I ought to review it properly 19:17:32 The "always new address" works well, I'd even argue the UX proposed here is less complicated 19:18:00 It marks the address as "used" as soon as you copy it to the clipboard 19:19:11 just wondering if it automatically increments the lookahead 19:24:11 in addition, lookaheads are stored inside wallet cache, so a mnemonic seed restore on another pc would require you to also correctly specify that, else you might end up reusing old subaddys? 19:24:42 do you know the default lookahead? 19:24:53 Either 200/50 or 50/200. 19:24:54 200 or 500 from the top of my head 19:24:57 afaik it is less when using ledger / trezor which could be a problem 19:25:06 Ledger is somehting like 10 I believe. 19:25:30 right, using 10 addresses without receiving can quickly happen if it always generates a new one 19:25:41 So if the GUI is generous in giving out addresses, restoring might become a hurdle 19:26:01 (if we don't have the proper UX to signal that lookaheads are important) 19:27:20 Suppose the GUI could loop to find out which subaddresses have been used previously (incoming txs) till it finds a clean one 19:28:22 right but we don't want to do that else we might give out the same subaddress to multiple people 19:28:34 true... 19:35:11 I guess this is a showstopper for this PR then? Anyone got a good idea? :D 19:36:32 New seed format: include restore height and lookahead :) 19:36:45 lol 19:39:52 I don't hear any No's :) 19:44:11 Also another thing I'm wondering; if the GUI hands out addresses like there is no tomorow ... what is the wallet scanning performance like after years of usage? 19:44:43 Or is this a moot point because It's very easy to just replace your wallet for a new one when it gets slow? 19:44:50 questions .. questions 19:48:08 should be negligible 19:52:39 also it only generates a new subaddress if you copy the address on the receive screen which should not happen that often 19:52:48 but the lookahead on ledger / trezor is a valid concern 19:54:45 21:48 should be negligible <-- subaddresses are designed in a way to not affect scanning performance, only initially creating the lookup table (using lookahead) is resource intensive 19:55:16 ah okay 20:23:52 .merge+ #2989 20:23:53 Added 20:31:04 .merge+ #2935 20:31:09 -xmr-pr- selsta opened pull request #2998: workflows: fix macOS build 20:31:09 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2998 20:34:41 .merge+ #2998 20:34:42 Added 20:34:51 .merges 20:34:51 -xmr-pr- #2915 #2935 #2989 #2991 #2998 20:36:55 xiphon: do you have idea about my issue with #2991 when using non brew Qt or should we merge this for now? 20:37:09 an* 20:41:30 selsta: i need an environment to reproduce the issue and fix it 20:42:16 ok, will see how to do this 20:43:01 how do you install qt? Downloading .dmg and running some installation script? 20:43:09 using normal Qt installer 20:43:42 Could this be done from a terminal? 20:43:55 https://www.qt.io/download-open-source 20:43:58 Qt online installer 20:43:59 will see 20:44:12 else we can purchase a Mac VM for a month 20:53:23 "should we merge this for now?" -> yes, the PR implements CMake reelase build on MacOS with qt installed through package manager 20:53:45 sounds good, the issue I have is not related to that PR anyway 20:54:37 though it failed to build now with some lrelease related issue 21:01:09 -xmr-pr- xmrdsc opened pull request #2999: Donate to Monero feature 21:01:09 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2999 21:21:54 there is a mac vm snap you can use called sosumi or something like that 21:22:16 https://snapcraft.io/sosumi 21:27:54 "though it failed to build now with some lrelease related issue" -> due to merged CMake translations PR, wokring on it 21:49:11 kinghat[m]: thanks, though not sure if xiphon wants to bother installing this on his system, a VM would be easier 21:50:00 running a Mac VM on Linux / Windows is quite hacky 21:51:18 ya its all hacky. 21:51:22 a Mac VPS would be easier* 21:51:26 that looks like an easy way to go about it though 21:51:36 mac vps isnt free i dont think 21:51:48 unless ppl are handing them out to oss projects 21:52:11 yea I know but I’m sure we could get one funded for a month :P 21:54:49 fuck apple 21:55:15 pardon my english 21:56:14 they sure make it difficult for open source projects 21:57:16 they dont have a problem using oss 22:02:53 i heard that they didnt like the gpl3 of samba so they rolled their own or something 22:19:50 .merges 22:19:51 -xmr-pr- #2915 #2935 #2989 #2991 #2998