xiphon: are you okay with #2655?

it’s a larger change so I wanted to ask you before adding it to the merge list

selsta: will review it in a while

ok will wait until then

i don't like it contains a couple of unrelated changes

1. Settings -> Wallet page

2. Removes Merchant menu item and moves it to Settings -> Wallet page

I asked for 2, but agree that it would be better in a separate PR

can you elaborate on 1?

on the other hand, we may let it go it

s/it/in

"can you elaborate on 1?" -> is the first one of two unrelated changes

just outlined which ones

Not sure about "Lock the wallet" menu option, might be not the best place for it and bloats the Wallet page

right but I don’t understand what you mean with Settings -> Wallet page

The whole Wallet page refactoring

and changing Merchant menu item

ok

i really like the redesign

but i definitely don't like how it changes a lot of unrelated things

yep I understand

you would prefer only SettingsListItem.qml changes?

Yep, and all the other changes in separate PRs

can you comment on PR?

i can strip the SettingsListItem changes and commit them myself

with attribution to original author of course

will do that tomorrow

yea I don’t know how available tobtoht is

ok

.merge+ #2821

Added

.merge+ #2819

Added

.merges

hey selsta you work with nodejs at all?

nope never used nodejs

👌

im actually not sure if its node related, but nix distribution related. can i PM you as its off topic here. has to do with stdout and errors.

you can PM me but not sure if I can help :D

i understand.