01:44:16 <selsta> xiphon: are you okay with #2655?
01:44:31 <selsta> it’s a larger change so I wanted to ask you before adding it to the merge list
01:53:36 <xiphon> selsta: will review it in a while
01:54:00 <selsta> ok will wait until then
01:57:59 <xiphon> i don't like it contains a couple of unrelated changes
01:58:54 <xiphon> 1. Settings -> Wallet page
01:59:45 <xiphon> 2. Removes Merchant menu item and moves it to Settings -> Wallet page
02:01:02 <selsta> I asked for 2, but agree that it would be better in a separate PR
02:01:37 <selsta> can you elaborate on 1?
02:02:46 <xiphon> on the other hand, we may let it go it
02:03:27 <xiphon> s/it/in
02:05:04 <xiphon> "can you elaborate on 1?" -> is the first one of two unrelated changes
02:05:12 <xiphon> just outlined which ones
02:07:04 <xiphon> Not sure about "Lock the wallet" menu option, might be not the best place for it and bloats the Wallet page
02:07:24 <selsta> right but I don’t understand what you mean with Settings -> Wallet page
02:09:19 <xiphon> The whole Wallet page refactoring
02:09:33 <xiphon> and changing Merchant menu item
02:10:01 <selsta> ok
02:13:51 <xiphon> i really like the redesign
02:14:09 <xiphon> but i definitely don't like how it changes a lot of unrelated things
02:14:17 <selsta> yep I understand
02:14:40 <selsta> you would prefer only SettingsListItem.qml changes?
02:15:07 <xiphon> Yep, and all the other changes in separate PRs
02:16:15 <selsta> can you comment on PR?
02:17:50 <xiphon> i can strip the SettingsListItem changes and commit them myself
02:18:02 <xiphon> with attribution to original author of course
02:18:44 <xiphon> will do that tomorrow
02:18:48 <selsta> yea I don’t know how available tobtoht is 
02:18:48 <selsta> ok
03:00:21 -xmr-pr- Landan-Shoemaker opened issue #2820: Unable to start monero-wallet-gui Qt version incompatible
03:00:21 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/2820
13:15:21 -xmr-pr- xiphon opened pull request #2821: Settings: rework wallet page
13:15:21 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2821
17:13:29 <selsta> .merge+ #2821
17:13:29 <xmr-pr> Added
19:32:25 <selsta> .merge+ #2819
19:32:25 <xmr-pr> Added
19:32:27 <selsta> .merges
19:32:27 -xmr-pr- #2739 #2772 #2819 #2821
19:34:42 <kinghat[m]> hey selsta you work with nodejs at all?
19:35:05 <selsta> nope never used nodejs
19:35:20 <kinghat[m]> 👌
19:37:14 <kinghat[m]> im actually not sure if its node related, but nix distribution related. can i PM you as its off topic here. has to do with stdout and errors.
19:37:39 <selsta> you can PM me but not sure if I can help :D
19:37:50 <kinghat[m]> i understand.