-
mj-xmr
I'm happy with the answer :)
-
mj-xmr
Another topic. I have this parallel execution tests branch: 7283. I'm not 100% sure about its stability. Would you be OK with me trying to execute each test in a Docker image for better isolation and more freedom for the developer?
-
selsta
I don't think this would be a good idea
-
mj-xmr
selsta, Thanks. Then I'll focus on what we currently have and limit non-parralelizable parts in a single execution chain.
-
moneromooo
tbh a lot of these patches seems like doing things because they seem fun rather than useful.
-
moneromooo
Quite frankly, if tests require docker, the first thing I'll do is revert that patch on my work branch.
-
moneromooo
But hey, maybe I'm just not seeing the usefuless of it and others may benefit.
-
mj-xmr
moneromooo, imagine, that I want to change a functionality and I'm unsure if the change doesn't introduce regressions. I run core tests and learn this after 2 hours. Are you OK with this? I'd like to learn it in maximum 10 minutes.
-
moneromooo
Are you suggesting docker speeds proceeses up ?
-
moneromooo
ie, it can distribute to other machines or something ?
-
mj-xmr
It will isolate the tests, so they can be ran in as many cores as you have, with 0 risk that they interact with each other negatively.
-
mj-xmr
*on cores
-
mj-xmr
Other machines could also be considered. Yes.
-
moneromooo
OK, that does seem useful if you've got the hardware.
-
mj-xmr
I have the hardware, and I know that other members consider building a farm for Monero.
-
» moneromooo feeling a bit unsettled by the idea of someone building a farm for monero
-
mj-xmr
All the changes that I make will need to be able to be ran in a local and single core environment. I'm myself agains any kind of vendor lock-in.
-
mj-xmr
Evne OSS.
-
mj-xmr
And regarding my "fun" patches, I'm trying to make this environment easier to work with. All such changes are in all the projects, which I manage. I'm not saying that I can do it until infinity. At some point I plan to either thank for cooperation and leave, or learn the internals and do the actual development. But with the current state of the health I'd only frustrate myself.
-
mj-xmr
... frustrate by doing feature development while having to wait 2 hours for the tests.
-
mj-xmr
Also I have this extra motivation, regardless all the criticism, that I'm heavily invested in Monero as the only coin that fulfills all my restrictive requirements.
-
mj-xmr
Having to say goodbye, because I can't fix it by myself will be emotional for me :)
-
mj-xmr
In that case I'd most probably sell all my crypto holdings and do something else...
-
mj-xmr
Also, I believe that coding SHOULD be fun, rather than masochism. Otherwise you loose the motivation.
-
mj-xmr
But IDK. Everybody is different.
-
wfaressuissia[m]
"... or learn the internals and do the actual development." it would be right choice
-
wfaressuissia[m]
"... be fun, rather than masochism." it depends on point of view: something is fun for developer but masochism for others
-
mj-xmr
wfaressuissia[m], Thanks. Hell I'd love to do it all full time and this is not all that impossible. But first I need to learn if the environment is supportive for this from many dimensions. So far I can say that nobody is kicking me out.
-
mj-xmr
Different opinions than mine or hard reviews are not yet a tragedy for me.
-
mj-xmr
-
mj-xmr
100% tests passed, 0 tests failed out of 20
-
mj-xmr
Testing took: 15 minutes.
-
mj-xmr
Status: 0
-
mj-xmr
How cool is that?
-
wfaressuissia[m]
"... love to do it all full time " it depends on you. If it really matters then accumulate some savings, drop current job and switch to another which is more interesting for you.
-
mj-xmr
jobs are rarely interesting for me. I prefer the anarchic/voluntary environment like this one.\
-
moneromooo
Not that really matters, but... core tests took 742 seconds here (and that's on Townforge, which has got extra core tests). And that's with a dozen line patch IIRC.
-
moneromooo
Then again, if someone wants to review and ok this, I'll only moan if it's default and hard to bypass :)
-
mj-xmr
I totally get that attitude.
-
selsta
-
selsta
this was the patch that would speed up core tests
-
moneromooo
Oh yeah. It's simpler now, it doens't change CN/RX, it just reroutes to keccak at the top level. Faster too.
-
mj-xmr
That speed up was not at competitive to what I'm doing, but complimentary. Also it modifies the default behavior, while it could have worked just like you expect from others - be there for anybody who wants to switch it on. Are you in for reopening this PR maybe?
-
mj-xmr
moneromooo ^
-
mj-xmr
I'm writing a documentation file, where all mine non-default (and so the above) hacks would be made clearer for the new devs:
-
mj-xmr
-
mj-xmr
It should be ready until 18.04
-
moneronero
hi, i'm forking monero can you guys help on some doubts about the code?
-
hyc
have you guys seen this? abusing Github Actions to run xmrig
twitter.com/campuscodi/status/1378126998741061634
-
moneronero
is this paper up to date? I mean, is there any newer version of it?
-
moneronero
-
hyc
we don't help forks / forkers
-
moneromooo
It's mostly ] haup to date for the pre-ringct part I think. We can answer questions about monero, but help forking will be your own job.
-
anon_udxf6fdz[m]
I'd like to create an issue within the monero repo related to the cli wallet. I understand this is restricted due to the recent spam. How should I go about raising the issue?
-
moneromooo
ping someone with admin access to it, like luigi1111 or fluffypony, and arrange for a time
-
moneromooo
Alternatively I guess you can paste the text somewhere and I can file it for you.
-
anon_udxf6fdz[m]
Prefer to provide you with a pastebin
-
anon_udxf6fdz[m]
-
moneromooo
Requires js, and the text doesn't seem to be available in the source.
-
moneromooo
Try paste.debian.net or paste.ubuntu.com
-
anon_udxf6fdz[m]
Sry
-
anon_udxf6fdz[m]
-
moneromooo
Posted, tanks.