Do you also secretly wisth your mother was Howard's groupie? reddit.com/r/Monero/comments/bxl87y…s_since_monero_was_released/eq7qior

moneromoo, still pruning here ... /fyi

Do you also secretly wisth your mother was Howard's groupie? reddit.com/r/Monero/comments/bxl87y…s_since_monero_was_released/eq7qior

I'm planning to do some minor changes to the Monero code base. Where can I find coding and commiting guidelines?

There's a CONTRIBUTING.md file.

Yeah, that's a good start, but it is a bit boiler-plate, isn't it?

Like: - A patch MUST adhere to the code style guidelines of the project if these are defined.

Good idea, but what are the guidelines

And how to change external stuff like lmdb the correct way?

Oh WTF. This is not what I wrote :S

I had something like "use common sense, no random reindent, try to follow local style, minimal patches, split patches if you make unrelated changes", that kind of thing.

Some lawyer went through it now :/

I like your approach :)

OK, my text is still in there at least.

So I guess use my line above as a guide and you'll be just fine :)

I wanna try to optimize monero-blockchain-prune as a way to learn more about the project, the codebase, and the commit and review processes. Seems to be a fairly isolated task which can be tested and verified without affecting the rest of the project, so I'm aiming for that. Need a faster way to test, though. Can't spend days for each test...

I suggest exporting part of the (unupruned) chain, and testing on that.

Ack

Proably stagenet, since it'll have txes right at the start: mainnet is mostly empty blocks for qute a while.

See monero-blockchain-export --help for the stop block param.

+1, thanks.

I'm reasonably sure it just needs txn commit/reset at appropriate moments.

Maybe when switching stripes.

Just one txn today, it seems

HI. v.ht/5pMxfO

sandarinna[m] No

moneromoo: I've read CONTRIBUTING.md, but am new to OS projects. If you don't mind, please double-check if I've understood things correctly. 1) I'm supposed to fork monero-project/monero at github.com 2) I'm supposed to check out my forked copy of monero and create a branch there. 3) When the feature/change is OK, I'm supposed to create a PR in monero-project/monero. Is that the gist?

Yes, that's it.

I can do that :)

boa: welcome :)

here's a good article on the model: reflectoring.io/github-fork-and-pull

it has some common git CLI commands you may need

Thanks :) I do prefer CLI as much as possible, so this is useful

are you able to contribute with repo locked to previous contributors?

that might be an issue

selsta: good point - bao when you're ready to submit the pull request let us know and we'll temporarily unlock the repo

it's currently locked to contributors who haven't contributed before due to an ongoing spam attack

boa I mean, not bap

fluffypony: Does Github have a feature that allows you to add contributors to some kind of approved list?

Reddit basically has that

we can add users with read permissions to the organization

but that's not ideal too

Maybe this -> docs.github.com/en/github/setting-u…laborators-to-a-personal-repository

no can't use that

selsta: yeah it's not a solution

better to just unlock temporarily when needed

myself / luigi1111 / binaryFate can unlock and re-lock as needed

<sandarinna[m] "HI. v.ht/5pMxfO"> sgp_ please ban. I can help with moderation on matrix if you want.

@fluffypony: ack. It'll take weeks until then, though, as I do this mostly to learn about how Monero is implemented.

Why are you here? For the tech? Then you should be off at Zcash instead of trying to con newbies into a coin that doesn't work. For the money? If you put your money in BTC or ETH you would have been better off. For the magical crypto friends? Monero leadership laughs from losers like that. Find yourself more healthy realationships that don't laugh at you when they steal your money.

boa, whenever you want to test faster, please let me know. I know many tricks regarding this part.

I can reduce the 1 hour long core_tests down to 7 minutes for example.

There are also some ctest tricks, which are able to exclude tests, which have nothing to do with your PR.

boa, also I advice to install ccache. Monero's build system takes care of the rest.

Thanks, mj-xmr, I appreciate that. My computer is still pruning btw, and it's been doing that for 32 hours. It'll hopefully be finished tomorrow...

boa, I don't know much about this part, but do you actually see any difference in disk space usage over time?

usually syncing from scratch with pruning enabled is faster than pruning an existing chain

Does getmonero.org use any kind of server-side analytics for traffic monitoring? Is it possible for me to get a screenshot of the traffic if it exist, please? :)

traffic chart*

angrymonkeyboi: try #monero-site

i think there are server logs only

but i might be wrong

Thank you