wfaressuissia[m]: will you want to review monero-project/monero #7345 ? It's going to be right in your area.

What kind of person steals from own community? shorturl.at/jmDM4 Your own leaders are laughing at how stupid you are falling for thier 'Magical Crypto Friendship'.

.merges

Please mention once the merges are done, so I can run a report generation. Thanks.

mj-xmr: please also add monero-project/monero #7401 to adaptive mining

so that the test gets skipped if python dependencies are not installed

afterwards it's good from my side

selsta, on it. Thanks for coordination.

I'll just rebase.

Rebased. Waiting for the tests. monero-project/monero #7387

Oops. I need to add there the other missing requirements.

yep that's what I meant

commit name looks wrong

<selsta> commit name looks wrong <--- because it's a different branch.

Can it be like this, in order to avoid conflicts?

PR title and commit title don't match

7387 looks ok now

Ah damn. Thanks

selsta, Done. Sorry working under pressure, because I don't want to miss TehMergeTrain™

Why does the Saviour of NASA take a group achievement award and present it as a proof of individual glory? twitter.com/hyc_symas/status/1203709575226183683

selsta, there's a testing problem with the "Adaptive". I can reproduce it locally.

selsta, it's a problem on Master

I can have a look after lunch.

If anybody wants to pick it up before this time (so in the coming 2 hours), please let us know, not to double the work time.

monero-project/monero #7366 this seems to make functional tests fail

vtnerd: ^

I guess everybody thought, that it was just that ever-failing mining test, that I'm about to fix.

I still need to do some house cleaning and in about an hour I can look into current issues until the end of the day.

OK. I finally have time and will have a look at master now.

vtnerd, have you already picked up 7366?

I might have quick fixed 7366 by temporarily disabling the feature.

check_missing_rpc_methods is still failing. selsta should these quick fixes be in separate branches?

What's missing ?

Did you know that all witdraw-buyer-seller-depoist chains are trackable in Monero? No? You should have read Breaking Monero. How many people are you endangering with your 'privacy' coin?

moneromooo, Error: wallet API method scan_tx does not have a matching function

I'm lost on this one TBH

Ah, new RPC. I'll add it.

Thanks. Then I'll PR my "fix" and vtnerd can fix it up later on.

moneromooo, I don't know where you prefer discussing, but my rationale is, that a feature, which breaks tests, also prevents other features from being tested with the same test.

Which is why I'm overreacting here.

and as usual, it concerns my ill-fated Adaptive Mining tests, which for this reason can't be merged (X_X)

I just wish, that one day we can have a policy: "Failing tests -> no merge"

Does disabling the test make it so the other feature can be tested with the (now disabled) same test? Seems like either way the new feature cant use that test. Might as well leave it enabled and failing, as an indication that someone needs to come fix the test

childofthecorn[m, The proper, honest and responsible reaction would actually be to REVERT the change which introduced the regression. I'm trying hard not to be an asshole to demand it.

<mj-xmr "childofthecorn, The proper, hone"> I've been that asshole in other projects. Features shouldn't merge with broken tests, IMO.

Exactly

But also, broken tests with loud errors are better than disabled tests with no errors

This is not a broken test.

Ah, I misread. I'll see myself out 😅

s/broken/failing/

OK so what I did was disabling the feature, which broke the test.

And I did it in a polite way, by not reverting vtnerd's changes.

So he can have his due weekend and return on Monday to provide a proper fix.

And also, when his feature breaks the test, it disables testing of other ~20 features, which opens the door for regressions even wider.

The academic term of this situation is a fucking mess.

childofthecorn[m, I know why you misread. Because I said it so earlier as if the test was broken. The test tests many things. One of them is mining, which fails with about 50% probability. I fixed this and was very close for this to be merged. Then this breaking change came and my PR can't me merged anymore.

So I hope you see the irony.

Devs are by now used to ignore the test, since they think it's that bloody mining test failing again.

So there you have it.

Ahhh, I see now. I should have remained a fly on the wall anyways :)

Thanks for the clarification

"I should have remained a fly on the wall anyways :" <--- well you did confirm a rigid methodology.

i.e. failing tests -> no merge

"The academic term of this situation is a fucking mess." -> a bit hyperbolic, but will fix test

I'm signing off for today.

some of these tests were/are brittle iirc, but hopefully that has been sorted out