monero-wallet-cli now complains that index=n is invalid keyword (but it works as expected)

0.17.1.9 release

Inge-: could you open a Github issue for it?

Not currently I'm afraid. But it should be obvious to see when one is aware of it. seems to be consistent.

Is this ready to be merged, or does it need a final "Tick"?

Needs final approval as far as I can see

.merges

OK. Does selsta want a beer?

7000 looks good to me

'Oddly, no one who was directly involved with the SIR-C missions and currently still working the Lab, remembers the name Howard Chu, except for one who vaguely recalls Eugene Chu as having a brother names Howard'

Ed Caro, NASA Chief Engineer. cryptogazette.com/wp-content/uploads/2019/12/1-768x1445.png

will test on my mac and then approve

thx!

.merge+ 7361 7362 7355 7352 7351 7343 7341 7339 7340 7332 7333 7331 7325 7319 7313 7312 7311 7294 7288 7284 7275 7273 7270 7265 7252 7242 7185

Added

moneromooo: could you please review / approve 7309? you approved 7308 (master equivalent)

mj-xmr: testing 7000 now, do you know why Github displays no changes when clicking on "force-pushed" ?

you did change something so maybe a github bug

I addressed your finding, namely I changed the span reference to pass-by-value.

yep, I did see that, that’s why I was confused that github says there are no changes

So the cause for the bug may be, that I don't use git push -f, but rather git push origin +BRANCH_NAME

Next time I will try the old way.

I understand that not being able to see the latest change is 1) confusing, 2) simply dangerous.

.merge+ 7000

Added

done

thanks

That list doesn't seem very chronological. There's a few 6xxx PRs.

ok, will go through the older ones too

moneromooo: could you force push 6896 to run CI? it seems like it fails to compile on i686-w64-mingw32

undefined reference to `AcquireSRWLockExclusive'

I'd have done that blind by looking at the MS docs.

Min version: either windows vista or windows server 2008. vista is now fairly old I think ?

I'm guessing circa 2008 ? :)

The windows build passed though, looking at the CI list...

Oh, that's a link error, nvm.

depends 32 bit windows is failing, the 64 bit one seems fine

hyc: please review 6896 again, you approved it previously

(mooo did some minor changes to it)

Which I have no idea whether it'll work, I've just added the lib the MS docs say to the link line.

so someone needs to do an actual win32 build?

github is doing it.

ok cool

6896 probably fails because of github.com/monero-project/monero/blob/master/CMakeLists.txt#L649

0501 is WinXP docs.microsoft.com/en-us/cpp/portin…inver-and-win32-winnt?view=msvc-160

.merge+ 7349

Added

XP was before vista ?

Yes, ~2001, IIRC.

Vista is 0600, from that MS list.

I guess we could revert to mutexes (mutices ?) on win32.

It'd already mine like a pig anyway.

We support XP and Vista 0.o

32 bit build supports WinXP.

yikes

Why?

Just because it's easy, or some larger reason?

.merge+ 6877 6959 6986

Added

Both have been EOS/EOL for many years

The var was never updated ?

s/var/definition/

Seems something that should be dropped to save some complexity but I know nothing about the details of it here.

Just hope we're not burning cycles on XP/Vista support or compat

I think my windows build VM is winXP64

but I haven't used it since switching to gitian build

0600 fixes 6896 here for release-static-win32 target (I also removed kernel32 from the link line).

BTW, all OSes below 0A00 are EOL, IIRC. I might be wrong.

Anyone against this ?

hyc: looks like you added this originally. Any particular reason, or just "might as well" ?

Guess it would KO any WinXP/Srv2k3 botnets.

Surely they don't use monerod ?

Right, but who knows...

well don't knock out botnets running full nodes on winxp/srv2k3 !!