08:44:18 <Inge-> monero-wallet-cli now complains that index=n is invalid keyword (but it works as expected)
08:44:40 <Inge-> 0.17.1.9 release
09:30:31 <selsta> Inge-: could you open a Github issue for it?
09:55:36 <Inge-> Not currently I'm afraid. But it should be obvious to see when one is aware of it. seems to be consistent.
16:03:37 <mj-xmr> Is this ready to be merged, or does it need a final "Tick"?
16:03:38 <mj-xmr> https://github.com/monero-project/monero/pull/7000
16:07:59 <dEBRUYNE> Needs final approval as far as I can see
16:08:06 <dEBRUYNE> .merges
16:08:06 -xmr-pr- 7308 7309
16:15:16 <mj-xmr> OK. Does selsta want a beer?
16:15:56 <selsta> 7000 looks good to me
16:16:15 <hautdryep> 'Oddly, no one who was directly involved with the SIR-C missions and currently still working the Lab, remembers the name Howard Chu, except for one who vaguely recalls Eugene Chu as having a brother names Howard'
16:16:15 <hautdryep> Ed Caro, NASA Chief Engineer. cryptogazette.com/wp-content/uploads/2019/12/1-768x1445.png
16:16:33 <selsta> will test on my mac and then approve
16:16:42 <mj-xmr> thx!
20:01:01 <selsta> .merge+ 7361 7362 7355 7352 7351 7343 7341 7339 7340 7332 7333 7331 7325 7319 7313 7312 7311 7294 7288 7284 7275 7273 7270 7265 7252 7242 7185
20:01:01 <xmr-pr> Added
20:01:31 <selsta> moneromooo: could you please review / approve 7309? you approved 7308 (master equivalent)
20:02:17 <selsta> mj-xmr: testing 7000 now, do you know why Github displays no changes when clicking on "force-pushed" ?
20:02:36 <selsta> you did change something so maybe a github bug
20:03:18 <mj-xmr> I addressed your finding, namely I changed the span reference to pass-by-value.
20:03:44 <selsta> yep, I did see that, that’s why I was confused that github says there are no changes
20:03:45 <mj-xmr> So the cause for the bug may be, that I don't use git push -f, but rather git push origin +BRANCH_NAME
20:04:09 <mj-xmr> Next time I will try the old way.
20:04:33 <mj-xmr> I understand that not being able to see the latest change is 1) confusing, 2) simply dangerous.
20:17:29 <selsta> .merge+ 7000
20:17:29 <xmr-pr> Added
20:19:18 <moneromooo> done
20:19:22 <selsta> thanks
20:20:27 <moneromooo> That list doesn't seem very chronological. There's a few 6xxx PRs.
20:21:55 <selsta> ok, will go through the older ones too
20:22:35 * iDunk hopes 6810 will finally be merged
20:23:10 <selsta> moneromooo: could you force push 6896 to run CI? it seems like it fails to compile on i686-w64-mingw32
20:23:23 <selsta> undefined reference to `AcquireSRWLockExclusive'
20:24:00 <moneromooo> I'd have done that blind by looking at the MS docs.
20:24:10 * moneromooo goes look again
20:27:03 <moneromooo> Min version: either windows vista or windows server 2008. vista is now fairly old I think ?
20:27:40 <moneromooo> I'm guessing circa 2008 ? :)
20:28:28 <selsta> https://www.irccloud.com/pastebin/wADjFOEZ/
20:29:24 <moneromooo> The windows build passed though, looking at the CI list...
20:29:38 <moneromooo> Oh, that's a link error, nvm.
20:30:16 <selsta> depends 32 bit windows is failing, the 64 bit one seems fine
20:33:11 <selsta> hyc: please review 6896 again, you approved it previously
20:36:19 <selsta> (mooo did some minor changes to it)
20:39:46 <moneromooo> Which I have no idea whether it'll work, I've just added the lib the MS docs say to the link line.
20:40:00 <hyc> so someone needs to do an actual win32 build?
20:40:22 <moneromooo> github is doing it.
20:40:39 <hyc> ok cool
22:05:52 <iDunk> 6896 probably fails because of https://github.com/monero-project/monero/blob/master/CMakeLists.txt#L649
22:06:02 <iDunk> 0501 is WinXP  https://docs.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-160
22:13:24 <selsta> .merge+ 7349
22:13:24 <xmr-pr> Added
22:19:04 <moneromooo> XP was before vista ?
22:19:25 <iDunk> Yes, ~2001, IIRC.
22:19:53 <iDunk> Vista is 0600, from that MS list.
22:23:18 <moneromooo> I guess we could revert to mutexes (mutices ?) on win32.
22:23:30 <moneromooo> It'd already mine like a pig anyway.
22:23:50 <sethsimmons> We support XP and Vista 0.o
22:24:51 <iDunk> 32 bit build supports WinXP.
22:25:01 <sethsimmons> yikes
22:25:04 <sethsimmons> Why?
22:25:12 <sethsimmons> Just because it's easy, or some larger reason?
22:25:32 <selsta> .merge+ 6877 6959 6986
22:25:33 <xmr-pr> Added
22:25:35 <sethsimmons> Both have been EOS/EOL for many years
22:25:56 <iDunk> The var was never updated ?
22:26:44 <iDunk> s/var/definition/
22:27:03 <sethsimmons> Seems something that should be dropped to save some complexity but I know nothing about the details of it here.
22:27:16 <sethsimmons> Just hope we're not burning cycles on XP/Vista support or compat
23:22:08 <hyc> I think my windows build VM is winXP64
23:22:31 <hyc> but I haven't used it since switching to gitian build
23:38:52 <iDunk> 0600 fixes 6896 here for release-static-win32 target (I also removed kernel32 from the link line).
23:40:55 <iDunk> BTW, all OSes below 0A00 are EOL, IIRC. I might be wrong.
23:43:30 <moneromooo> Anyone against this ?
23:43:48 <moneromooo> hyc: looks like you added this originally. Any particular reason, or just "might as well" ?
23:48:22 <iDunk> Guess it would KO any WinXP/Srv2k3 botnets.
23:51:06 <moneromooo> Surely they don't use monerod ?
23:54:59 <iDunk> Right, but who knows...
23:57:40 <gingeropolous> well don't knock out botnets running full nodes on winxp/srv2k3 !!