-
usamatthanks wowmario
-
usamat*wowario
-
peach34why are key images part of the tx prefix hash? Given that signatures offer the key image anyway
-
peach34is it just for convenience in the code
-
peach34simplicity
-
peach34If I wanted to take a random hash (anything hash possible in the 32 byte space) and turn it into a valid EC point, which function should be used?
-
peach34is
-
peach34ge_fromfe_frombytes_vartime
-
peach34sufficient?
-
peach34or will that only work for valid hashes of *allowed *curve points
-
moneromooohashToPoint IIRC.
-
moneromoooBasically hashes, multiplies by G and by 8.
-
moneromoooYou may want to add some "domain salt" to the data you hash.
-
peach34when you say it hashes, do you mean it hashes and converts to scalar modulo l
-
peach34then does * G * 8
-
peach34the function reads:
-
peach34void hash_to_point(const crypto::hash &h, crypto::ec_point &res) {
-
peach34ge_p2 point;
-
peach34ge_fromfe_frombytes_vartime(&point, reinterpret_cast<const unsigned char *>(&h));
-
peach34ge_tobytes(crypto::operator &(res), &point);
-
peach34}
-
moneromoooLooks like I remembered wrong, hashToPoint does not exist...
-
peach34doesn't the one above do the trick?
-
moneromoooAh, it got removed. There's hash_to_p3 now.
-
moneromoooAnd it looks like it's doing what you say. Plus the *8.
-
peach34am I right in thinking the p2 is the compressed point and p3 has the explicit sign
-
peach34thanks btw will take a look
-
peach34Would you mind explaining what you meant by domain salt?
-
peach34in this context anyway
-
moneromoooSome arbitrary data concatenated to your input, such that the same input will not yield hte same point for two different uses. Might or might not be useful in your case.
-
peach34thanks but doesn't affect me
-
UkoeHBpeach34: key images are in the prefix explicitly, as opposed to implicitly in the round harsh
-
UkoeHBhash*
-
UkoeHBit’s probably more of a best practice than absolutely necessary
-
peach34yes that's what I meant
-
selsta.merges
-
xmr-prMerge queue empty
-
selsta.merge+ 7308 7309
-
xmr-prAdded
-
selsta7309 needs an approval, 7308 (master equivalent) is approved by vtnerd