-
hyc
uff. just noticed, i2p-zero process size is 5.8GB. 1.5GB resident. that's more than monerod is using
-
hyc
on my public node...
-
hyc
I'll never understand people writing network utilities in java
-
hyc
or any system programming, for that matter.
-
hyc
how do you expect to get any adoption if your router uses more system resources than the application it's there to support
-
xmr-pr
selsta opened pull request #7038: build: prepare v0.17.1.4
-
xmr-pr
-
selsta
v0.17.1.4 merge list: 7018 7024 7026 7028 7037 7038
-
selsta
xiphon: please open 7018 and 7024 against release branch
-
xmr-pr
xiphon opened pull request #7040: [release-v0.17] rpc: skip non-synced bootstrap daemons in --no-sync mo...
-
xmr-pr
-
xmr-pr
xiphon opened pull request #7039: [release-v0.17] cryptonote_core: dandelion++ - use median remote block...
-
xmr-pr
-
xiphon
selsta: done
-
selsta
ty
-
selsta
7038 7039 need an approval
-
selsta
afterwards we can tag I think
-
hyc
issue #7029 needs to be addressed.
-
hyc
this appears to be a regression in 17.1.3
-
hyc
whatever change was made probably should be reverted
-
hyc
adding a new field, as in PR#7030 seems like the wrong fix. it is still a breaking change in the RPC API.
-
selsta
do we know it is from v0.17.1.3? I thought the regression was from v0.17 overall
-
xmr-pr
lh1008 opened issue #7041: Error: Error mining to daemon: Found nonce, but daemon errored out wit...
-
xmr-pr
-
hyc
hmmm, trying to see the commit history
-
hyc
looks like this actually hasn't changed since 2018 at least
-
hyc
the issue seems invalid
-
selsta
yea I don’t think target height ever worked this way
-
selsta
7030 should still be fine, just not for this release
-
hyc
it is definitely not OPTIONAL in the definition
-
hyc
I think the doc update was just wrong
-
hyc
monero-site commit 746a5ffb4
-
selsta
Guest20675: ^
-
hyc
updated the ticket. at most, a doc fix is needed to correct the description in sync_info, the value is not optional
-
xiphon
hyc: "adding a new field, as in PR#7030 seems like the wrong fix"
-
xiphon
^ what is the correct way at the moment to check if a node is synced or not via RPC?
-
xiphon
i don't see any legit/documented way to do that
-
xiphon
or should we explicitly say that "you have to deduce the node sync status by looking at the target_height"
-
selsta
yea that's why we should add 7030
-
selsta
just not for necessary for release branch IMO
-
hyc
as discussed in that ticket - when a node is sync'd, target_height is zero.
-
LyzaL
maybe a separate issue but my node is fully synced rn and my target height is like 130 blocks lower than my actual height, which seems weird
-
moneromooo
Most people get it wrong. Target height is a sync mode variable. It has no meaning after you're synced.
-
hyc
then perhaps the code in core_rpc_server.cpp should be fixed to explicitly report zero when node is sync'd
-
hyc
or get_target_height should be fixed to return 0 in that situation
-
ErCiccione
selsta hyc: got it. I'm gonna update the docs.
-
hyc
cool
-
ErCiccione
-
Snipa
.merges
-
xmr-pr
6747 6826 6829 6830 6849 6856 6858 6873 6892 6895 6898 6903 6913 6915 6920 6921 6922 6924
-
Snipa
Oooft, looks like I've got some catching up to do.
-
luigi1111w
.merges
-
xmr-pr
6747 6826 6829 6830 6849 6856 6858 6873 6892 6895 6898 6903 6913 6915 6920 6921 6922 6924
-
luigi1111w
for both?
-
selsta
these merges are not urgent
-
selsta
release has a separate list
-
luigi1111w
yes can do tomorrow
-
selsta
.merge+ 6937 6943 6949 6954 6960 6971 6973 6995 6999 7008
-
xmr-pr
Added
-
selsta
hyc: the "better log message anon networks" PR is also ready I assume? if yes then we can also include it in the release
-
selsta
-
selsta
.merge+ 6897
-
xmr-pr
Added
-
hyc
selsta yeah it will conflict
-
selsta
guess we should merge yours today
-
selsta
so that xiphon can rebase afterwards for tomorrow
-
hyc
ok
-
selsta
ok luigi1111w please merge 7007 7011 today so that we avoid a conflict
-
selsta
thanks