04:17:13 uff. just noticed, i2p-zero process size is 5.8GB. 1.5GB resident. that's more than monerod is using 04:17:22 on my public node... 04:17:47 I'll never understand people writing network utilities in java 04:18:13 or any system programming, for that matter. 04:20:14 how do you expect to get any adoption if your router uses more system resources than the application it's there to support 12:15:19 -xmr-pr- selsta opened pull request #7038: build: prepare v0.17.1.4 12:15:20 -xmr-pr- > https://github.com/monero-project/monero/pull/7038 12:15:29 v0.17.1.4 merge list: 7018 7024 7026 7028 7037 7038 12:15:41 xiphon: please open 7018 and 7024 against release branch 12:30:19 -xmr-pr- xiphon opened pull request #7040: [release-v0.17] rpc: skip non-synced bootstrap daemons in --no-sync mo... 12:30:20 -xmr-pr- > https://github.com/monero-project/monero/pull/7040 12:30:20 -xmr-pr- xiphon opened pull request #7039: [release-v0.17] cryptonote_core: dandelion++ - use median remote block... 12:30:20 -xmr-pr- > https://github.com/monero-project/monero/pull/7039 12:32:51 selsta: done 12:32:57 ty 14:10:22 7038 7039 need an approval 14:14:52 afterwards we can tag I think 14:55:58 issue #7029 needs to be addressed. 14:56:07 this appears to be a regression in 17.1.3 14:56:20 whatever change was made probably should be reverted 14:58:58 adding a new field, as in PR#7030 seems like the wrong fix. it is still a breaking change in the RPC API. 15:13:30 do we know it is from v0.17.1.3? I thought the regression was from v0.17 overall 15:15:19 -xmr-pr- lh1008 opened issue #7041: Error: Error mining to daemon: Found nonce, but daemon errored out wit... 15:15:20 -xmr-pr- > https://github.com/monero-project/monero/issues/7041 15:16:05 hmmm, trying to see the commit history 15:16:13 looks like this actually hasn't changed since 2018 at least 15:16:35 the issue seems invalid 15:16:54 yea I don’t think target height ever worked this way 15:17:11 7030 should still be fine, just not for this release 15:17:23 it is definitely not OPTIONAL in the definition 15:17:30 I think the doc update was just wrong 15:18:25 monero-site commit 746a5ffb4 15:28:53 Guest20675: ^ 15:31:37 updated the ticket. at most, a doc fix is needed to correct the description in sync_info, the value is not optional 15:54:01 hyc: "adding a new field, as in PR#7030 seems like the wrong fix" 15:54:20 ^ what is the correct way at the moment to check if a node is synced or not via RPC? 15:54:47 i don't see any legit/documented way to do that 15:56:40 or should we explicitly say that "you have to deduce the node sync status by looking at the target_height" 15:58:41 yea that's why we should add 7030 15:59:02 just not for necessary for release branch IMO 16:01:07 as discussed in that ticket - when a node is sync'd, target_height is zero. 16:12:54 maybe a separate issue but my node is fully synced rn and my target height is like 130 blocks lower than my actual height, which seems weird 16:14:12 Most people get it wrong. Target height is a sync mode variable. It has no meaning after you're synced. 16:18:11 then perhaps the code in core_rpc_server.cpp should be fixed to explicitly report zero when node is sync'd 16:18:35 or get_target_height should be fixed to return 0 in that situation 16:59:31 selsta hyc: got it. I'm gonna update the docs. 17:03:23 cool 17:11:01 https://github.com/monero-project/monero-site/pull/1328 17:23:38 .merges 17:23:38 -xmr-pr- 6747 6826 6829 6830 6849 6856 6858 6873 6892 6895 6898 6903 6913 6915 6920 6921 6922 6924 17:23:47 Oooft, looks like I've got some catching up to do. 21:51:14 .merges 21:51:14 -xmr-pr- 6747 6826 6829 6830 6849 6856 6858 6873 6892 6895 6898 6903 6913 6915 6920 6921 6922 6924 21:51:22 for both? 21:51:34 these merges are not urgent 21:51:37 release has a separate list 21:51:58 yes can do tomorrow 21:59:41 .merge+ 6937 6943 6949 6954 6960 6971 6973 6995 6999 7008 21:59:41 Added 22:00:11 hyc: the "better log message anon networks" PR is also ready I assume? if yes then we can also include it in the release 22:07:27 ok will conflict with https://github.com/monero-project/monero/pull/7018 22:08:41 .merge+ 6897 22:08:41 Added 22:09:44 selsta yeah it will conflict 22:10:08 guess we should merge yours today 22:10:15 so that xiphon can rebase afterwards for tomorrow 22:10:19 ok 22:12:48 ok luigi1111w please merge 7007 7011 today so that we avoid a conflict 22:21:17 thanks