freenode #monero-dev

4 Nov 2020

Official repo: github.com/monero-project/monero || Don’t ask to ask, just ask:) || Non-dev questions -> #monero, please || Next dev meeting is detailed on the Monero meeting issue on Github: github.com/monero-project/meta/issues

• 01:00
  Lyza
  vterd with #6973 / 6974 is that going to apply daemons that are set up to relay over tor / i2p? like, will they fluff over ip4 if no outbound available
• 02:32
  vtnerd
  no, if tor/i2p is enabled, it will never use ipv4/6 for origin txes unless the daemon is re-started without those modes
• 02:32
  vtnerd
  perhaps we need to add an RPC, but the thinking was that if you enabled i2p/tor, the intent was to never to use ipv4/6 for broadcasting origin txes
• 02:33
  vtnerd
  where origin means the tx originated at that node
• 03:42
  Lyza
  for sure I agree with not using ip4 when tor / i2p are enabled
• 05:01
  gingeropolous
  ah dangit none of these mitigations are in master are they
• 05:02
  gingeropolous
  *aren;t
• 05:05
  gingeropolous
  ugh whats the suite of PRs to make my node actually useful
• 05:06
  gingeropolous
  6973, 6972, 6962, 6961 (is there a master version of that already in?... perhaps im too tired to be doing tihis...)
• 05:12
  gingeropolous
  6946, 6944, 6943, 6940, 6939, 6936, 6935, 6933, ....i wonder if i can checkout multiple PRs in a list...
• 05:23
  gingeropolous
  "Should not be doing an octopus.
• 05:23
  gingeropolous
  " oh godamnit git
• 05:23
  gingeropolous
  give you a damn octopous
• 05:32
  selsta
  gingeropolous: you should checkout release branch
• 05:32
  selsta
  and then apply the PRs from the merge list
• 05:33
  selsta
  .merges
• 05:33
  xmr-pr
  6961 6962 6966 6967 6972 6974
• 05:34
  gingeropolous
  i managed to do something on top of master.... hopefully i don't have to nuke my repo. not the best with git.
• 05:34
  gingeropolous
  but thank you :)
• 06:21
  gingeropolous
  hrm, i just started a daemon with those PRs and no preset bans.
• 06:21
  gingeropolous
  it still hasn't banned any IPs
• 08:17
  selsta
  gingeropolous: we don't do automatic bans
• 08:17
  selsta
  or which PR did you merge exactly?
• 08:18
  selsta
  6936?
• 08:19
  selsta
  they updated their behavior to appear as synchronizing so 6936 ignores them
• 08:19
  normo
  Is here a list of monerod commands, like "bytes received for category command-1002 initiated by us"
• 12:16
  selsta
  .merges
• 12:16
  xmr-pr
  6961 6962 6966 6967 6972 6974
• 12:17
  selsta
  Snipa you maybe available? :)
• 12:17
  Snipa
  Not super so, I'm more tired than I'd like to be to do merges, been monitoring work tonight.
• 12:18
  selsta
  ok will wait for luigi
• 16:34
  luigi1111w
  .merges
• 16:34
  xmr-pr
  6961 6962 6966 6967 6972 6974
• 19:31
  xmr-pr
  moneroentusi opened issue #6976: Cannot create or restore wallet on Windows 7 virtual machine
• 19:31
  xmr-pr
  > monero-project/monero #6976
• 19:46
  xmr-pr
  mj-xmr opened pull request #6977: Clang-tidy integrated into CMakeLists.txt (mj-xmr)
• 19:46
  xmr-pr
  > monero-project/monero #6977
• 19:47
  moneromooo
  Is it just me or does it feel really off putting to add one's nick in every single commit message ?
• 19:48
  asymptotically
  author and committer fields in the commit just aren't good enough!
• 20:08
  selsta
  luigi1111: do you have time for merges today? we kinda have to release soo
• 20:08
  selsta
  soon
• 20:22
  luigi1111w
  .merges
• 20:22
  xmr-pr
  Merge queue empty
• 20:29
  selsta
  luigi1111w: there will be one more from mooo
• 20:29
  selsta
  and then gui merges
• 20:29
  selsta
  afterwards we can tag both
• 20:30
  moneromooo
  .merges
• 20:30
  xmr-pr
  Merge queue empty
• 20:30
  moneromooo
  .merge 6979
• 20:30
  moneromooo
  .merge+ 6979
• 20:30
  xmr-pr
  ...
• 20:30
  moneromooo
  ...
• 20:30
  moneromooo
  .merges
• 20:30
  xmr-pr
  6979
• 20:31
  xmr-pr
  moneromooo-monero opened pull request #6979: p2p: rewrite boost's make_address_v4 to cater for < 1.66
• 20:31
  xmr-pr
  > monero-project/monero #6979
• 20:46
  xmr-pr
  MNSTG opened issue #6980: Monero issue
• 20:46
  xmr-pr
  > monero-project/monero #6980
• 21:23
  gingeropolous
  alll right. all the goodies in master now?
• 21:23
  gingeropolous
  yaaaaas
• 21:26
  gingeropolous
  oh wait i don't see it it in git log. bah
• 21:27
  dEBRUYNE
  Can someone close 6980?
• 21:28
  moneromooo
  done
• 21:29
  selsta
  gingeropolous: no use release branch :D
• 21:29
  selsta
  master is super behind currently
• 21:29
  gingeropolous
  17.1.1?
• 21:29
  selsta
  git checkout release-v0.17
• 21:30
  gingeropolous
  aaaah i see yes thanks
• 21:30
  asymptotically
  why do we do the dual PR thing? could the maintainers not cherrypick from master into the releases?
• 21:31
  moneromooo
  We would not want code not signed by the author..
• 21:31
  moneromooo
  It *might* work before the two branches diverge too much. Feel free to try it out.
• 21:32
  gingeropolous
  im not not licking frogs
• 21:33
  selsta
  gingeropolous: make sure to use boost 1.66 or newer
• 21:33
  selsta
  else you will need 6979
• 21:33
  gingeropolous
  well im compilin. we'll see what happens
• 21:34
  dEBRUYNE
  asymptotically: Seems less risky to simply open the PR against both branches
• 21:35
  asymptotically
  yeah i guess that the pr author might find it easier to fix any conflicts
• 21:39
  gingeropolous
  well it build so i musta had goot boost
• 21:40
  gingeropolous
  aight, that release branch is running on xmrchain.net
• 21:40
  gingeropolous
  2020-11-04 21:40:36.948 I Monero 'Oxygen Orion' (v0.17.1.1-01606ee52)
• 21:40
  gingeropolous
  <<< look right?
• 21:45
  selsta
  gingeropolous: no it builds with wrong boost too
• 21:45
  selsta
  better to check
• 21:46
  gingeropolous
  ooooooh k. googling how to find boost version.
• 21:47
  selsta
  when you enter "make" it will say Found Boost Version
• 21:47
  gingeropolous
  well thats long gone in the screen buffer
• 21:47
  selsta
  git pull origin pull/6979/head
• 21:47
  selsta
  will apply 6979
• 21:48
  gingeropolous
  -- Found Boost Version: 106501
• 21:48
  selsta
  yep better apply 6979
• 21:48
  selsta
  or wait until luigi merges it
• 21:48
  gingeropolous
  i applied. building.
• 22:29
  luigi1111w
  we good/
• 22:29
  selsta
  yep you can tag v0.17.1.2
• 22:32
  selsta
  or wait
• 22:32
  selsta
  moneromooo: can you take a look if 6979 compiles on ubuntu?
• 22:33
  selsta
  it failed according to logs here: monero-project/monero #6979/checks?check_run_id=1354968712
• 22:33
  selsta
  error: ‘class boost::asio::ip::address_v4’ has no member named ‘to_uint’;
• 22:34
  selsta
  or maybe something else failed
• 22:36
  selsta
  waiting for this now github.com/monero-project/monero/runs/1355437363 if this passes we can tag
• 22:39
  selsta
  ok same error, it wants to_ulong instead of to_uint
• 22:40
  moneromooo
  Haha, seriously...
• 22:41
  moneromooo
  Let's add this one too then.
• 22:42
  selsta
  this is net_node.inl:1504:63
• 22:42
  moneromooo
  Fucking assholes. They just renamed to_ulong to tpouint apparently.
• 22:43
  moneromooo
  So we got to work out which verison, and #if it.
• 22:46
  selsta
  ubuntu 18.04 has 1.65
• 22:46
  selsta
  mac and windows CI have boost 1.66 or newer
• 22:46
  selsta
  which both compile fine
• 22:47
  moneromooo
  Release notes for 1.66 don't mention this.
• 22:47
  moneromooo
  Well, if it works...
• 22:48
  selsta
  hmm
• 22:48
  selsta
  both win and mac have 1.74 or 1.73
• 22:48
  selsta
  so yea, it maybe did not get changed in 1.66 exactly
• 22:50
  moneromooo
  I'll see in.. ~4 mins.
• 22:51
  asymptotically
  was changed in 1.66. boost.org/doc/libs/1_65_0/doc/html/…ference/ip__address_v4/to_uint.html (change the 65 in the url to 66 :D)
• 22:52
  moneromooo
  ty
• 23:03
  moneromooo
  .merge+ 6981
• 23:03
  xmr-pr
  Added
• 23:16
  xmr-pr
  moneromooo-monero opened pull request #6981: p2p: make this work with boost <= 1.65 (pffff)
• 23:16
  xmr-pr
  > monero-project/monero #6981
• 23:42
  selsta
  luigi1111: ok all compiled now, 6981 and then v0.17.1.2 can be tagged