01:00:36 <Lyza> vterd with #6973 / 6974 is that going to apply daemons that are set up to relay over tor / i2p? like, will they fluff over ip4 if no outbound available
02:32:21 <vtnerd> no, if tor/i2p is enabled, it will never use ipv4/6 for origin txes unless the daemon is re-started without those modes
02:32:54 <vtnerd> perhaps we need to add an RPC, but the thinking was that if you enabled i2p/tor, the intent was to never to use ipv4/6 for broadcasting origin txes
02:33:10 <vtnerd> where origin means the tx originated at that node
03:42:51 <Lyza> for sure I agree with not using ip4 when tor / i2p are enabled
05:01:06 <gingeropolous> ah dangit none of these mitigations are in master are they
05:02:50 <gingeropolous> *aren;t
05:05:44 <gingeropolous> ugh whats the suite of PRs to make my node actually useful
05:06:50 <gingeropolous> 6973, 6972, 6962, 6961 (is there a master version of that already in?... perhaps im too tired to be doing tihis...)
05:12:23 <gingeropolous> 6946, 6944, 6943, 6940, 6939, 6936, 6935, 6933, ....i wonder if i can checkout multiple PRs in a list...
05:23:25 <gingeropolous> "Should not be doing an octopus.
05:23:25 <gingeropolous> " oh godamnit git
05:23:41 <gingeropolous> give you a damn octopous
05:32:44 <selsta> gingeropolous: you should checkout release branch
05:32:55 <selsta> and then apply the PRs from the merge list
05:33:01 <selsta> .merges
05:33:01 -xmr-pr- 6961 6962 6966 6967 6972 6974
05:34:30 <gingeropolous> i managed to do something on top of master.... hopefully i don't have to nuke my repo. not the best with git.
05:34:38 <gingeropolous> but thank you :)
06:21:02 <gingeropolous> hrm, i just started a daemon with those PRs and no preset bans.
06:21:09 <gingeropolous> it still hasn't banned any IPs
08:17:36 <selsta> gingeropolous: we don't do automatic bans
08:17:49 <selsta> or which PR did you merge exactly?
08:18:47 <selsta> 6936?
08:19:07 <selsta> they updated their behavior to appear as synchronizing so 6936 ignores them
08:19:41 <normo> Is here a list of monerod commands, like "bytes received for category command-1002 initiated by us"
12:16:53 <selsta> .merges
12:16:53 -xmr-pr- 6961 6962 6966 6967 6972 6974
12:17:02 <selsta> Snipa you maybe available? :)
12:17:36 <Snipa> Not super so, I'm more tired than I'd like to be to do merges, been monitoring work tonight.
12:18:01 <selsta> ok will wait for luigi
16:34:01 <luigi1111w> .merges
16:34:01 -xmr-pr- 6961 6962 6966 6967 6972 6974
19:31:08 -xmr-pr- moneroentusi opened issue #6976: Cannot create or restore wallet on Windows 7 virtual machine
19:31:08 -xmr-pr- > https://github.com/monero-project/monero/issues/6976
19:46:08 -xmr-pr- mj-xmr opened pull request #6977: Clang-tidy integrated into CMakeLists.txt (mj-xmr)
19:46:08 -xmr-pr- > https://github.com/monero-project/monero/pull/6977
19:47:02 <moneromooo> Is it just me or does it feel really off putting to add one's nick in every single commit message ?
19:48:59 <asymptotically> author and committer fields in the commit just aren't good enough!
20:08:22 <selsta> luigi1111: do you have time for merges today? we kinda have to release soo
20:08:24 <selsta> soon
20:22:41 <luigi1111w> .merges
20:22:41 <xmr-pr> Merge queue empty
20:29:34 <selsta> luigi1111w: there will be one more from mooo
20:29:51 <selsta> and then gui merges
20:29:58 <selsta> afterwards we can tag both
20:30:01 <moneromooo> .merges
20:30:01 <xmr-pr> Merge queue empty
20:30:12 <moneromooo> .merge 6979
20:30:19 <moneromooo> .merge+ 6979
20:30:19 <xmr-pr> ...
20:30:28 <moneromooo> ...
20:30:50 <moneromooo> .merges
20:30:50 -xmr-pr- 6979
20:31:08 -xmr-pr- moneromooo-monero opened pull request #6979: p2p: rewrite boost's make_address_v4 to cater for < 1.66
20:31:08 -xmr-pr- > https://github.com/monero-project/monero/pull/6979
20:46:08 -xmr-pr- MNSTG opened issue #6980: Monero issue
20:46:08 -xmr-pr- > https://github.com/monero-project/monero/issues/6980
21:23:33 <gingeropolous> alll right. all the goodies in master now?
21:23:49 <gingeropolous> yaaaaas
21:26:39 <gingeropolous> oh wait i don't see it it in git log. bah
21:27:28 <dEBRUYNE> Can someone close 6980?
21:28:59 <moneromooo> done
21:29:29 <selsta> gingeropolous: no use release branch :D
21:29:39 <selsta> master is super behind currently
21:29:43 <gingeropolous> 17.1.1?
21:29:54 <selsta> git checkout release-v0.17
21:30:19 <gingeropolous> aaaah i see yes thanks
21:30:38 <asymptotically> why do we do the dual PR thing? could the maintainers not cherrypick from master into the releases?
21:31:25 <moneromooo> We would not want code not signed by the author..
21:31:54 <moneromooo> It *might* work before the two branches diverge too much. Feel free to try it out.
21:32:09 <gingeropolous> im not not licking frogs
21:33:14 <selsta> gingeropolous: make sure to use boost 1.66 or newer
21:33:23 <selsta> else you will need 6979
21:33:44 <gingeropolous> well im compilin. we'll see what happens
21:34:27 <dEBRUYNE> asymptotically: Seems less risky to simply open the PR against both branches
21:35:22 <asymptotically> yeah i guess that the pr author might find it easier to fix any conflicts
21:39:18 <gingeropolous> well it build so i musta had goot boost
21:40:32 <gingeropolous> aight, that release branch is running on xmrchain.net
21:40:57 <gingeropolous> 2020-11-04 21:40:36.948	I Monero 'Oxygen Orion' (v0.17.1.1-01606ee52)
21:40:57 <gingeropolous>         <<< look right?
21:45:48 <selsta> gingeropolous: no it builds with wrong boost too
21:45:57 <selsta> better to check
21:46:14 <gingeropolous> ooooooh k. googling how to find boost version.
21:47:01 <selsta> when you enter "make" it will say Found Boost Version
21:47:12 <gingeropolous> well thats long gone in the screen buffer
21:47:29 <selsta> git pull origin pull/6979/head
21:47:36 <selsta> will apply 6979
21:48:20 <gingeropolous> -- Found Boost Version: 106501
21:48:29 <selsta> yep better apply 6979
21:48:39 <selsta> or wait until luigi merges it
21:48:47 <gingeropolous> i applied. building.
22:29:11 <luigi1111w> we good/
22:29:43 <selsta> yep you can tag v0.17.1.2
22:32:05 <selsta> or wait
22:32:44 <selsta> moneromooo: can you take a look if 6979 compiles on ubuntu?
22:33:07 <selsta> it failed according to logs here: https://github.com/monero-project/monero/pull/6979/checks?check_run_id=1354968712
22:33:19 <selsta> error: ‘class boost::asio::ip::address_v4’ has no member named ‘to_uint’;
22:34:40 <selsta> or maybe something else failed
22:36:00 <selsta> waiting for this now https://github.com/monero-project/monero/runs/1355437363 if this passes we can tag
22:39:37 <selsta> ok same error, it wants to_ulong instead of to_uint
22:40:53 <moneromooo> Haha, seriously...
22:41:04 <moneromooo> Let's add this one too then.
22:42:14 <selsta> this is net_node.inl:1504:63
22:42:54 <moneromooo> Fucking assholes. They just renamed to_ulong to tpouint apparently.
22:43:17 <moneromooo> So we got to work out which verison, and #if it.
22:46:05 <selsta> ubuntu 18.04 has 1.65
22:46:29 <selsta> mac and windows CI have boost 1.66 or newer
22:46:34 <selsta> which both compile fine
22:47:09 <moneromooo> Release notes for 1.66 don't mention this.
22:47:30 <moneromooo> Well, if it works...
22:48:03 <selsta> hmm
22:48:12 <selsta> both win and mac have 1.74 or 1.73
22:48:30 <selsta> so yea, it maybe did not get changed in 1.66 exactly
22:50:04 <moneromooo> I'll see in.. ~4 mins.
22:51:44 <asymptotically> was changed in 1.66. https://www.boost.org/doc/libs/1_65_0/doc/html/boost_asio/reference/ip__address_v4/to_uint.html (change the 65 in the url to 66 :D)
22:52:39 <moneromooo> ty
23:03:08 <moneromooo> .merge+ 6981
23:03:09 <xmr-pr> Added
23:16:09 -xmr-pr- moneromooo-monero opened pull request #6981: p2p: make this work with boost <= 1.65 (pffff)
23:16:09 -xmr-pr- > https://github.com/monero-project/monero/pull/6981
23:42:01 <selsta> luigi1111: ok all compiled now, 6981 and then v0.17.1.2 can be tagged