-
selsta
"command_line::has_arg(vm, arg_ban_list)"
-
selsta
can this be true even if I didn’t specify --ban-list as an argument?
-
moneromooo
Is there is a default, I think so.
-
moneromooo
I added a... is_arg_defaulted or so ? at some point for this.
-
selsta
I didn’t specify a default so that’s what is confusing me
-
moneromooo
Then AFAIK it should be false. Just make sure it's not leftover in the config file :)
-
selsta
-
selsta
all tests that require a daemon fail
-
selsta
due to it going into the if
-
selsta
weird
-
moneromooo
The default value for a string would be "".
-
moneromooo
For a std::string.
-
selsta
yep, but I thought that has_arg would be false if it isn’t specified
-
selsta
guess I will check for ""
-
moneromooo
I looked at arg_descruptor, the third parameter is a std::string. This {} syntax, which I liked originally, is really annoying because it allows defaults...
-
moneromooo
So it's very easy to end up forgetting fields. Especially when you add some to the structure.
-
xmr-pr
ndorf opened pull request #6921: cryptonote_core: Fix missing override warnings
-
xmr-pr
-
selsta
moneromooo: yep is_arg_defaulted is what I was looking for
-
gingeropolous
selsta, how often will monerod check --ban-list ?
-
selsta
gingeropolous: only on start
-
xmr-pr
SChernykh opened pull request #6922: Make Blockchain::get_fee_quantization_mask() compile time
-
xmr-pr
-
gingeropolous
selsta, is there a way to make it poll occasionally? though i guess we could use the daemon command instead of the startup flag too
-
gingeropolous
17.1.1 bins aren't on github (scratch-chin-emoji)
-
selsta
gingeropolous: no polling, it just loads from a text file on startup
-
selsta
but as far as we can see there are around ~150 of these nodes
-
selsta
so not too many
-
gingeropolous
as far as we can see
-
hyc
should just add ban-list as a command as well
-
hyc
so you can load a new file whenever you want
-
selsta
what i also noticed most of these nodes use non default ports
-
gingeropolous
so with: ban <IP> [<seconds>]
-
gingeropolous
, if seconds is set to 0 does that mean infinity?
-
gingeropolous
or is it actually 0
-
selsta
no
-
selsta
you can enter -1 for basically forever
-
selsta
or a large number
-
Guest59496
but still resets at restart, right?
-
selsta
yes
-
gingeropolous
there she is, in all of her bashy glory:
github.com/Gingeropolous/wackamole
-
lza_menace
that is bashy for sure
-
gingeropolous
hrm, -1 doesn't work
-
lza_menace
what is the purpse of ths script?
-
lza_menace
ban certain ips?
-
gingeropolous
does it need a bracket?
-
gingeropolous
lza_menace, yeah. asshole peers that are snooping
-
selsta
gingeropolous: it does on my system
-
gingeropolous
it needs brackets?
-
selsta
no
-
selsta
-1 works as time
-
gingeropolous
hrm
-
selsta
maybe different on linux
-
selsta
does your script wait before running sync_info?
-
gingeropolous
a little bit
-
selsta
should wait 10+ minutes to find peers and avoid false positives
-
gingeropolous
ok
-
lza_menace
how are you determining who is an asshole?
-
selsta
pop e.g. 500 blocks, start with --no-sync, wait 10 minutes and then enter "sync_info"
-
selsta
those peers that report your height are probably malicious
-
lza_menace
oh, no kidding
-
lza_menace
can anyone post some of these snoop ips so I can poke at them a bit?
-
gingeropolous
-
lza_menace
ty sir
-
selsta
-
selsta
wonder why clang static analyzer did not find this dead code
-
xmr-pr
moneromooo-monero opened pull request #6924: blockchain: remove some dead code
-
xmr-pr
-
xmr-pr
moneromooo-monero opened pull request #6923: util: fix escaping more than one ?* in glob_to_regex
-
xmr-pr
-
selsta
Alex_LocalMonero: do you still have issues with transactions sometimes completely failing to send?
-
selsta
I feel like there still is a bug with tx rebroadcasting in case Dandelion++ times out, I recently had 64 out peers and my transaction simply would not get broadcasted waiting a long time and doing "relay_tx"
-
selsta
flushing tx_pool and sending again worked in the en
-
Alex_LocalMonero
@selsta, so far not, but we've stopped having problems since we've added 2 trusted nodes (having 1 trusted node wasn't enough to stop the problem).
-
selsta
vtnerd: in case of dandelion timeout, does the transaction get relayed to all peers?
-
m2049r
i am a bit confused: how can it be that an outgoing transaction has an empty TransactionInfo->transfers() ?
-
moneromooo
If you restored it from seed/keys.
-
moneromooo
(I assume this is destination addresses)
-
m2049r
thats what i thought, but the tx key is available
-
dEBRUYNE
fluffypony: The update function for the .raw file seems to have broken by the way
-
fluffypony
oh hmmmmm
-
fluffypony
I don't know if we ever got round to redoing that on the new server
-
fluffypony
I'll chat to pigeons about it
-
dEBRUYNE
I think a user reported that the current file only has blocks up till a year ago :-P
-
moneromooo
hyc: in db_lmdb.cpp, there is a mdb_cursor_del(m_cur_blocks, 0) whithout a preliminary get. That looks dodgy to me. It might be relying on the cursor being set previously, but it's far from obvious. Am I missing something and it's set by the ops on the ohter tables somehow ?
-
dEBRUYNE
Btw, do you think you are still able to update the DNS for the auto-updater today?
-
moneromooo
That's in BlockchainLMDB::remove_block
-
fluffypony
dEBRUYNE: yes busy doing it
-
dEBRUYNE
All right, great
-
selsta
fluffypony: and please also push the hashes.txt.sig to the website repo again like last time
-
selsta
this can be done after DNS
-
selsta
does not matter
-
fluffypony
selsta: done
-
selsta
thx
-
selsta
can you also push the website or should I ping bF for that?
-
fluffypony
bf must do that
-
fluffypony
still busy with DNS recs
-
selsta
binaryFate: ^
-
fluffypony
really struggling with these DNS recs
-
fluffypony
since the changeover
-
fluffypony
I'm going to try again tomorrow with a fresh brain
-
fluffypony
I'm obviously doing something stupid