00:17:22 <selsta> "command_line::has_arg(vm, arg_ban_list)"
00:17:36 <selsta> can this be true even if I didn’t specify --ban-list as an argument?
00:19:31 <moneromooo> Is there is a default, I think so.
00:19:50 <moneromooo> I added a... is_arg_defaulted or so ? at some point for this.
00:20:19 <selsta> I didn’t specify a default so that’s what is confusing me
00:21:10 <moneromooo> Then AFAIK it should be false. Just make sure it's not leftover in the config file :)
00:21:24 <selsta> https://github.com/monero-project/monero/pull/6920/
00:21:51 <selsta> all tests that require a daemon fail
00:22:02 <selsta> due to it going into the if
00:22:03 <selsta> weird
00:25:06 <moneromooo> The default value for a string would be "".
00:25:15 <moneromooo> For a std::string.
00:25:37 <selsta> yep, but I thought that has_arg would be false if it isn’t specified
00:25:42 <selsta> guess I will check for ""
00:26:34 <moneromooo> I looked at arg_descruptor, the third parameter is a std::string. This {} syntax, which I liked originally, is really annoying because it allows defaults...
00:26:58 <moneromooo> So it's very easy to end up forgetting fields. Especially when you add some to the structure.
00:31:08 -xmr-pr- ndorf opened pull request #6921: cryptonote_core: Fix missing override warnings
00:31:08 -xmr-pr- > https://github.com/monero-project/monero/pull/6921
00:36:36 <selsta> moneromooo: yep is_arg_defaulted is what I was looking for
02:27:37 <gingeropolous> selsta, how often will monerod check --ban-list ?
06:57:41 <selsta> gingeropolous: only on start
12:31:08 -xmr-pr- SChernykh opened pull request #6922: Make Blockchain::get_fee_quantization_mask() compile time
12:31:08 -xmr-pr- > https://github.com/monero-project/monero/pull/6922
13:04:15 <gingeropolous> selsta, is there a way to make it poll occasionally? though i guess we could use the daemon command instead of the startup flag too
13:17:59 <gingeropolous> 17.1.1 bins aren't on github (scratch-chin-emoji)
13:34:54 <selsta> gingeropolous: no polling, it just loads from a text file on startup
13:35:05 <selsta> but as far as we can see there are around ~150 of these nodes
13:35:11 <selsta> so not too many
13:49:11 <gingeropolous> as far as we can see
14:15:23 <hyc> should just add ban-list as a command as well
14:15:29 <hyc> so you can load a new file whenever you want
14:23:04 <selsta> what i also noticed most of these nodes use non default ports
15:07:01 <gingeropolous> so with:   ban <IP> [<seconds>]
15:07:01 <gingeropolous>  , if seconds is set to 0 does that mean infinity?
15:07:12 <gingeropolous> or is it actually 0
15:10:10 <selsta> no
15:10:20 <selsta> you can enter -1 for basically forever
15:10:24 <selsta> or a large number
15:11:51 <Guest59496> but still resets at restart, right?
15:12:11 <selsta> yes
15:21:14 <gingeropolous> there she is, in all of her bashy glory: https://github.com/Gingeropolous/wackamole
15:38:29 <lza_menace> that is bashy for sure
15:39:09 <gingeropolous> hrm, -1 doesn't work
15:39:31 <lza_menace> what is the purpse of ths script?
15:39:53 <lza_menace> ban certain ips?
15:41:03 <gingeropolous> does it need a bracket?
15:41:46 <gingeropolous> lza_menace, yeah. asshole peers that are snooping
15:42:07 <selsta> gingeropolous: it does on my system
15:42:30 <gingeropolous> it needs brackets?
15:42:36 <selsta> no
15:42:39 <selsta> -1 works as time
15:42:49 <gingeropolous> hrm
15:42:50 <selsta> maybe different on linux
15:43:49 <selsta> does your script wait before running sync_info?
15:44:36 <gingeropolous> a little bit
15:45:14 <selsta> should wait 10+ minutes to find peers and avoid false positives
15:46:57 <gingeropolous> ok
15:55:06 <lza_menace> how are you determining who is an asshole?
15:55:41 <selsta> pop e.g. 500 blocks, start with --no-sync, wait 10 minutes and then enter "sync_info"
15:56:06 <selsta> those peers that report your height are probably malicious
15:56:24 <lza_menace> oh, no kidding
16:13:21 <lza_menace> can anyone post some of these snoop ips so I can poke at them a bit?
16:14:00 <gingeropolous> selsta> https://paste.debian.net/hidden/54cda36c/
16:14:12 <lza_menace> ty sir
16:15:22 <selsta> lza_menace: this one is fresh https://paste.debian.net/hidden/64201b80/
16:53:30 <selsta> wonder why clang static analyzer did not find this dead code
17:01:08 -xmr-pr- moneromooo-monero opened pull request #6924: blockchain: remove some dead code
17:01:09 -xmr-pr- > https://github.com/monero-project/monero/pull/6924
17:01:09 -xmr-pr- moneromooo-monero opened pull request #6923: util: fix escaping more than one ?* in glob_to_regex
17:01:09 -xmr-pr- > https://github.com/monero-project/monero/pull/6923
17:15:17 <selsta> Alex_LocalMonero: do you still have issues with transactions sometimes completely failing to send?
17:21:03 <selsta> I feel like there still is a bug with tx rebroadcasting in case Dandelion++ times out, I recently had 64 out peers and my transaction simply would not get broadcasted waiting a long time and doing "relay_tx"
17:21:12 <selsta> flushing tx_pool and sending again worked in the en
17:28:35 <Alex_LocalMonero> @selsta, so far not, but we've stopped having problems since we've added 2 trusted nodes (having 1 trusted node wasn't enough to stop the problem).
17:31:40 <selsta> vtnerd: in case of dandelion timeout, does the transaction get relayed to all peers?
18:09:16 <m2049r> i am a bit confused: how can it be that an outgoing transaction has an empty TransactionInfo->transfers() ?
18:11:32 <moneromooo> If you restored it from seed/keys.
18:11:49 <moneromooo> (I assume this is destination addresses)
18:13:27 <m2049r> thats what i thought, but the tx key is available
18:52:33 <dEBRUYNE> fluffypony: The update function for the .raw file seems to have broken by the way
18:52:45 <fluffypony> oh hmmmmm
18:52:59 <fluffypony> I don't know if we ever got round to redoing that on the new server
18:53:03 <fluffypony> I'll chat to pigeons about it
18:54:36 <dEBRUYNE> I think a user reported that the current file only has blocks up till a year ago :-P
18:54:47 <moneromooo> hyc: in db_lmdb.cpp, there is a mdb_cursor_del(m_cur_blocks, 0) whithout a preliminary get. That looks dodgy to me. It might be relying on the cursor being set previously, but it's far from obvious. Am I missing something and it's set by the ops on the ohter tables somehow ?
18:54:58 <dEBRUYNE> Btw, do you think you are still able to update the DNS for the auto-updater today?
18:55:06 <moneromooo> That's in BlockchainLMDB::remove_block
18:57:12 <fluffypony> dEBRUYNE: yes busy doing it
19:05:27 <dEBRUYNE> All right, great
19:09:42 <selsta> fluffypony: and please also push the hashes.txt.sig to the website repo again like last time
19:09:49 <selsta> this can be done after DNS
19:09:53 <selsta> does not matter
19:15:16 <fluffypony> selsta: done
19:16:02 <selsta> thx
19:16:19 <selsta> can you also push the website or should I ping bF for that?
19:24:02 <fluffypony> bf must do that
19:24:05 <fluffypony> still busy with DNS recs
19:26:08 <selsta> binaryFate: ^
19:35:42 <fluffypony> really struggling with these DNS recs
19:35:50 <fluffypony> since the changeover
19:40:24 <fluffypony> I'm going to try again tomorrow with a fresh brain
19:40:44 <fluffypony> I'm obviously doing something stupid