-
xiphon
Huh. Yep. Checked the code. Unfortunately it selects random out peer
-
selsta
So the only question remaining is do nodes that are not synced immediately drop all transactions?
-
xiphon
sure, they do
-
xiphon
-
selsta
vtnerd: please take a look at
monero-project/monero #6875
-
xmr-pr
xiphon opened pull request #6875: Dandelion++: skip desynced peers in stem phase (public networks)
-
xmr-pr
-
Kronovestan
Are blocks 20 mins now instead of 2 mins?
-
Inge-
Lolwut?
-
Inge-
it happens
-
xmr-pr
gillkaurav opened issue #6876: Monero
-
xmr-pr
-
binaryFate
nice catch xiphon. I've seen quite a lot of people reporting delays before it is visible to receiver (several minutes) clearly indicating initial broadcast failing. Hopefully that was mostly due to that.
-
xiphon
yeah, noticed the delays a while back, will see how it goes
-
Mmmmmmmmmmm
What's your development environment look like when you're working on Monero? There isn't an MSVC .sln file. What IDE are you using? Thanks
-
asy
Mmmmmmmmmmm: you don't need an ide :) just cmake and make. if you really want one, clion works well, but it uses lots of memory on big projects like monero
-
sech1
cmake
-
sech1
it can in theory create MSVC solution too, but I haven't tried it
-
sech1
and it probably won't compile
-
asy
yeah i think he discovered last time it doesn't build with msvc. i think you can get visual studio to use clang though
-
moneromooo
So MSVC becomes just a spyware layer over CLANG ?
-
moneromooo
Given Windows can now run ubuntu, it's just a spyware layer over linux.
-
moneromooo
Makes you wonder why they still manage to peddle that.
-
asy
-
moneromooo
Must be why people love bitcoin.
-
moneromooo
PLEASE SEE ALL MY TXES I FEEL SO LONELY
-
moneromooo
Oops, that's -dev. /me slithers away
-
Mmmmmmmmmmm
It wont with MSVC, you're right. But I mean, but when I'm working on projects at work I work with MSVC and .sln/vcxproj files. I have everything in my IDE, and I can easily work on various .h or .cpp files (
i.imgur.com/0Jjfu5z.png). What's the workflow for working on Monero? Do people open the individual cpp or .h file they want to change
-
Mmmmmmmmmmm
on their branch, make the change, write some tests, run the tests, then rebuild the application before submitting a MR?
-
moneromooo
As opposed to... what (modulo tests) ?
-
moneromooo
typically changes will involve multiple files, but... yes I guess ?
-
Mmmmmmmmmmm
Ok, thanks for confirming.
-
Mmmmmmmmmmm
Is there any plan to move to C++17?
-
sech1
There are some parts written in plain C even.
-
sech1
moving for the sake of moving is not a good idea. There must be clear benefits from this
-
Mmmmmmmmmmm
(y)
-
selsta
ping TheCharlatan do you have time to take a look at
monero-project/monero #6862 ?
-
selsta
we will do a point release soon most likely
-
ErCiccione[m
Reminder that as for every year , few days ago a new haktoberfest started. It's a good way to attract contributor and gives the possibility to win a t shirt or plant a tree. This year repositories have to opt in. To opt in is enough to put "hacktoberfest" to the topics of the monero repositories
-
ErCiccione[m
I would put it on monero-site and monero-gui, but also monero.
-
ErCiccione[m
-
selsta
ErCiccione[m: hacktoberfest was a shitshow this year sadly, lots of spam contributions on other repository
-
hyc
yeah, it's amazing what garbage people will spew to get a t-shirt
-
ErCiccione[m
yeah, i haven't participated in the last couple of year. The new opt-in rule was just added to avoid spam
-
selsta
-
ErCiccione[m
-
TheCharlatan
selsta will have it tested later today.
-
selsta
thank you
-
ErCiccione[m
Wow. I didn't know such mess happened. Making it opt in will help, hopefully
-
Kronovestan
selsta, one thing I noticed is on the monero post about the new upgrade it doesn't say what block it will happen on. Had to go dig and find it in the code.
-
selsta
monero post?
-
selsta
Do you mean release notes?
-
Kronovestan
yes
-
Kronovestan
-
Kronovestan
selsta, that link
-
selsta
Kronovestan: not sure if the height was set at this point
-
selsta
TheCharlatan: please also approve branch PR