-
gingeropolous
was the boost stuff mostly serialization?
-
moneromooo
That question is not clear enough.
-
gingeropolous
im trying to find the commits that removed boost, and so far my cursory github website search yields;
monero-project/monero 7175dcb
-
moneromooo
There was a recent commit that replaced a good amount of boost serialization with monero serialization.
-
gingeropolous
yeah, thats all i could find.
-
moneromooo
This leaves some that can't be reached from an adversary (which does not control your disk). It also still leaves most boost usage.
-
gingeropolous
ah ok. i just remember always complaining about boost and whether we could do away with it, and I was told that removing boost needs to be done carefully
-
gingeropolous
so to see it go so nonchalantly caught me off guard
-
ErCiccione[m]
I'm reading many comments from people that find unclear what went into the release. That's something that bugged me a bit as well, because there is no way that the average person has any idea of what is being added or changed. Also we don't link changes to pull requrest so people have to make the searches by themselves, but often the description in the release notes don't match the description in the PR.
-
ErCiccione[m]
I like a lot how matrix show their changes. See this release for example:
github.com/matrix-org/synapse/releases/tag/v1.20.0rc1
-
ErCiccione[m]
they achieve that by using a "changelog" file, which is updated with each PR.
-
ErCiccione[m]
I'm not sure how that works, i will look it up, because i think it worth to integrate something like that.
-
ErCiccione[m]
To be clear: with "bugged me a bit", i mean that it's something i've been thinking about ways to improve that for a long time. Selsta's release notes improved the situation a bit, but i think we still have a lot to improve. The thing is to manage to do that without too much effort from the contributors/maintainers
-
fluffypony
ErCiccione[m]: one thing that I've noticed some projects do is to create an issue against PRs, and then reference the issue instead of the PRs
-
fluffypony
so "improved xxx (#3244)"
-
fluffypony
and if someone wants to learn more they can dig into issue #3244
-
fluffypony
which is also referenced in PRs, so you can see how it was solved
-
fluffypony
but it does require contributors to be a little more organised
-
fluffypony
and it raises the barrier to entry wrt contributing
-
ErCiccione[m]
Yeah that would be useful too and i think is the standard workflow for a platform like github, but i don't think it's necessary
-
ErCiccione[m]
and as you say, yes, it would require more effort
-
ErCiccione[m]
-
ErCiccione[m]
^ this would only require to add a file to a changelog.d folder with each pr. It's a thing more to do, but super easy to do
-
sech1
"Deterministic unlock times" was very unclear description. I had to go through PR code to figure out what it was. Turns out it was a fix for a very specific case when time-locked transactions use timestamp to unlock, and this timestamp is now calculated from blockchain data only.
-
sech1
*timestamp to compare to is calculated from blockchain data
-
salutnomo
anyone else getting a "404 Not Found [IP: 91.189.88.152 80]" when trying to build monero using the dockerized instructions? it used to work on the exact same setup / networkdoes this mean ubuntu repos are down?
-
salutnomo
to give more context```Err:1
archive.ubuntu.com/ubuntu xenial-updates/main amd64 libudev-dev amd64 229-4ubuntu21.28 404 Not Found [IP: 91.189.88.152 80]E: Failed to fetch
archive.ubuntu.com/ubuntu/pool/main…udev-dev_229-4ubuntu21.28_amd64.deb 404 Not Found [IP: 91.189.88.152 80]```
-
salutnomo
alternatively if someone could confirm that building the latest monero works as of now / the last two hours that would already help because then I'd know the issue is on my end
-
selsta
The docker image is kinda unmaintained, most people build from source without it
-
asy
is it because ubuntu xenial is EOL?
-
selsta
-
selsta
^ is more maintained I think
-
dsc_
archive.ubuntu.com/ubuntu/pool/main…udev-dev_229-4ubuntu21.29_amd64.deb seems to be available so maybe just a matter of `sudo apt update` or `sudo apt clean && sudo apt update`
-
salutnomo
I was following these instructions which are listed at the very top, so I thought it was the recommended way
github.com/monero-project/monero-gu…-static-binaries-with-docker-any-os
-
selsta
Oh this is GUI?
-
salutnomo
just to clarify I'm looking to run it natively, I just wanted to use the docker-based instructions for a more reliable / system independent build
-
salutnomo
Yes it's about monero-wallet-gui, am I in the wrong channel then?
-
selsta
yea gui should build fine with that docker file, or it did in the past
-
dsc_
github.com/monero-project/monero-gui/blob/master/Dockerfile#L5 change that into `RUN apt clean && apt update` and try again.
-
dsc_
Might work. ¯\_(ツ)_/¯
-
salutnomo
dsc_ Did that and it's looking good as now the install of the buildtools within the docker container actually worked. It's still running now and I will report back whether this allows the build to complete fully
-
happyfr0gg
I need help with understanding monerod.exe
-
happyfr0gg
I'm syncing now. It is downloading the XMR blockchain.
-
happyfr0gg
The new top block candidate is 1505728 -> 2190170. What do these two numbers mean?
-
moneromooo
Your height, the peer's claimed height.
-
salutnomo
Those two numbers together mean you're almost halfway through syncing (though later parts of the blockchain might sync faster as there were algorithm and space efficiency improvements implemented)
-
salutnomo
*more than halfway
-
happyfr0gg
Synced 1513928/2190177 (69%, 676249 left)
-
happyfr0gg
When it is done which number should I have?
-
dEBRUYNE
The numbers should be equal basically
-
dEBRUYNE
So first number == second number
-
salutnomo
it will be done when it reaches 2190177 + the number of new blocks minted until you almost reach the finish line
-
salutnomo
you're essentially playing "catch up", but you're downloading probably hundreds of blocks per minute and there is about one new block every two minutes added to the second number - this means you're catching up much quicker than the chain is moving forward so you'll soon end up with the scenario dEBRUYNE explained
-
happyfr0gg
Thanks guys. That all helps me understand this better.
-
salutnomo
dsc_ I can happily report that your tip fixed the build procedure and I am now successfully running the latest version of monerod / monero-wallet-gui. Thank you!
-
dsc_
weee
-
happyfr0gg
How do I determine the estimated file size of the monero blockchain?
-
moneromooo
Estimated from what ?
-
happyfr0gg
I don't know.
-
moneromooo
Then you can't :)
-
moneromooo
But, are you trying to change monero, or just trying to sync a chain and not actually hack on monero ?
-
happyfr0gg
moneromooo, I'm downloading the monero blockchain. Not hacking. By the way, I found my answer to the file size of the monero blockchain. --->
bitinfocharts.com
-
moneromooo
Right, then you're in the wrong channel, try #monero.
-
happyfr0gg
Okay.