\help

exit

moneromooo: your commit 236d2a88e25f50e2249323d1dc71762f12a10364 seems to be under-reporting txn sizes

how do we get the actual txn size for an unpruned txn?

I guess you could first try to get the full tx, then the pruned one it it fails. Or pruned, thne the prunable part (and add).

I see, get_tx_blob fails if the prunable part is missing

if (!db->get_tx_blob(tx_id, bd)); { do stuff with full tx } else if (!db->get_tx_pruned_blob(tx_id, bd)) { do stuff with priued tx }

not sure why it doesn't just do what you just described, instead

Faster, no lookup needed to the prunable tx table.

But for stats, it makes sense to do what you said.

Are you doing it, or else I'll do it later today ?

I'll try it now

does this need to be PR'd against release branch too?

I wouldn't imagine it breaks anything, it's in an obscure tool.

yeah

and it's a tiny change

so txn size was under-reported by about 8x

I meant it doesn't break anything so no reason to inlcude it :D

doh

well, Dr Kim was looking for reliable numbers, and the currently released code is bogus

Hmm. That guy was mentioned yesterday. I asked Who is dr kim, I got the non reply "daniel kim", which didn't help. They apparently paid for the CLSAG audit so that got me curious. Who is that ?

Same guy that shelled out for the randomx review ?

no

he's been doing speaking gigs at conferences to introduce people to monero

he's prepping a talk for defcon and wanted blockchain stats

Ah, thanks.

Defcon? isn't that shit cancelled?

yes

every year

Is more review desired for the CLSAG PR?

Code freeeze is in 2 weeks for the October upgrade

Already ? Whee.

August 17!

Audit report is up web.getmonero.org/2020/07/31/clsag-audit.html

I want to include monero-project/monero #6337 but code freeze in 2 weeks makes me doubtful it will get reviewed in time :/

vtnerd: can you take a look at the CI issues? ^

(and also at mooos comment)

the CI issues were a bit surprising

What happened with CI?

It did not find an assembler to assemble the asm.

But since it can build stuff, it presumably has gas somewhere. So.. cmake's fault maybe ? :)

Or maybe some quirky install.