06:49:52 <Guest68574> \help
06:50:19 <Guest68574> exit
11:51:07 <hyc> moneromooo: your commit 236d2a88e25f50e2249323d1dc71762f12a10364 seems to be under-reporting txn sizes
11:51:30 <hyc> how do we get the actual txn size for an unpruned txn?
11:56:40 <moneromooo> I guess you could first try to get the full tx, then the pruned one it it fails. Or pruned, thne the prunable part (and add).
11:57:18 <hyc> I see, get_tx_blob fails if the prunable part is missing
11:57:40 <moneromooo> if (!db->get_tx_blob(tx_id, bd)); { do stuff with full tx } else if (!db->get_tx_pruned_blob(tx_id, bd)) { do stuff with priued tx }
11:57:40 <hyc> not sure why it doesn't just do what you just described, instead
11:58:02 <moneromooo> Faster, no lookup needed to the prunable tx table.
11:58:17 <moneromooo> But for stats, it makes sense to do what you said.
11:59:13 <moneromooo> Are you doing it, or else I'll do it later today ?
11:59:34 <hyc> I'll try it now
12:31:12 -xmr-pr- hyc opened issue #6732: monero-blockchain-stats underreports size of prunable txs
12:31:12 -xmr-pr- > https://github.com/monero-project/monero/issues/6732
16:01:12 -xmr-pr- hyc opened pull request #6733: Don't forget size of prunable txn part
16:01:12 -xmr-pr- > https://github.com/monero-project/monero/pull/6733
16:12:16 <hyc> does this need to be PR'd against release branch too?
16:13:05 <moneromooo> I wouldn't imagine it breaks anything, it's in an obscure tool.
16:16:24 <hyc> yeah
16:16:30 <hyc> and it's a tiny change
16:16:56 <hyc> so txn size was under-reported by about 8x
16:31:11 -xmr-pr- hyc opened pull request #6734: Don't forget size of prunable txn part [RELEASE]
16:31:12 -xmr-pr- > https://github.com/monero-project/monero/pull/6734
16:32:26 <moneromooo> I meant it doesn't break anything so no reason to inlcude it :D
16:32:51 * moneromooo doens't really care either way
16:56:28 <hyc> doh
16:56:59 <hyc> well, Dr Kim was looking for reliable numbers, and the currently released code is bogus
16:57:57 <moneromooo> Hmm. That guy was mentioned yesterday. I asked Who is dr kim, I got the non reply "daniel kim", which didn't help. They apparently paid for the CLSAG audit so that got me curious. Who is that ?
16:58:31 <moneromooo> Same guy that shelled out for the randomx review ?
17:05:07 <hyc> no
17:05:26 <hyc> he's been doing speaking gigs at conferences to introduce people to monero
17:05:38 <hyc> he's prepping a talk for defcon and wanted blockchain stats
17:05:48 <moneromooo> Ah, thanks.
17:36:32 <wizardsmoke> Defcon? isn't that shit cancelled?
17:47:28 <fluffypony> yes
17:47:30 <fluffypony> every year
18:12:19 <sarang> Is more review desired for the CLSAG PR?
18:12:33 <sarang> Code freeeze is in 2 weeks for the October upgrade
18:13:21 <moneromooo> Already ? Whee.
18:13:33 <sarang> August 17!
19:49:54 <sarang> Audit report is up https://web.getmonero.org/2020/07/31/clsag-audit.html
20:01:12 -xmr-pr- hyc opened issue #6735: Add options for blockchain-stats to print daily coin emission and fees
20:01:12 -xmr-pr- > https://github.com/monero-project/monero/issues/6735
20:01:18 <selsta> I want to include https://github.com/monero-project/monero/pull/6337 but code freeze in 2 weeks makes me doubtful it will get reviewed in time :/
20:02:21 <selsta> vtnerd: can you take a look at the CI issues? ^
20:05:57 <selsta> (and also at mooos comment)
21:49:41 <hyc> the CI issues were a bit surprising
22:20:38 <sarang> What happened with CI?
22:21:14 <moneromooo> It did not find an assembler to assemble the asm.
22:21:35 <moneromooo> But since it can build stuff, it presumably has gas somewhere. So.. cmake's fault maybe ? :)
22:22:23 <moneromooo> Or maybe some quirky install.