-
maybefbi
hyc: ok. people seem to have trouble writing randomx in golang or any other vm because of this one instruction.
-
maybefbi
oops sorry wrong channel
-
selsta
rbrunner: Do you know when you will have the help PR ready?
-
rbrunner
Did not even start yet :) Did not give it any priority so far, waiting for opinions.
-
rbrunner
But a minimal version would not be that complicated.
-
rbrunner
You think about taking it in for the release?
-
selsta
I wonder if we should revert the help change in v0.16 branch
-
selsta
and then you can fix it in master
-
selsta
without any time pressure
-
rbrunner
You mean revert the whole "help_advanced" PR? Make it as if that never happened?
-
selsta
yes
-
selsta
only in release-v0.16 branch
-
rbrunner
Well, sounds a little drastic. I mean, maybe "help_advanced" is not the best of ideas, but it exists now, and it must be that people use it ...
-
rbrunner
And the short help text with "help" now is nice
-
selsta
It wouldn’t be drastic because the help_advanced thing was never included in a release yet
-
rbrunner
Huh? Are you sure?
-
selsta
yes
-
selsta
I would prefer to include it once all the issues are fully resolved
-
rbrunner
Color me surprised
-
rbrunner
Well, if you are going to revert it, you will also have to revert some later PR's that replace "help" with "help_advanced" in places where the original PR not yet did, as far as I remember
-
rbrunner
I think monermooo did one of those
-
selsta
yep
-
hyc
if "help <command>" doesn't work as before, then all those related patches are a UX regression
-
selsta
yes that’s why I want to revert it
-
selsta
for the release
-
hyc
great
-
rbrunner
Alright, almost convinced. I think we could find a good way with short, concise command list display versus complete list without the drawbacks of a fully new command
-
hyc
this all looks to me like "if it ain't broke don't fix it" - what is the point?
-
hyc
who is having trouble finding the info they need in the current help output?
-
hyc
versus - who will have trouble finding what they need with any suggested changes?
-
hyc
I can tell you, more people will be in the latter group.
-
selsta
Some new users will feel overwhelmed if help prints 100 commands, I think the idea of a simplified help is ok.
-
hyc
new CLI users?
-
selsta
Just has to be implemented good without breaking existing commands.
-
hyc
100 commands is quie an exaggeration
-
selsta
nope, help prints 120 lines
-
selsta
in monero-wallet-cli
-
hyc
hmmm
-
hyc
then someone should break things up into classes
-
hyc
like gdb help does
-
selsta
-
selsta
maybe the `welcome` command can list the most used commands
-
hyc
-
selsta
looks also reasonable
-
ErCiccione[m]
In any case `help all` would be way better than `help_advanced`
-
shillo
-
shillo
whoops sorry