-
azy
i wish to use the stagenet but i cant find a remote node or a working faucet
-
selsta
-
selsta
worked yesterday
-
azy
oh... a m inute ago that faucet threw an error
-
azy
thank you
-
TrasherDK
azy: Start a XMRig on stagenet and you will have coins in no time. You can't use a remote node for that. Run your own.
-
woodser
on master with a fresh install, I'm seeing wallet2 return balance and account information for account 0 only (e.g. wallet2.balance_all()). the wallet has balances in other accounts. I also see a test failure unit_tests. Wondering if anyone is encountering the same or knows of a possible cause?
-
moneromooo
Is balance_all supposed to look in all accounts ? wallet2 has a "current account" concept, though a couple RPC annoyingly ignore it.
-
moneromooo
Looks like it, looking at the source.
-
woodser
the unit_tests fail on block_reward_and_current_block_weight.fails_on_huge_median_size:
paste.debian.net/1142781
-
selsta
CI passes all tests
-
selsta
same locally here
-
moneromooo
Is that related to javascript somehow ?
-
moneromooo
Compiled with... forget the name.
-
woodser
no monero-wallet-rpc shows the same behavior
-
woodser
emscripten is used to compile core c++ to webassembly, but that should be separate
-
moneromooo
OK. Any modifications ?
-
woodser
no modifications in the compiled core code, fresh download and install from master
-
moneromooo
378cdeaeaeb1dadc2dd7a324927f1af226611254 ?
-
woodser
yes
-
moneromooo
I'll give it a go later on/
-
woodser
the problem doesn't appear when compiling a branch of mine from working on the webassembly, so it seems related to updating to master
-
moneromooo
What commit hash did you fork that one from ?
-
woodser
ecb8cc9df40e466573df1c1956e374f17c960b8e Merge pull request #6397
-
selsta
woodser: that’s from 20 days ago
-
selsta
can you rebase with master?
-
moneromooo
The first commit is today's.
-
moneromooo
Unless I messed up a pull.
-
selsta
moneromooo: your commit hash is correct.
-
selsta
woodser posted one from 20 days ago
-
selsta
ah I misunderstood what he wrote :)
-
moneromooo
woodser: Unit tests on 378cdeaeaeb1dadc2dd7a324927f1af226611254 worked 2/2 here. Are you running this on a 32 bit arch ?
-
woodser
no 64 bit
-
moneromooo
Are you sure you have no modifications ?
-
woodser
I don't see how I could after trying git reset --hard upstream/master and downloading to fresh directory
-
moneromooo
Are you sure you've running the newly built binaries ?
-
woodser
yeah the tests were run against the new build directory, and I observed the problem running monero-wallet-rpc within the built bin directory
-
moneromooo
Then you get to bisect.
-
woodser
I'll continue to do difference tests between the branch that runs
-
woodser
yeah
-
woodser
the issue is caused by the if() conditionals added before expand_subaddresses() in commit bce050ee7827b630f5fce6922854c0d7d3a3896d
-
moneromooo
Oh. You were on about your balance issue ? I was on about the block weights one. That's the wallet. It has nothing to do with block weights.
-
moneromooo
Did you create a one off subaddress on that particular wallet ?
-
woodser
the wallet uses subaddresses but I don't call anything specifically to make it "one off"
-
moneromooo
Then it's not.
-
moneromooo
I think something like
paste.debian.net/hidden/6b5f0cf9. Building.
-
moneromooo
It built for me. But since tests passed before, I can't tell whether it fixes your bug.
-
moneromooo
The consensus one is the one I'd really like to fix first though :)
-
woodser
no problem I'll test it shortly
-
selsta
seems like my functional tests also fail now
-
moneromooo
Which part ?
-
selsta
running again with `--output-on-failure`
-
woodser
I'm having problems applying the patch
-
woodser
git apply patch.txt says the patch does not apply
-
moneromooo
I probably did that on my work branch, let me make if off master now...
-
moneromooo
Pff. That's the rejected flat strucutre patch again.
-
selsta
5370=
-
selsta
?
-
moneromooo
-
selsta
running with --output-on-failure and now it passed again
-
selsta
will try one more time, maybe some timing stuff again :/
-
moneromooo
5370= looks like some valgrind message prefix.
-
moneromooo
Are you running with valgrind ?
-
moneromooo
(partial prefix)
-
selsta
no, I meant if the flat structure patch is PR #5370 :D
-
moneromooo
Ah, yes it is this one.
-
selsta
because it still seems open, maybe we can get a third opinion
-
selsta
(after the release)
-
moneromooo
woodser_: if you didn't see it when you timed out:
paste.debian.net/hidden/083e8332
-
woodser_
got it, thanks
-
woodser_
accessing out of bounds memory with this :/
-
selsta
okay, tried 5 times, can’t reproduce the functional test fail
-
iDunk
-
iDunk
(On Windows)
-
iDunk
transfer sometimes works, haven't been able to reproduce the txpool one yet.
-
iDunk
Just reproduced the txpool one.
-
moneromooo
Transient and txpool sounds like dandelion.
-
selsta
vtnerd: ^
-
vtnerd
it look like a bug in the tests. if the node "rolls" fluff, then the behavior can change
-
vtnerd
crap, I don't think the dandelion++ restricted mode can easily be tested through the functional tests
-
vtnerd
I'll revert most of the recent changes then, because there isn't a way around it given all of the constraints
-
vtnerd
revert the test changes, the other code was necessary for the existing tests to work
-
moneromooo
Anyone wants to maintain the "snap" build system ? If not, it gets axed. Comment in 6475 if you want to maintain it.