12:40:57 i wish to use the stagenet but i cant find a remote node or a working faucet 12:43:37 azy: https://community.xmr.to/faucet/stagenet/ https://community.xmr.to/nodes.html 12:43:42 worked yesterday 12:44:46 oh... a m inute ago that faucet threw an error 12:53:06 thank you 13:18:56 azy: Start a XMRig on stagenet and you will have coins in no time. You can't use a remote node for that. Run your own. 15:44:44 on master with a fresh install, I'm seeing wallet2 return balance and account information for account 0 only (e.g. wallet2.balance_all()). the wallet has balances in other accounts. I also see a test failure unit_tests. Wondering if anyone is encountering the same or knows of a possible cause? 15:45:44 Is balance_all supposed to look in all accounts ? wallet2 has a "current account" concept, though a couple RPC annoyingly ignore it. 15:47:43 Looks like it, looking at the source. 15:48:08 the unit_tests fail on block_reward_and_current_block_weight.fails_on_huge_median_size: https://paste.debian.net/1142781/ 15:48:33 CI passes all tests 15:48:56 same locally here 15:51:00 Is that related to javascript somehow ? 15:51:17 Compiled with... forget the name. 15:52:27 no monero-wallet-rpc shows the same behavior 15:54:14 emscripten is used to compile core c++ to webassembly, but that should be separate 15:56:07 OK. Any modifications ? 15:56:27 no modifications in the compiled core code, fresh download and install from master 15:56:59 378cdeaeaeb1dadc2dd7a324927f1af226611254 ? 15:58:43 yes 15:59:27 I'll give it a go later on/ 16:01:52 the problem doesn't appear when compiling a branch of mine from working on the webassembly, so it seems related to updating to master 16:02:32 What commit hash did you fork that one from ? 16:05:27 ecb8cc9df40e466573df1c1956e374f17c960b8e Merge pull request #6397 16:35:22 woodser: that’s from 20 days ago 16:35:30 can you rebase with master? 16:37:19 The first commit is today's. 16:37:24 Unless I messed up a pull. 16:40:21 moneromooo: your commit hash is correct. 16:40:34 woodser posted one from 20 days ago 16:41:59 ah I misunderstood what he wrote :) 17:01:20 woodser: Unit tests on 378cdeaeaeb1dadc2dd7a324927f1af226611254 worked 2/2 here. Are you running this on a 32 bit arch ? 17:01:46 no 64 bit 17:02:14 Are you sure you have no modifications ? 17:05:43 I don't see how I could after trying git reset --hard upstream/master and downloading to fresh directory 17:06:09 Are you sure you've running the newly built binaries ? 17:07:47 yeah the tests were run against the new build directory, and I observed the problem running monero-wallet-rpc within the built bin directory 17:07:59 Then you get to bisect. 17:08:00 I'll continue to do difference tests between the branch that runs 17:08:48 yeah 17:47:46 the issue is caused by the if() conditionals added before expand_subaddresses() in commit bce050ee7827b630f5fce6922854c0d7d3a3896d 17:50:15 Oh. You were on about your balance issue ? I was on about the block weights one. That's the wallet. It has nothing to do with block weights. 17:51:17 Did you create a one off subaddress on that particular wallet ? 17:53:26 the wallet uses subaddresses but I don't call anything specifically to make it "one off" 17:55:45 Then it's not. 18:04:46 I think something like https://paste.debian.net/hidden/6b5f0cf9/. Building. 18:18:48 It built for me. But since tests passed before, I can't tell whether it fixes your bug. 18:19:10 The consensus one is the one I'd really like to fix first though :) 18:26:07 no problem I'll test it shortly 19:49:28 seems like my functional tests also fail now 19:51:28 Which part ? 19:51:51 running again with `--output-on-failure` 19:59:14 I'm having problems applying the patch 19:59:59 git apply patch.txt says the patch does not apply 20:00:37 I probably did that on my work branch, let me make if off master now... 20:02:29 Pff. That's the rejected flat strucutre patch again. 20:03:34 5370= 20:03:36 ? 20:04:51 https://paste.debian.net/hidden/083e8332/ 20:06:07 running with --output-on-failure and now it passed again 20:06:18 will try one more time, maybe some timing stuff again :/ 20:06:54 5370= looks like some valgrind message prefix. 20:07:01 Are you running with valgrind ? 20:07:13 (partial prefix) 20:07:54 no, I meant if the flat structure patch is PR #5370 :D 20:08:34 Ah, yes it is this one. 20:08:37 because it still seems open, maybe we can get a third opinion 20:09:05 (after the release) 20:12:36 woodser_: if you didn't see it when you timed out: https://paste.debian.net/hidden/083e8332/ 20:12:59 got it, thanks 20:22:44 accessing out of bounds memory with this :/ 21:25:00 okay, tried 5 times, can’t reproduce the functional test fail 21:27:52 I get transient errors here https://paste.debian.net/hidden/63455963/ 21:28:00 (On Windows) 21:28:41 transfer sometimes works, haven't been able to reproduce the txpool one yet. 21:30:33 Just reproduced the txpool one. 21:54:09 Transient and txpool sounds like dandelion. 21:55:10 vtnerd: ^ 22:15:30 it look like a bug in the tests. if the node "rolls" fluff, then the behavior can change 22:15:51 crap, I don't think the dandelion++ restricted mode can easily be tested through the functional tests 22:16:20 I'll revert most of the recent changes then, because there isn't a way around it given all of the constraints 22:22:01 revert the test changes, the other code was necessary for the existing tests to work 23:43:42 Anyone wants to maintain the "snap" build system ? If not, it gets axed. Comment in 6475 if you want to maintain it.