-
selsta
ErCiccione[m]: btw should we activate the upgrade banner on the website?
-
ErCiccione[m]
yeah, good call selsta
-
ErCiccione[m]
doing it now
-
ErCiccione[m]
-
ErCiccione[m]
selsta ^
-
fluffypony
Hi Riccardo,
-
fluffypony
-
fluffypony
shows wrong links, could you fix it please?
-
fluffypony
Matteo.
-
fluffypony
cc ErCiccione[m]
-
ErCiccione[m]
fluffypony i already PRd the fix:
monero-project/monero-site #1164
-
fluffypony
ok cool
-
ErCiccione[m]
I already pinged here from time to time asking to review it because it's actually an important PR (fix the baseurl)
-
fluffypony
I'm reviewing now
-
fluffypony
pretty simple
-
ErCiccione[m]
Thanks
-
ErCiccione[m]
.merge+ #1164
-
xmr-pr
Added
-
ErCiccione[m]
Lugi1111 please merge 1164 when you can
-
ErCiccione[m]
waiting for another approval of 1202 before adding it to the merge list. That's another PR we should merge soon btw
-
selsta
don't lime 1202 in its current form on mobile
-
selsta
like*
-
selsta
it is huge keeps reopening on every link you click
-
selsta
would prefer on home page only
-
asy
which mobile browser did you try selsta? i only used the mobile emulation in firefox dev tools but it seems okay there
-
selsta
safari
-
selsta
it shows up every time I click on something
-
asy
yeah it shows up on every new page here too, there's nothing to remember that you've dismissed it
-
selsta
don't think that's ideal
-
selsta
reminds me of reddit annoying me to use their app loo
-
selsta
lol
-
asy
half of the screen can be this banner, the top half of the screen can be "install the monero community website app" ;)
-
selsta
noooo
-
selsta
:D
-
fluffypony
hah hah
-
fluffypony
and then we just have some open-source alternatives
-
fluffypony
like Orange Alien
-
selsta
didn’t Reddit buy Alien Blue
-
selsta
and they killed it afterwards
-
moneromooo
My god, first contact and they kill it ? NOOOO
-
fluffypony
moneromooo: it eventually formed the basis of a Stargate SG1 episode, so it's fine
-
moneromooo
Indeed.
-
ErCiccione[m]
selsta: When it was homepage only people complained that going on every other page wouldn't give you the info. Especially when on the downloads page or in the user guides. About the fact that appears on every link, i don't know if that's avoidable since afaik there is no way to keep track of the user clicking on the banner using only html + css. I could be wrong tho
-
ErCiccione[m]
About the size the only way to make it smaller is either reduce the font or use less text. I'm not a fan of any of the two options
-
selsta
did you test it with a mobile phone? it is super annoying
-
selsta
not sure if there is a better solution
-
ErCiccione[m]
yeah i always test both desktop and mobile.
-
ErCiccione[m]
We can keep it homepage only
-
selsta
it takes like 1/3 of the screen and it keeps showing up no matter how often you dismiss it lol
-
ErCiccione[m]
but that would reduce a lot the efficiency of the banner
-
ErCiccione[m]
Alright, i'll just put it on the homepage only and reduce the padding
-
fluffypony
moneromooo: was that a Teal'c reference?
-
selsta
does the current website use cookies?
-
fluffypony
selsta: only CF's duid so that you don't get prompted to confirm your browser each time
-
fluffypony
the site itself doesn't
-
selsta
any way to add cookies for this banner without getting in GDPR trouble?
-
moneromooo
Take a guess :)
-
ErCiccione[m]
Nope
-
ErCiccione[m]
Well, maybe that would fit as "technical cookie"
-
ErCiccione[m]
but i doubt it
-
selsta
fluffypony: do you have a template for the mailing list that a network upgrade is upcoming?
-
fluffypony
selsta: no I would just write it up from scratch each time
-
fluffypony
you're welcome to take a previous announce and rework it
-
ErCiccione[m]
selsta: What about shortening the text of the banner to "Make sure your software is up-to-date with the October 17th network upgrade: Download Monero 0.17 "Oxygen Orion"."
-
ErCiccione[m]
basically removing "To continue using Monero after that date,"
-
ErCiccione[m]
along with padding and size improvements the banner would be much smaller
-
ErCiccione[m]
If we prefer to only have it on the home anyway doesn't matter that much tho
-
ErCiccione[m]
Sadly all layouts are based on each other except for the home. So it's either all pages or only the home
-
ErCiccione[m]
Alright, pushed. The banner is only on the homepage now
-
selsta
ok thanks
-
selsta
I'm allergic to these banners these days :D, only on the homepage is better IMO
-
selsta
though monero's banner is not hostile compared to other websites
-
ErCiccione[m]
I'm not a fan of having it only on the home, but i understand that it was annoying. I guessed that even trimming text and padding, if you find it annoying before, you'll find it annoying after too, so probably better just remove it.
-
ErCiccione[m]
^ Just to make sure my tone is not misunderstood for polemic. I meant to say that probably going from being big 1/3 of the page to 1/4 of the page wouldn't have made it less annoying if you found it annoying before :P
-
ErCiccione[m]
*as polemic
-
selsta
yep i think it's better now
-
ErCiccione[m]
.merge+ 1202
-
xmr-pr
Added
-
ErCiccione[m]
.merges
-
xmr-pr
1164 1185 1186 1193 1195 1196 1202