07:14:43 <ErCiccione> luigi1111w: wasn't conflicting, i just rebased it. I think it's a problem with the github UI. Second time that this happens. It shows as conflicting when it's actually not. Both times the PR was based on another PR
07:16:32 <ErCiccione> Or maybe flags it as conflicting because the hash of the commit already PRd changed? But that would be weird and it never happened before. Dunno
09:30:45 <ErCiccione> I couldn't find a straightforward way to implement some kind of language auto detection. If anybody has ideas about it, please share. https://github.com/monero-project/monero-site/issues/903
09:31:08 <ErCiccione> Don't know if auto detection worth it in any case tho
09:31:50 <asy> I think we can do it in nginx by inspecting headers
09:32:02 <asy> no need for scary JS
09:34:32 <ErCiccione> i thought that too, but i didn't find any info about it. I'll take a better look
09:34:46 <ErCiccione> also reminding binaryfate to upload the nginx config file so we can take a look at it
09:36:52 <ErCiccione> oh, found something immediately now 😕 no idea what i searched. nginx was the first thing i looked for :P
09:38:00 <asy> it might be annoying to users though, if they only want to access the english version or something. maybe we could move the english content to it's own subdirectory too?
09:38:08 <asy> and only redirect people accessing a page without /en/ /fr/ etc.
09:39:52 <ErCiccione> That's what i meant with "Don't know if auto detection worth it in any case tho" People could find it annoying, but i guess could be useful for the layman. Even if changing language is quite immediate
09:40:15 <ErCiccione> maybe we could move the english content to it's own subdirectory too? <- i remember reading an issue about this. I'm not sure if that's currently possible with the i18n plugin
09:41:18 <asy> i think we could do it with more nginx hackery, but it might get very ugly
09:43:41 <ErCiccione> I don't really know much about nginx beside super basic stuff. It's probably time to look it up
09:44:53 <ErCiccione> To be honest i really don't see auto detection as an important feature to have, so i wouldn't really bother with anything more complex than tweaking nginx (i'm referring to using cookies)
09:45:11 <ErCiccione> complex from a legal point of view
09:46:51 <asy> didn't the cookie law change, and now it's just specifically for tracking cookies and not preferences?
09:48:00 <asy> buttflare already sets cookies on getmonero.org, see __cfduid
09:49:10 <asy> https://support.cloudflare.com/hc/en-us/articles/200170156-Understanding-the-Cloudflare-Cookies#12345682
09:49:28 <ErCiccione> I don't know if it changed recently (talking about europe), but as far as i remember there are different "levels" and depending by how invasive, you have to prompt it to the user in different ways
09:49:59 <ErCiccione> yeah, i didn't think that we are already have that cookie
09:50:32 <ErCiccione> I'm not sure if we should point it out somewhere
09:56:03 <ErCiccione> There seems to be conflicting info about it. For some __cfduid is a "technical cookie" so it's not included in the restrictions of the cookie law, but not everybody agree.
10:00:46 <asy> tracking users for rate limiting doesn't seem to fit "strictly necessary"
10:05:00 <asy> but i anal :P
10:12:49 <ErCiccione> yeah, but whatever. I guess core made their researches before using CF
10:13:34 <ErCiccione> Going to the main subject. I seriously doubt that a cookie set for language-detection purposes fits as "technical cookie", so there is that.
10:14:18 <ErCiccione> If we manage to add auto-detection with nginx without going crazy, yeah, let's add it. otherwise i wouldn't bother
10:19:10 <ErCiccione> FWIW we pass the test on this cookie audit tool: https://2gdpr.com/853346523
10:29:52 <asy> if we did go the js route, we could maybe inspect the user's preferences and show a banner like "heads up, this page is also available in $lang. <take me there> <always take me there> <never show this again>"
10:30:16 <asy> localstorage is still subject to cookie law, but it might be okay if we never send their preferences back to the server?
10:34:13 <ErCiccione> the website is js free. So that road is barred in any case. otherwise we could have even simply displayed a banner asking the user in what language they wanted to browse the website, without even inspecting preferences. Easier and less invasive.
10:35:05 <ErCiccione> Well, technically we could do that even without js, but wouldn't make much sense
10:37:05 <asy> when we get the latest nginx config i'll try and have a play around :)
10:46:06 <ErCiccione> Sweet. Thanks
19:51:14 <ErCiccione> .merge+ 1185
19:51:14 <xmr-pr> Added