.merge+ #1080

Added

.merges

.merge+ #1079

Added

So, today i found out that 1/4 of the repository is made by duplicate screenshots -_-. I'm not gonna lie, i screamed a lot: monero-project/monero-site #1082

hmmmm

ErCiccione[m]: removing it won't change the repo size

it will remove it out of the working directory, but it'll remain in .git as it's historical

so you might as well not bother

yes sure, the git repo is gone at this point. But would be 120MB less heavy on people's hard drive, no?

It fixes runaway repo growth though.

nope

moneromooo: sure, but only if we're adding new languages or new user guides

I don't disagree with finding a way to tell jekyll "if this png doesn't exist translated use the default one"

also one nice thing ErCiccione[m] is that if these pngs have the same hash then it'll only store one blob for the history

and not hundreds of them

O yeah i got it now. The thing is that right now to change one user guide's PNGs we have to change all screenshots for all languages. That will make the history heavier with each PR and doesn't make any sense

Oh, that's a good point. I forgot about this...

you might be able to do it in Liquid, ErCiccione[m]

yeah that make sense. But still, changing more than 100 pictures when changing one user guide is insane. I think i will put all png's in the resources folder and create a folder for the languages only if the screenshots get updated

liquid doesn't handle files very well, needs some tweaks

basically we have to tell it manually where to go get the files. The "if file exists" thing doesn't work with liquid afaik

looping through site.static_files is inefficient, but given that we jekyll build infrequently I don't think it's a problem

else you have to do it in Ruby :-P

Yeah i already read that for another PR i was working on (the video in the homepage. That's the only way to do it, but i remember being problematic for some reason

are there any other changes to the _config/nginx.conf other than the version numbers?

asymptotically: that config file is quite old, may be very different now. I think binaryfate said he will upload an updated one

anyway. I feel better knowing that the size is either not affected or there is nothing to do about it anymore. Thanks fluffypony :P

not sure why the `rewrite ^ /cli/montello.tar.bz2 redirect;` goes from https to http

Will change it anyway, but i can remove the "priority" label

we have the technology to nuke all of the images :D it'll just break all of the open PRs and upset anyone that has branched off

I don't think we have open PRs touching images of the user guides. Anyway it will require time, but imo is really necessary.

Now i remember what was the issue with looping through site.static_files for the promo video. Could be not relevant in this case, which would make things easier.

I updated the issue