-
ErCiccione[m]
Hi folks. I've been testing netlify to deploy a preview of incoming PR, so that people can see a live preview right away.
-
ErCiccione[m]
Basically one we get a PR, netlify builds and deploys it. Then it posts a comment under the PR with a link to the preview of the built PR.
-
ErCiccione[m]
we spoke about it some time ago. It's a cool feature to have because allows people with no build environment to see the results of a PR right away.
-
ErCiccione[m]
I think we can integrate it quite soon. The configuration is quite straightforward, but we would need to give netlify permissions on github.
-
ErCiccione[m]
Right now the build time of a PR is ~30 minutes. It should be less after #1014, since most of the time is spent in post-processing tasks (the website itself builds in like 15 min).
-
ErCiccione[m]
My test configuration was very minimal (i only specified a ruby version to speedup things), but i think with some tweaking we can reduce the amount necessary to build.
-
ErCiccione[m]
Not of really much, because building all those blog posts requires times, but still something.
-
ErCiccione[m]
What do people think about it? IMO we could use it quite soon (once i'm done testing i would say)
-
ErCiccione[m]
We could also use github works to deploy the netlify preview, but i haven't looked into it yet.
-
ErCiccione[m]
I made a test PR on my fork on github, will post it here once the preview is deployed, to show how it would look like on the upstream repo
-
ErCiccione[m]
oh. Just finished :)
-
ErCiccione[m]
-
ErCiccione[m]
-
ErCiccione[m]
To sum up: It's very cool and i think we should implement it. I think could also push people to contribute more, since a dedicated test environment won't be strictly necessary anymore
-
fluffypony
neat
-
fluffypony
is netlify free?
-
ErCiccione[m]
yep
-
fluffypony
that is awesome, great stuff ErCiccione[m]
-
ErCiccione[m]
:)
-
ErCiccione[m]
the only meaningful limit for the free plan is the "300 build minutes/month"
-
ErCiccione[m]
Now i just managed to have a build compiled and deployed in 10 minutes. I don't think we can go lower than that, except by reducing the amount fo blog posts loaded. Which could make sense
-
ErCiccione[m]
Limiting the blog posts to 10 we build and deploy the preview in 4 minutes (cached. the first build would take much more ). I think that would be fine
-
ErCiccione[m]
Alright. I'll see if makes sense to put my few edits in a config file, after that we can already integrate it imo.
-
ErCiccione[m]
The important is to not go beyond the 300 build minutes/month limit. But if we build in 4 minutes we should be fine.
-
asymptotically
can you make it build just one page? so in the PR someone could mention whatever.html and get a link to that?
-
ErCiccione[m]
I don't think so. At the end netlify simply deploys jekyll. And you cannot build a single page with jekyll
-
ErCiccione[m]
btw if we surpass the 300 build minutes/month limit it will be $45 /month
-
ErCiccione[m]
we would have 1000 build minutes/month and 3 concurrent builds
-
ErCiccione[m]
Ok. Final tests say 4-5 minutes to build + deploy without caching and ~4 with caching. Assuming the usual volume of PRs and considering that we get a new deployment with each new commit pushed or force pushed to a PR, we should be within the range for the free account by a lot.
-
ErCiccione[m]
.merge+ #1014 #1013
-
xmr-pr
Added
-
ErCiccione[m]
.merges
-
xmr-pr
#1004 #1010 #1013 #1014 #986 #988 #994
-
luigi1111w
what is the point of 1010?
-
selsta
encouraging subaddresses
-
luigi1111w
mm, ok
-
fluffypony
and also China
-
fluffypony
:-P