-
ErCiccione[m]
selsta: i had no idea that browsers automatically query 2x images. Are you sure that works? I can just push the 2x image and maybe you can rebuild the PR and tell me if it works?
-
selsta
ErCiccione[m]: wait I’m confused now too
-
selsta
but I’m testing it currently
-
ErCiccione[m]
I thought you need to tell the browser when to use the 2x version and also where to find it
-
ErCiccione[m]
but if that works i wouldn't complain :P
-
selsta
well it looks like this only works in apps
-
selsta
currently trying .svg version
-
ErCiccione[m]
yeah, I'm trying that too
-
selsta
do you have to wait 2 minutes for every change to compile?
-
ErCiccione[m]
remove all languages except 'en' in _config.yml L27
-
selsta
svg works well
-
ErCiccione[m]
and use --limit-posts 1 when building
-
selsta
-
selsta
ErCiccione[m]: replace the png with ^
-
selsta
no other change is required
-
ErCiccione[m]
the good thing of svg. I tried earlier using the favicon but didn't work :/
-
selsta
you can also change it to .svg on the downloads site
-
selsta
nice, removing the languages speed things up alot
-
ErCiccione[m]
ah, genius me, i tried with the ccs i was testing, which uses "content" instead of list-style-image. The latter should take care of the size by itself, that why it's working i guess. Going to test it
-
ErCiccione[m]
you can also change it to .svg on the downloads site <- yes, but i'm going to open a different PR for that
-
selsta
I had to remove the width and height from the svg file to get it work
-
ErCiccione[m]
nice, removing the languages speed things up alot <- yes, the plugin build the website from scratch for every lanaguage, which is what takes a lot of time (+ loading the blog posts)
-
ErCiccione[m]
* the multilingual plugin
-
ErCiccione[m]
thanks for that selsta. I honestly don't know much about svg, only that they are light and they auto scale :)
-
selsta
stackoverflow always helps :D
-
ErCiccione[m]
stackvoerflow <3
-
selsta
I think the faq PR looks good now
-
selsta
once you update this
-
ErCiccione[m]
mmh. The svg logo doesn't show up in firefox, but works on chromium
-
selsta
:S
-
selsta
it even works in safari lol
-
selsta
okay, solved the issue
-
selsta
-
selsta
use this ^
-
selsta
firefox does not set a default size so I had to set the size to 10x10
-
ErCiccione[m]
stackoverflow did it again
-
ErCiccione[m]
alright, now looks good. Pushed the changes
-
ErCiccione[m]
.merge+ #1268
-
xmr-pr
Added
-
xmr-pr
erciccione opened pull request #1272: downloads: use svg logo and remove 'logo-list.png'
-
xmr-pr
-
selsta
ok I think I’ve reviewed everything now
-
ErCiccione[m]
You are the best man :)
-
ErCiccione[m]
best, man
-
ErCiccione[m]
.merge+ #1264 #1258 #1272
-
xmr-pr
Added
-
ErCiccione[m]
.merges
-
xmr-pr
#1258 #1259 #1262 #1264 #1268 #1269 #1270 #1271 #1272
-
ErCiccione[m]
.merge+ #1256
-
xmr-pr
...
-
ErCiccione[m]
.merges
-
xmr-pr
#1256 #1258 #1259 #1262 #1264 #1268 #1269 #1270 #1271 #1272
-
ErCiccione[m]
After those ^ are merged i will start to transfer issues and pull requests to github.
-
luigi1111w
will try to do this stuff later today
-
luigi1111w
do we want to get rid of the existing labels or have both or?
-
luigi1111w
looks like get rid of