13:46:03 -xmr-pr- erciccione opened pull request #1198: Add emails of research lab members and mask core's emails for consiste...
13:46:03 -xmr-pr- > https://repo.getmonero.org/monero-project/monero-site/merge_requests/1198
13:46:25 <ErCiccione[m]> whoo pr bot is back, nice.
14:31:03 -xmr-pr- erciccione opened pull request #1199: Deactivate 'upgrade' banner
14:31:03 -xmr-pr- > https://repo.getmonero.org/monero-project/monero-site/merge_requests/1199
15:14:24 <ErCiccione[m]> .merge+ #1198
15:14:24 <xmr-pr> Added
15:14:31 <ErCiccione[m]> .merges
15:14:31 -xmr-pr- #1177 #1181 #1182 #1186 #1192 #1194 #1195 #1196 #1198
15:29:25 <sarang> ErCiccione[m]: can you just let me know when 1198 gets merged?
15:29:38 <sarang> I'll rebase from master and avoid any other MR conflicts
15:30:57 <ErCiccione[m]> Sure. Luigi1111 could you merge those PR when you can?
15:31:52 <ErCiccione[m]> fwiw 1198 shouldn't conflict with the PR with the new paper. If that's your concern
15:35:54 <sarang> Ah ok
15:36:01 <sarang> In that case I'll remove the WIP from it
15:36:19 <sarang> and do a later MR after all are merged
15:37:16 <sarang> done
15:37:47 <sarang> Will the presence of the colon in the title be a problem?
15:37:54 <sarang> Do I need to quote-escape it?
15:38:07 <sarang> I didn't even consider that
16:23:05 <sarang> Can someone test the build for MR 1197 for that colon question?
16:28:10 <ErCiccione[m]> sarang: colons in the titles must be escaped, yes
16:28:27 <ErCiccione[m]> just p[ut the whole sentence in quotes
16:29:03 <sarang> Bah, ok
16:29:11 <sarang> Don't merge 1197 until I fix that quickly
16:29:50 <ErCiccione[m]> i don't see any colon btw. looks fine to me
16:31:21 <ErCiccione[m]> sarang what colon are you refering to?
16:31:30 <sarang> Triptych: ...
16:32:13 <ErCiccione[m]> stupid me. i got confused by the color. Yeah the whole string must be between quotes
16:33:37 <sarang> I'll update. Marked WIP to avoid accidental merge
16:33:42 <sarang> lesson learned :/
16:37:53 <sarang> Single vs double quotes?
16:37:54 <sarang> ^ ErCiccione[m]
16:38:02 <sarang> Does the parser care? Is there a style preference?
16:38:23 <ErCiccione[m]> double quotes pls
16:38:30 <sarang> roger
16:41:14 <selsta> ErCiccione[m]: gitlab-ci file needs a `.` in the beginning
16:41:28 <selsta> `gitlab-ci.yml` -> `.gitlab-ci.yml`
16:41:36 <selsta> can you PR? I don’t have the repo setup
16:44:21 <ErCiccione[m]> Oh, i must have messed up. Thanks selsta, will PR later today
16:45:03 <ErCiccione[m]> wait, can make a quick PR now
16:45:12 <selsta> ok
16:47:09 <ErCiccione[m]> selsta: https://repo.getmonero.org/monero-project/monero-site/merge_requests/1200
16:47:38 <ErCiccione[m]> could you rubberstamp it? so maybe luigi can merge it straight away
16:49:08 <selsta> done
16:49:32 <ErCiccione[m]> thanks! luigi1111 ^
16:56:09 <selsta> cool CI seems to be working now
16:56:26 <ErCiccione[m]> yep, seems to be going fine
16:57:34 <selsta> Liquid Exception: invalid byte sequence in US-ASCII in resources/user-guides/How-to-mine-Monero-XMR-without-a-mining-equipment.md
16:57:39 <ErCiccione[m]> aaand failed. I think i saw that before, something about how the docker container is configured
16:57:56 <selsta> looks fixable :P
16:58:36 <ErCiccione[m]> yeah, nothing bad. Moneromooo will be happy about it :P
16:59:01 <moneromooo> OHAI. Do I need to read the backlog ?
16:59:40 <ErCiccione[m]> nah. Pipeline failed, but should be a problem of encoding
16:59:57 <moneromooo> That's the thing you got me to add a couple weeks ago ?
17:00:34 <ErCiccione[m]> Yeah, the runner will probably need some tweaking
17:00:57 <ErCiccione[m]> i'm about to go afk for some hours. I will look into it later this evening
17:02:43 <selsta> multiple ways to solve it
17:08:04 <selsta> moneromooo: you have to do nothing it’s not setup related
17:22:22 <sarang> MR 1197 has been fixed ErCiccione[m]
17:31:03 -xmr-pr- selsta opened pull request #1201: gitlab-ci: fix UTF-8 support
17:31:03 -xmr-pr- > https://repo.getmonero.org/monero-project/monero-site/merge_requests/1201
17:51:11 <ErCiccione[m]> selsta: it's not? taking a look now
17:52:08 <ErCiccione[m]> oh i see your PR now. Is it just about enforcing the encoding?
17:53:25 <ErCiccione[m]> sarang, thanks i will test it in a bit
17:55:03 <selsta> ErCiccione[m]: AFAIK yes but my PR is untested
17:56:16 <selsta> Also I don’t understand yet, every user has to run their own runner?
17:57:56 <selsta> It would be good if the runner would also run on merge requests.
17:58:00 <ErCiccione[m]> i'm testing your patch on gitlab using their shared runners. Seems to be building for now
17:58:33 <ErCiccione[m]> if for "users" you mean "self hosted platform", yes
17:58:55 <ErCiccione[m]> and they should run on PR as well
17:59:31 <selsta> It does not. I think `only: master` means only on push to master.
17:59:56 <selsta> And when I pushed on my forked to master it asked me to setup a runner.
18:00:20 <Snipa> Yes, only: master will only trigger when it's auctually merged to master
18:00:54 <ErCiccione[m]> i see the pipeline on your PR: https://repo.getmonero.org/monero-project/monero-site/merge_requests/1201/pipelines
18:01:25 <ErCiccione[m]> I tested that configuration file opening a PR on gitlab, and it run on the PR as well
18:01:31 <selsta> Yes, it created the pipleline but it asked me to setup a runner.
18:01:46 <Snipa> Odd, it shouldn't be.  Lemme pull one of my confs.
18:02:22 <ErCiccione[m]> i made the tests on gitlab.com using their shared runners, maybe that's the difference.
18:02:45 <Snipa> I think the structure's wrong, which is why it's doing that.  Structure in my envs are only: refs: -<branch>
18:03:12 <Snipa> https://paste.centos.org/view/a31ff472
18:05:09 <selsta> I think both it valid.
18:06:03 <selsta> https://repo.getmonero.org/help/ci/yaml/README#onlyexcept-basic
18:06:18 <selsta> they have a master example without `refs:`
18:06:56 <selsta> I added `merge_requests` to only but then it asked me to setup a runner so it appears that mooos runner is only for the monero-project/monero-site repo.
18:07:17 <selsta> And I would have to setup my own. I’m sure this can be changed.
18:07:23 <ErCiccione[m]> damn, i was wromg, it doesn't build PRs also on gitlab.com :/
18:08:45 <ErCiccione[m]> selsta: yes, the runner can be shared to build PR, but at this point i'll just shut up and ask snipa for suggestions on how to set things up
18:11:47 <ErCiccione[m]> ooh here it is: https://docs.gitlab.com/ce/ci/merge_request_pipelines/index.html
18:13:23 <selsta> > Currently, those pipelines are created in a forked project, not in the parent project. This means you cannot completely trust the pipeline result, because, technically, external contributors can disguise their pipeline results by tweaking their GitLab Runner in the forked project.
18:13:39 <selsta> and forked projects don’t have a runner setup, that’s the problem
18:14:20 <selsta> moneromooo: Do you have options which projects have access to the Gitlab runner?
18:15:51 <moneromooo> I can add it to more IIRC.
18:16:07 <moneromooo> Which ones do you need it forn ?
18:16:48 <selsta> Every person would need access I guess else the on merge request feature is useless.
18:17:48 <selsta> Appears that Gitlab does not support this yet. https://gitlab.com/gitlab-org/gitlab-foss/issues/23902
18:37:40 <ErCiccione[m]> "I convinced my superiors that we do not need Jenkins, that the current GitLab can do all the same and even more, but it turned out that you do not have one of the base features." i can empathize with this guy :/
18:39:00 <selsta> yep :/
18:39:29 <selsta> i can see why it can be tricky to implement this but this is probably the most important feature for us
18:42:32 <selsta> Travis-CI also does not support Gitlab.
19:00:02 <ErCiccione[m]> well, if we cannot have runners working in a safe way against MRs (having runners running freely on all forks sounds like a security nightmare, and gitlab acknowledges that). This is the time i stop advocating for moving to gitlab. They moved that issue areound for years and now appears like they want to make it available only for enterprise users
19:00:14 <ErCiccione[m]> whicb sounds like a big middle finger to open source projects
19:01:48 <ErCiccione[m]> i mean. there are workarounds, but using APIs and external repos to run pipelines against MRs sounds ridiculus to me
19:02:54 * ErCiccione[m] brb
19:11:08 <Snipa> I mean, did anyone apply to get the commerical license yet?
19:11:15 <Snipa> As it sounds like that's still an option.
19:15:54 <selsta> Commercial license also does not support this.
19:16:06 <Snipa> Ah, that's annoying.
20:33:12 <ErCiccione[m]> yeah, they put it in the milestone for a release 1 year ago, then 6 months ago, then 3 months ago -_-
20:34:50 <moneromooo> If it's also 1.5 months ago, I think we can expect it in 1.5 months.
20:35:03 <moneromooo> Wait. No. Now.
20:38:48 <selsta> https://en.wikipedia.org/wiki/Zeno%27s_paradoxes
20:38:52 <selsta> so... never
20:38:56 <selsta> lol
21:12:17 <ErCiccione[m]> sarang: the html of 1197 needs a couple of fixes. I left 2 comments
21:15:34 <sarang> That was sloppy of me. Fixed
21:22:16 <ErCiccione[m]> Thanks. Now it's ok.
21:22:51 <ErCiccione[m]> .merge+ #1197 #1201
21:22:51 <xmr-pr> Added
21:22:56 <ErCiccione[m]> .merges
21:22:56 -xmr-pr- #1181 #1194 #1195 #1197 #1201
21:25:17 <ErCiccione[m]> pigeons please update the server when you have a chance
21:25:28 <ErCiccione[m]> and maybe binaryfate? I lost track of who have access to the server
21:25:51 <binaryFate> I can do now. Deploy current master?
21:26:10 <binaryFate> ErCiccione[m] ^
21:26:54 <ErCiccione[m]> Great. Yep :)
21:39:07 <ErCiccione[m]> I see the updates. Thanks binaryfate
21:40:30 <binaryFate> great! First time I did it so that's good :)
21:40:44 <binaryFate> pigeons to be clear, you don't need to do anything
21:41:42 <binaryFate> <ErCiccione[m]> and maybe binaryfate? I lost track of who have access to the server <--- fluffypony pigeons and me.
21:42:17 <ErCiccione[m]> Ok, good to know. Thanks.
21:43:18 <ErCiccione[m]> and yeah everything seems fine 🙂
21:46:01 <ErCiccione[m]> btw i think the caching should be adjusted binaryfate. When there are heavy changes some parts take a lot of time to load or don't load at all without cleaning the cache first (which was the case with the new download page)
21:47:08 <ErCiccione[m]> pigeons maybe could take a look? Don't know if it's nginx or cloudflare.
21:47:40 <binaryFate> I still don't have access to cloudlfare (fluffypony has to follow up). So maybe it is because I couldn't flush stuff there.
21:48:14 <binaryFate> I'd assume they detect changes on css/html and the slow time is only on first hit? Not really sure
21:49:19 <binaryFate> Also, when you said "I see the updates", it was actually still building. So maybe it was just that
21:51:52 <ErCiccione[m]> mmh, maybe, but the spreedsheet with the logos is not updated yet. See how gitlab's one is missing: https://web.getmonero.org/community/hangouts/
21:52:45 <ErCiccione[m]> *spritesheet
21:52:50 <ErCiccione[m]> and the old one is still showing: https://web.getmonero.org/img/monero-spritesheet.png
21:54:04 <ErCiccione[m]> could be just cloudflare slowly catching up, but i'm just guessing
21:55:41 <binaryFate> Caching issue yes. I did flush the CDN, so that must be cloudflare.
21:56:45 <binaryFate> I can't help this until fluffypony gives me and luigi1111 access to CF as discussed, sorry
22:13:32 <ErCiccione[m]> Got it. Thanks for looking that up.